Javanaut/ffx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test fixes 0.4.4

Browse Source
This commit is contained in:
Javanaut
2026-06-21 12:12:52 +02:00
parent 20a9bb36b8
commit 0415087e75
2 changed files with 39 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/unit/test_cli_subtitle_directory.py
View File

@@ -138,7 +138,17 @@ class SubtitleDirectoryCliTests(unittest.TestCase):
cli.normalizeSubtitleExtension(None, None, "..mkv") cli.normalizeSubtitleExtension(None, None, "..mkv")
def test_complete_basename_set_does_not_prompt(self): def test_complete_basename_set_does_not_prompt(self):
subtitleDirectory = Path(__file__).resolve().parents[1] / "assets" / "subtitles" subtitleDirectory = self.home_dir / "complete-subtitles"
subtitleDirectory.mkdir()
for basename in (
"A2_t01_2_deu_DEF",
"A2_t01_3_eng",
"A2_t01_4_eng",
):
(subtitleDirectory / f"{basename}.vtt").write_text(
"WEBVTT\n\n",
encoding="utf-8",
)
descriptor = self.make_subtitle_descriptor() descriptor = self.make_subtitle_descriptor()
context = self.make_import_context(subtitleDirectory, noPrompt=True) context = self.make_import_context(subtitleDirectory, noPrompt=True)

40
tests/unit/test_media_descriptor_import_subtitles.py
View File

@@ -7,7 +7,6 @@ import unittest
SRC_ROOT = Path(__file__).resolve().parents[2] / "src" SRC_ROOT = Path(__file__).resolve().parents[2] / "src"
ASSETS_ROOT = Path(__file__).resolve().parents[1] / "assets"
if str(SRC_ROOT) not in sys.path: if str(SRC_ROOT) not in sys.path:
sys.path.insert(0, str(SRC_ROOT)) sys.path.insert(0, str(SRC_ROOT))
@@ -21,6 +20,19 @@ from ffx.track_type import TrackType # noqa: E402
class MediaDescriptorImportSubtitlesTests(unittest.TestCase): class MediaDescriptorImportSubtitlesTests(unittest.TestCase):
COMPLETE_SIDECAR_NAMES = (
"A2_t01_2_deu_DEF",
"A2_t01_3_eng",
"A2_t01_4_eng",
)
def write_complete_sidecar_set(self, directory: str, extension: str) -> None:
for basename in self.COMPLETE_SIDECAR_NAMES:
(Path(directory) / f"{basename}.{extension}").write_text(
"WEBVTT\n\n",
encoding="utf-8",
)
def make_descriptor(self, indices=(3,)) -> MediaDescriptor: def make_descriptor(self, indices=(3,)) -> MediaDescriptor:
return MediaDescriptor( return MediaDescriptor(
context={"logger": get_ffx_logger()}, context={"logger": get_ffx_logger()},
@@ -79,11 +91,13 @@ class MediaDescriptorImportSubtitlesTests(unittest.TestCase):
def test_strict_basename_import_recognizes_vtt_asset_set(self): def test_strict_basename_import_recognizes_vtt_asset_set(self):
descriptor = self.make_descriptor(indices=(2, 3, 4)) descriptor = self.make_descriptor(indices=(2, 3, 4))
result = descriptor.importSubtitles( with tempfile.TemporaryDirectory() as tmpdir:
str(ASSETS_ROOT / "subtitles"), self.write_complete_sidecar_set(tmpdir, "vtt")
"A2_t01", result = descriptor.importSubtitles(
strict=True, tmpdir,
) "A2_t01",
strict=True,
)
self.assertEqual(3, result["candidate_count"]) self.assertEqual(3, result["candidate_count"])
self.assertEqual([2, 3, 4], result["imported_track_indices"]) self.assertEqual([2, 3, 4], result["imported_track_indices"])
@@ -103,12 +117,14 @@ class MediaDescriptorImportSubtitlesTests(unittest.TestCase):
def test_strict_basename_import_accepts_dotted_mkv_extension(self): def test_strict_basename_import_accepts_dotted_mkv_extension(self):
descriptor = self.make_descriptor(indices=(2, 3, 4)) descriptor = self.make_descriptor(indices=(2, 3, 4))
result = descriptor.importSubtitles( with tempfile.TemporaryDirectory() as tmpdir:
str(ASSETS_ROOT / "subtitles"), self.write_complete_sidecar_set(tmpdir, "mkv")
"A2_t01", result = descriptor.importSubtitles(
extension=".mkv", tmpdir,
strict=True, "A2_t01",
) extension=".mkv",
strict=True,
)
self.assertEqual(3, result["candidate_count"]) self.assertEqual(3, result["candidate_count"])
self.assertEqual([2, 3, 4], result["imported_track_indices"]) self.assertEqual([2, 3, 4], result["imported_track_indices"])