From 0415087e75c1ae31bab0858777a16555db676acc Mon Sep 17 00:00:00 2001 From: Javanaut Date: Sun, 21 Jun 2026 12:12:52 +0200 Subject: [PATCH] test fixes 0.4.4 --- tests/unit/test_cli_subtitle_directory.py | 12 +++++- .../test_media_descriptor_import_subtitles.py | 40 +++++++++++++------ 2 files changed, 39 insertions(+), 13 deletions(-) diff --git a/tests/unit/test_cli_subtitle_directory.py b/tests/unit/test_cli_subtitle_directory.py index a85dc53..3b802c3 100644 --- a/tests/unit/test_cli_subtitle_directory.py +++ b/tests/unit/test_cli_subtitle_directory.py @@ -138,7 +138,17 @@ class SubtitleDirectoryCliTests(unittest.TestCase): cli.normalizeSubtitleExtension(None, None, "..mkv") def test_complete_basename_set_does_not_prompt(self): - subtitleDirectory = Path(__file__).resolve().parents[1] / "assets" / "subtitles" + subtitleDirectory = self.home_dir / "complete-subtitles" + subtitleDirectory.mkdir() + for basename in ( + "A2_t01_2_deu_DEF", + "A2_t01_3_eng", + "A2_t01_4_eng", + ): + (subtitleDirectory / f"{basename}.vtt").write_text( + "WEBVTT\n\n", + encoding="utf-8", + ) descriptor = self.make_subtitle_descriptor() context = self.make_import_context(subtitleDirectory, noPrompt=True) diff --git a/tests/unit/test_media_descriptor_import_subtitles.py b/tests/unit/test_media_descriptor_import_subtitles.py index 707fa88..a103b55 100644 --- a/tests/unit/test_media_descriptor_import_subtitles.py +++ b/tests/unit/test_media_descriptor_import_subtitles.py @@ -7,7 +7,6 @@ import unittest SRC_ROOT = Path(__file__).resolve().parents[2] / "src" -ASSETS_ROOT = Path(__file__).resolve().parents[1] / "assets" if str(SRC_ROOT) not in sys.path: sys.path.insert(0, str(SRC_ROOT)) @@ -21,6 +20,19 @@ from ffx.track_type import TrackType # noqa: E402 class MediaDescriptorImportSubtitlesTests(unittest.TestCase): + COMPLETE_SIDECAR_NAMES = ( + "A2_t01_2_deu_DEF", + "A2_t01_3_eng", + "A2_t01_4_eng", + ) + + def write_complete_sidecar_set(self, directory: str, extension: str) -> None: + for basename in self.COMPLETE_SIDECAR_NAMES: + (Path(directory) / f"{basename}.{extension}").write_text( + "WEBVTT\n\n", + encoding="utf-8", + ) + def make_descriptor(self, indices=(3,)) -> MediaDescriptor: return MediaDescriptor( context={"logger": get_ffx_logger()}, @@ -79,11 +91,13 @@ class MediaDescriptorImportSubtitlesTests(unittest.TestCase): def test_strict_basename_import_recognizes_vtt_asset_set(self): descriptor = self.make_descriptor(indices=(2, 3, 4)) - result = descriptor.importSubtitles( - str(ASSETS_ROOT / "subtitles"), - "A2_t01", - strict=True, - ) + with tempfile.TemporaryDirectory() as tmpdir: + self.write_complete_sidecar_set(tmpdir, "vtt") + result = descriptor.importSubtitles( + tmpdir, + "A2_t01", + strict=True, + ) self.assertEqual(3, result["candidate_count"]) self.assertEqual([2, 3, 4], result["imported_track_indices"]) @@ -103,12 +117,14 @@ class MediaDescriptorImportSubtitlesTests(unittest.TestCase): def test_strict_basename_import_accepts_dotted_mkv_extension(self): descriptor = self.make_descriptor(indices=(2, 3, 4)) - result = descriptor.importSubtitles( - str(ASSETS_ROOT / "subtitles"), - "A2_t01", - extension=".mkv", - strict=True, - ) + with tempfile.TemporaryDirectory() as tmpdir: + self.write_complete_sidecar_set(tmpdir, "mkv") + result = descriptor.importSubtitles( + tmpdir, + "A2_t01", + extension=".mkv", + strict=True, + ) self.assertEqual(3, result["candidate_count"]) self.assertEqual([2, 3, 4], result["imported_track_indices"])