nightly

.gitignore

@@ -1,5 +1,4 @@
-__pycache__/
+__pycache__
-*.py[cod]
 junk/
 .vscode
 .ipynb_checkpoints/
@@ -13,11 +12,4 @@ bin/conversiontest.py
 build/
 dist/
 *.egg-info/
-.venv/
-venv/
 .codex
-
-
-*.mkv
-*.webm
-ffmpeg2pass-0.log

AGENTS.md

@@ -1,376 +0,0 @@
-# AGENTS.md
-
-This file is the entry point for agent guidance in this repository.
-
-It is intentionally generic and reusable across projects. Keep this file focused on non-project-specific constraints, working style, and the structure used to link more detailed guidance.
-
-# Purpose
-
-- Provide a small default rule set for agents working in this repository.
-- Keep the base guidance modular and easy to extend.
-- Separate reusable agent behavior from project-specific requirements.
-
-# Comment Syntax
-
-- A segment wrapped in `<!--` and `-->` is a comment and must be ignored by agents.
-- Use HTML comments for optional guidance that should stay inactive until enabled.
-- To enable an optional segment, remove the surrounding `<!--` and `-->` markers.
-
-# Core Principles
-
-- Prefer the simplest solution that satisfies the current goal.
-- Keep guidance lightweight: only add detail when it meaningfully improves outcomes.
-- Reuse modular guideline files instead of expanding this file indefinitely.
-- Treat project-specific documents as the source of truth for project behavior.
-- When guidance conflicts, use the most specific applicable document.
-
-# Rule Terms
-
-- A `rule` is the general term for any constraint, requirement, definition, or similar guidance item.
-- A `rule set` addresses all rules inside one file that share the same rule set ID.
-- Any rule inside a rule set shall use an ID following the schema `RULESET-0001`, `RULESET-0002`, and so on.
-- Rules without a rule set ID are also valid, but they are not addressable by rule ID.
-
-# Scope Of This File
-
-This file should contain:
-
-- Generic agent behavior and constraints.
-- Rules that are reusable across multiple projects.
-- Links to optional guideline modules.
-- Links to project-specific requirements.
-- Commented optional templates for released-product documentation and agent-output locations.
-
-This file should not contain:
-
-- Project business requirements.
-- Project architecture decisions.
-- Stack-specific implementation details unless they are universally applicable.
-- Task-specific runbooks that belong in dedicated modules.
-
-# Default Agent Behavior
-
-- Read the relevant context before making changes.
-- Prefer small, understandable edits over broad refactors.
-- Preserve existing patterns unless there is a clear reason to change them.
-- Document assumptions when context is missing.
-- Ignore HTML comment segments.
-- If a more specific enabled guideline exists for the current task, follow it.
-
-# Guideline Structure
-
-Use the following structure for reusable guidance files and project-specific documentation as needed:
-
-```text
-/
-|-- AGENTS.md
-|-- guidance/
-|   |-- stacks/
-|   |-- conventions/
-|   `-- workflows/
-|-- prompts/
-`-- requirements/
-
-Optional files and directories
-|-- SCRATCHPAD.md
-|-- docs/
-|   |-- readme.md
-|   |-- installation.md
-|   `-- history.md
-|-- process/
-|   |-- log.md
-|   `-- coding-handbook.md
-```
-
-# Optional Reusable Modules
-
-Add files under `guidance/` only when they are needed.
-
-# Optional Scratchpad
-
-- `SCRATCHPAD.md` is an optional repo-root scratchpad for temporary
-  information aimed at the next iteration.
-- Developers may create or delete `SCRATCHPAD.md` at any time.
-- Developers may refer to `SCRATCHPAD.md` as `scratchpad` when giving agents a
-  source or target for information.
-- Agents may read, update, create, or remove the scratchpad when the task
-  explicitly calls for it.
-- Treat the scratchpad as low-formality working context rather than canonical
-  project truth.
-- Use the scratchpad for short-lived notes, open questions, sketches, and
-  temporary decisions that should be resolved away.
-- Move durable outcomes into `requirements/`, `guidance/`, code, tests, or
-  another long-lived location.
-- If `SCRATCHPAD.md` is absent, agents should continue normally.
-
-# Optional Rule Sets
-
-- Optional rule sets may be stored in `guidance/optional/` or in `guidance/{section}/optional/`.
-- Optional rule sets are inactive by default and shall only be applied when a prompt explicitly requests them, for example by phrases such as `Apply rules for lean interface iteration in the following steps.` or `Apply LII rules.`
-- An optional rule set may be requested by its descriptive name, by its rule set ID, or by another equally clear explicit reference.
-- Agents shall never infer or auto-enable optional rule sets from general intent alone.
-- If an optional rule or rule set cannot be identified and addressed clearly, agents shall stop and ask before proceeding.
-
-# Prepared Orders
-
-- An `order` is a prepared prompt for one isolated operation rather than a general workflow or standing rule set.
-- Orders shall be stored under `prompts/`.
-- Order files shall use the naming schema `ORDER-0001-<slug>.md`, `ORDER-0002-<slug>.md`, and so on.
-- The canonical order identifier is the `ORDER-0001` style prefix. The trailing slug is descriptive only.
-- Recommended internal order file structure is: prompt ID, prompt name, purpose, trigger examples, scope, operation, and expected output.
-- Orders shall only be executed when they are explicitly requested by a prompt such as `Execute ORDER-0007.` or `Execute ORDER 7.`
-- Agents may accept an unambiguous short numeric reference such as `ORDER 7` as an alias for `ORDER-0007`.
-- If an order cannot be identified uniquely and clearly, agents shall stop and ask before proceeding.
-
-# Toolstack Guides
-
-Location:
-
-```text
-guidance/stacks/
-```
-
-Examples:
-
-- `guidance/stacks/python.md`
-- `guidance/stacks/typescript.md`
-- `guidance/stacks/docker.md`
-- `guidance/stacks/terraform.md`
-
-Use for:
-
-- Language or framework expectations.
-- Tooling and environment conventions.
-- Build, test, and runtime guidance tied to a specific stack.
-
-# Coding Conventions
-
-Location:
-
-```text
-guidance/conventions/
-```
-
-Examples:
-
-- `guidance/conventions/naming.md`
-- `guidance/conventions/testing.md`
-- `guidance/conventions/review.md`
-
-Use for:
-
-- Naming and structure conventions.
-- Testing expectations.
-- Code review and quality rules.
-
-# Recurring Workflows
-
-Location:
-
-```text
-guidance/workflows/
-```
-
-Examples:
-
-- `guidance/workflows/feature-delivery.md`
-- `guidance/workflows/bugfix.md`
-- `guidance/workflows/release.md`
-- `guidance/workflows/incident-response.md`
-
-Use for:
-
-- Repeatable task flows.
-- Checklists for common delivery work.
-- Operational or maintenance procedures.
-
-
-<!-- Enable this optional section by removing the outer HTML comment markers from this segment
-when you want agents to create, update, and consult released-product
-documentation in `docs/`.
-
-# Released Product Documentation
- 
-Released-product documentation should live outside the generic sections above.
-
-Recommended location:
-
-```text
-docs/
-```
-
-Examples:
-
-- `docs/readme.md`
-- `docs/installation.md`
-- `docs/history.md`
-
-Agent rules for docs output:
-
-- Keep content compact but comprehensive.
-- Write for end users, operators, or other consumers of the released product.
-- Prefer shipped behavior, supported workflows, and stable terminology over
-  internal implementation detail.
-- Keep documentation synchronized with released behavior.
-- Update release history when user-visible changes are shipped.
-
-Recommended topics:
-
-- Product overview and intended use.
-- Installation, configuration, and upgrade guidance.
-- Usage patterns, operational instructions, and support boundaries.
-- Compatibility notes, migration notes, and release history.
-- Troubleshooting and common pitfalls when relevant. -->
-
-
-<!-- Enable this optional section by removing the outer HTML comment markers from this
-segment when you want agents to produce and consult workflow output in `process/`.
-
-# Agent Output In `process/`
-
-The `process/` directory is primarily for agent output created during
-delivery, maintenance, and review work.
-
-Recommended location:
-
-```text
-process/
-```
-
-Agent rules for process output:
-
-- Use `process/` for agent-produced artifacts rather than released-product
-  documentation.
-- Keep entries concise, traceable, and tied to resulting changes.
-- Treat `process/` as workflow output, not as the primary source of product
-  truth.
-- Prefer summaries and rationale over raw transcript dumps unless a workflow
-  explicitly requires full prompt history.
-
-# Agent Change Log
-
-Location:
-
-```text
-process/log.md
-```
-
-Use for:
-
-- Capturing prompts given to agents.
-- Recording concise explanations of the resulting changes made by agents.
-- Preserving task-by-task rationale, decisions, and implementation notes.
-
-# Coding Handbook
-
-Location:
-
-```text
-process/coding-handbook.md
-```
-
-Use for:
-
-- A tutorial-style handbook that explains the programming components used in
-  the project.
-- Compact but comprehensive technical onboarding material for future
-  contributors.
-- Written explanations that connect code structure, concepts, and
-  implementation patterns. -->
-
-
-# Project-Specific Requirements
-
-
-Project-specific material should live outside the generic sections above.
-
-Recommended location:
-
-```text
-requirements/
-```
-
-Examples:
-
-- `requirements/project.md`
-- `requirements/architecture.md`
-- `requirements/decisions.md`
-- `requirements/domain.md`
-
-Use for:
-
-- Product and business requirements.
-- Project goals and constraints.
-- Architecture and design decisions.
-- Domain knowledge that is specific to this repository.
-
-# Agent-Level Variables
-
-When present, `requirements/identifiers.yml` is an optional project-specific
-input that defines agent-level variables for use inside `requirements/` and
-`guidance/`.
-
-Variable schema:
-
-- Use `@{VARIABLE_NAME}` for agent-level variables.
-- Prefer uppercase snake case names such as `@{PROJECT_ID}` or `@{VENDOR_ID}`.
-- Do not treat `${...}` as an agent-level variable form; that syntax may appear
-  in Bash or other code and should not be interpreted as agent metadata.
-
-Scope:
-
-- The effective scope of `requirements/identifiers.yml` is limited to
-  `requirements/` and `guidance/`.
-- Definitions from `requirements/identifiers.yml` must not leak into product code.
-
-Defaults:
-
-- Default `@{VENDOR_ID}` is `osgw`.
-- Default `@{PROJECT_ID}` is the current repository directory name.
-
-Resolution rules:
-
-- Treat `requirements/identifiers.yml` as optional; when it is absent, agents
-  may still resolve the defaults defined above.
-- If a variable is used in `requirements/` or `guidance/` and it is not
-  defined in `requirements/identifiers.yml` and does not have a default in this
-  file, agents may stop and report the undefined variable.
-- Prefer updating duplicated identifier values in `requirements/` and
-  `guidance/` to use the variable schema when that improves consistency.
-
-# Precedence
-
-Some precedence levels may be absent because optional levels can remain inside
-HTML comments. The smaller numeric index wins.
-
-Apply guidance in this order:
-
-1. Direct user or task instructions.
-2. Project-specific documents in `requirements/`.
-<!-- 3. Released-product documentation in `docs/` when shipped behavior or
-user-facing expectations are relevant. -->
-4. Relevant modular guides in `guidance/stacks/`, `guidance/conventions/`, or `guidance/workflows/`.
-<!-- 5. Agent output in `process/` when prior prompts, rationale, or
-implementation notes are relevant. -->
-6. This `AGENTS.md`.
-
-# Maintenance
-
-- Keep this file short and stable.
-- Move detail into dedicated modules when a section becomes too specific or too long.
-- Add new guideline files only when they solve a recurring need.
-- Remove outdated references when the repository structure changes.
-
-# Current Status
-
-This repository defines the base `AGENTS.md` structure plus project-specific
-requirements and modular guidance.
-
-Future project work can add:
-
-- Reusable modules under `guidance/`
-- Project-specific documentation under `requirements/`
-- Optional temporary iteration context in `SCRATCHPAD.md`
-- Optional released-product documentation under `docs/` by uncommenting its segment
-- Optional agent output under `process/` by uncommenting its segment
-- Cross-references from this file once those documents exist

README.md

@@ -1,147 +1,48 @@
 # FFX
 
-FFX is a local CLI and Textual TUI for inspecting TV episode files, storing normalization rules in SQLite, and converting outputs into a predictable stream, metadata, and filename layout.
-
-## Requirements
-
-- Linux-like environment
-- `python3`
-- `ffmpeg`
-- `ffprobe`
-- `cpulimit`
-
 ## Installation
 
-FFX uses a two-step local setup flow.
+per https:
-
-### 1. Install The Bundle
-
-This step creates or reuses the persistent bundle virtualenv in `~/.local/share/ffx.venv`, installs FFX into it, and ensures `ffx` is exposed through a shell alias.
 
 ```sh
-bash tools/setup.sh
+pip install https://<URL>/<Releaser>/ffx.git@<Branch>
 ```
 
-If you also want the Python packages needed for the modern test suite:
+per git:
 
 ```sh
-bash tools/setup.sh --with-tests
+pip install git+ssh://<Username>@<URL>/<Releaser>/ffx.git@<Branch>
 ```
 
-You can verify the bundle state without changing anything:
+## Version history
-
-```sh
-bash tools/setup.sh --check
-```
-
-### 2. Prepare System Dependencies And Local User Files
-
-This step installs or verifies workstation dependencies and seeds local config and data directories. It is the step wrapped by the CLI command `ffx configure_workstation`.
-
-Run it directly:
-
-```sh
-bash tools/configure_workstation.sh
-```
-
-Or through the installed CLI:
-
-```sh
-ffx configure_workstation
-```
-
-Check-only mode is available in both forms:
-
-```sh
-bash tools/configure_workstation.sh --check
-ffx configure_workstation --check
-```
-
-`tools/configure_workstation.sh` does not manage the bundle virtualenv. Python-side test packages belong to `tools/setup.sh --with-tests`.
-
-## Basic Usage
-
-Examples:
-
-```sh
-ffx version
-ffx inspect /path/to/episode.mkv
-ffx convert /path/to/episode.mkv
-ffx shows
-```
-
-## Modern Tests
-
-Install Python test packages first:
-
-```sh
-bash tools/setup.sh --with-tests
-```
-
-Then run the modern automatically discovered test suite:
-
-```sh
-./tools/test.sh
-```
-
-This runner uses `pytest` and intentionally excludes the legacy harness under `tests/legacy/`.
-
-## Default Local Paths
-
-- Config: `~/.local/etc/ffx.json`
-- Database: `~/.local/var/ffx/ffx.db`
-- Log file: `~/.local/var/log/ffx.log`
-- Bundle venv: `~/.local/share/ffx.venv`
-
-## TMDB
-
-TMDB-backed metadata enrichment requires `TMDB_API_KEY` to be set in the environment.
-
-## Version History
-
-### 0.2.4
-
-- lightweight CLI commands now stay import-light via lazy runtime loading
-- setup/config templating moved to `assets/ffx.json.j2`
-- aligned two-step local setup wrappers: `ffx setup` and `ffx configure_workstation`
-- combined `ffprobe` payload reuse in `FileProperties`
-- configurable crop-detect sampling plus per-process crop result caching
-- single-query controller accessors and conditional DB schema bootstrap
-- shared screen bootstrap/controller wiring for large detail screens
-- configurable default season/episode digit lengths
-- digit-aware `rename` and padded `unmux` filename markers
-
-### 0.2.3
-
-- PyPI packaging
-- output filename templating
-- season shifting
-- DB versioning
-
-### 0.2.2
-
-- CLI overrides
-
-### 0.2.1
-
-- signature handling
-- tag cleanup
-- bugfixes and refactoring
-
-### 0.2.0
-
-- tests
-- config file
-
-### 0.1.3
-
-- subtitle file imports
-
-### 0.1.2
-
-- bugfixes
 
 ### 0.1.1
 
-- bugfixes
+Bugfixes, TMBD identify shows
-- TMDB show identification
+
+### 0.1.2
+
+Bugfixes
+
+### 0.1.3
+
+Subtitle file imports
+
+### 0.2.0
+
+Tests, Config-File
+
+### 0.2.1
+
+Signature, Tags cleaning, Bugfixes, Refactoring
+
+### 0.2.2
+
+CLI-Overrides
+
+### 0.2.3
+
+PyPi packaging
+Templating output filename
+Season shiftung
+DB-Versionierung

SCRATCHPAD.md

@@ -1,128 +0,0 @@
-# Scratchpad
-
-## Goal
-
-- Capture a compact, project-wide list of optimization candidates after a broad scan of the current FFX codebase, tooling, and requirements.
-
-## Settled
-
-- The biggest near-term wins are in startup cost, repeated subprocess work, repeated database query patterns, and general repo hygiene.
-- This list is intentionally optimization-oriented rather than bug-oriented. Some items below also improve correctness or maintainability, but they were selected because they can reduce runtime cost, operator friction, or iteration overhead.
-- A first modern integration slice now exists under [`tests/integration/subtrack_mapping`](/home/osgw/.local/src/codex/ffx/tests/integration/subtrack_mapping). Remaining test-suite cleanup is now mostly about migrating and shrinking the legacy harness surface under [`tests/legacy`](/home/osgw/.local/src/codex/ffx/tests/legacy).
-- Shared CLI defaults for container/output tokens now live outside [`src/ffx/ffx_controller.py`](/home/osgw/.local/src/codex/ffx/src/ffx/ffx_controller.py), and a focused unit test locks in the lazy-import contract.
-- Helper filename and rich-text utilities now use compiled raw regexes plus translate-based filename filtering, with unit coverage for TMDB suffix rewriting and Rich color stripping.
-- Process resource limiting now has explicit disabled/default states in the CLI and requirements, and combined CPU-plus-niceness wrapping now executes as `cpulimit -- nice -n ... <command>` instead of a less explicit prefix chain.
-- FFX logger setup now reuses named handlers, and fallback logger access no longer mutates handlers in ordinary constructors and helpers.
-- The process wrapper now uses `subprocess.run(...)` with centralized command formatting plus stable timeout and missing-command error mapping.
-- Pattern matching now uses cached compiled regexes plus explicit duplicate-match errors, and pattern creation flows no longer persist zero-track patterns.
-
-## Focused Snapshot
-
-- Highest-leverage application optimizations:
-  - Decide whether placeholder help/settings screens should ship or disappear.
-  - Trim dead helpers and other dormant surface that still looks active.
-
-- Highest-leverage repo and workflow optimizations:
-  - Continue migrating the oversized legacy test/combinator surface into focused modern tests so it is easier to run, debug, and extend.
-
-## Optimization Candidates
-
-1. Placeholder UI surfaces should either ship or disappear
-- [`src/ffx/help_screen.py`](/home/osgw/.local/src/codex/ffx/src/ffx/help_screen.py) and [`src/ffx/settings_screen.py`](/home/osgw/.local/src/codex/ffx/src/ffx/settings_screen.py) are placeholders.
-- Optimization:
-  - Either remove them from the active UI surface or complete them.
-  - Avoid paying ongoing maintenance cost for unfinished navigation targets.
-- Expected value:
-  - Leaner interface.
-  - Lower UX ambiguity.
-
-2. Several helper functions are unfinished or dead-weight
-- [`src/ffx/helper.py`](/home/osgw/.local/src/codex/ffx/src/ffx/helper.py) contains `permutateList(...): pass`.
-- There are many combinator and conversion placeholders across tests and migrations.
-- Optimization:
-  - Remove dead code, finish it, or isolate it behind a clearly dormant area.
-  - Avoid carrying stubbed utility surface that looks reusable but is not.
-- Expected value:
-  - Smaller mental model.
-  - Less time spent re-evaluating inactive paths.
-
-3. Test suite shape is expensive to understand and likely expensive to run
-- The project still carries a large legacy matrix of combinator files under [`tests/legacy`](/home/osgw/.local/src/codex/ffx/tests/legacy), several placeholder `pass` implementations, and at least one suspicious filename with an embedded space: [`tests/legacy/disposition_combinator_2_3 .py`](/home/osgw/.local/src/codex/ffx/tests/legacy/disposition_combinator_2_3 .py).
-- A first focused replacement slice now exists in [`tests/integration/subtrack_mapping/test_cli_bundle.py`](/home/osgw/.local/src/codex/ffx/tests/integration/subtrack_mapping/test_cli_bundle.py), so the remaining work is migration and consolidation rather than creating the modern test shape from scratch.
-- Optimization:
-  - Continue replacing broad combinator matrices with focused parametrized integration and unit tests.
-  - Retire the bespoke legacy discovery and runner path once equivalent coverage exists.
-  - Normalize file naming and test discovery conventions.
-- Expected value:
-  - Faster contributor onboarding.
-  - Easier CI adoption later.
-
-## Open
-
-- Should optimization work focus first on operator-perceived latency, internal maintainability, or correctness-risk cleanup that also has performance upside?
-- Is the long-term supported model still “local Linux workstation plus Textual UI,” or should optimization decisions bias toward a more scriptable/headless CLI?
-
-## Gaps Right Now
-
-- No explicit prioritization owner or milestone for the optimization backlog.
-- No benchmark or timing harness exists for startup, probe, DB, or conversion orchestration overhead.
-- Repo hygiene is still mixed with generated artifacts and some clearly unfinished files.
-- The legacy TMDB-backed `Scenario 4` path is currently blocked by a pattern/track regression: `Patterns must define at least one track before they can be stored.` This surfaced while rerunning TMDB-dependent checks after the zero-track pattern hardening.
-
-## Next
-
-1. Triage the list into quick wins, medium refactors, and long-horizon cleanup.
-2. Tackle the cheapest remaining product-surface cleanup first:
-   - placeholder UI surfaces and dead helper cleanup.
-3. Continue replacing oversized legacy test matrices with focused modern integration and unit coverage.
-4. Triage the legacy `Scenario 4` pattern/track failure and decide whether to fix the harness, adapt it to the zero-track guard, or retire that path during the ongoing test-suite migration.
-
-## Shifted Season Status (2026-04-12)
-
-- Current assessment:
-  - The shifted-season subsystem is present end to end and looks feature-complete in shape, but it is not yet hardened.
-  - The storage, TUI CRUD surface, and CLI/TMDB filename application path all exist, so this is no longer a stubbed or half-started area.
-  - The main gap is correctness and direct verification rather than missing surface area.
-
-- Implemented surface confirmed:
-  - Requirements still treat shifted seasons as part of the accepted product surface in [`requirements/project.md`](/home/osgw/.local/src/codex/ffx/requirements/project.md) and [`requirements/architecture.md`](/home/osgw/.local/src/codex/ffx/requirements/architecture.md).
-  - Persistence exists via [`src/ffx/model/shifted_season.py`](/home/osgw/.local/src/codex/ffx/src/ffx/model/shifted_season.py) plus the `Show.shifted_seasons` relationship in [`src/ffx/model/show.py`](/home/osgw/.local/src/codex/ffx/src/ffx/model/show.py).
-  - CRUD logic exists in [`src/ffx/shifted_season_controller.py`](/home/osgw/.local/src/codex/ffx/src/ffx/shifted_season_controller.py).
-  - Textual add/edit/delete flows are wired through [`src/ffx/shifted_season_details_screen.py`](/home/osgw/.local/src/codex/ffx/src/ffx/shifted_season_details_screen.py), [`src/ffx/shifted_season_delete_screen.py`](/home/osgw/.local/src/codex/ffx/src/ffx/shifted_season_delete_screen.py), and the show details table in [`src/ffx/show_details_screen.py`](/home/osgw/.local/src/codex/ffx/src/ffx/show_details_screen.py).
-  - CLI conversion applies season shifts before TMDB lookup and output suffix generation in [`src/ffx/cli.py`](/home/osgw/.local/src/codex/ffx/src/ffx/cli.py).
-
-- Verified current behavior:
-  - `~/.local/share/ffx.venv/bin/python -m unittest discover -s tests/unit -p 'test_*.py'` passed on 2026-04-12: `75` tests in `0.795s`.
-  - That run emitted `ResourceWarning` messages for unclosed SQLite connections, so the suite is green but not perfectly clean.
-  - There is almost no direct shifted-season coverage in the modern tests:
-    - [`tests/unit/test_cli_rename_only.py`](/home/osgw/.local/src/codex/ffx/tests/unit/test_cli_rename_only.py) stubs `ShiftedSeasonController` rather than exercising it.
-    - [`tests/unit/test_screen_support.py`](/home/osgw/.local/src/codex/ffx/tests/unit/test_screen_support.py) only verifies controller bootstrap wiring.
-  - Net effect: the subsystem is integrated, but its core rules are effectively untested by the current modern suite.
-
-- Reproduced correctness gaps:
-  - Overlap validation is broken in [`src/ffx/shifted_season_controller.py:41`](/home/osgw/.local/src/codex/ffx/src/ffx/shifted_season_controller.py:41) because `getOriginalSeason` is compared as a method object instead of being called.
-  - Reproduction on 2026-04-12 with a temp SQLite DB:
-    - Added `S1 E1-E10`.
-    - `checkShiftedSeason(...)` incorrectly returned `True` for overlapping `S1 E5-E15`.
-    - `addShiftedSeason(...)` then stored the overlapping row successfully.
-  - `updateShiftedSeason(...)` in [`src/ffx/shifted_season_controller.py:93`](/home/osgw/.local/src/codex/ffx/src/ffx/shifted_season_controller.py:93) does not enforce episode ordering, so an invalid range like `first_episode=20`, `last_episode=10` was accepted in the same reproduction.
-  - Because [`src/ffx/shifted_season_controller.py:213`](/home/osgw/.local/src/codex/ffx/src/ffx/shifted_season_controller.py:213) returns the first matching sibling and [`src/ffx/shifted_season_controller.py:163`](/home/osgw/.local/src/codex/ffx/src/ffx/shifted_season_controller.py:163) applies no explicit ordering, overlapping rows would also make runtime shifting ambiguous.
-
-- Progress summary:
-  - Good progress:
-    - The subsystem exists across requirements, schema, UI, and conversion flow.
-    - It appears fully integrated into the show-editing workflow rather than parked as dead code.
-  - Incomplete progress:
-    - Validation logic is not trustworthy yet.
-    - Modern tests do not currently protect the subsystem's real behavior.
-    - User-facing error feedback in the shifted-season screens still has placeholder `#TODO: Meldung` branches.
-
-- Recommended next slice:
-  1. Add direct controller tests for overlap rejection, episode-order validation, and `shiftSeason(...)` selection behavior.
-  2. Fix `checkShiftedSeason(...)` and add the same range/order validation to `updateShiftedSeason(...)`.
-  3. Make sibling selection deterministic or enforce non-overlap strongly enough that ordering no longer matters in practice.
-  4. Add at least one focused integration test that proves a stored shifted season changes TMDB lookup and/or generated filename numbering during conversion.
-
-## Delete When
-
-- Delete this scratchpad once the optimization backlog is either converted into issues/work items or distilled into durable project guidance.

assets/ffx.json.j2

@@ -1,36 +0,0 @@
-{
-  "databasePath": {{ database_path_json }},
-  "logDirectory": {{ log_directory_json }},
-  "subtitlesDirectory": {{ subtitles_directory_json }},
-  "defaultIndexSeasonDigits": {{ default_index_season_digits }},
-  "defaultIndexEpisodeDigits": {{ default_index_episode_digits }},
-  "defaultIndicatorSeasonDigits": {{ default_indicator_season_digits }},
-  "defaultIndicatorEpisodeDigits": {{ default_indicator_episode_digits }},
-  "metadata": {
-    "signature": {
-      "RECODED_WITH": "FFX"
-    },
-    "remove": [
-      "VERSION-eng",
-      "creation_time",
-      "NAME"
-    ],
-    "streams": {
-      "remove": [
-        "BPS",
-        "NUMBER_OF_FRAMES",
-        "NUMBER_OF_BYTES",
-        "_STATISTICS_WRITING_APP",
-        "_STATISTICS_WRITING_DATE_UTC",
-        "_STATISTICS_TAGS",
-        "BPS-eng",
-        "DURATION-eng",
-        "NUMBER_OF_FRAMES-eng",
-        "NUMBER_OF_BYTES-eng",
-        "_STATISTICS_WRITING_APP-eng",
-        "_STATISTICS_WRITING_DATE_UTC-eng",
-        "_STATISTICS_TAGS-eng"
-      ]
-    }
-  }
-}

guidance/workflow/optional/lean-interface-iteration.md

@@ -1,28 +0,0 @@
-# Lean Interface Iteration
-
-Rule set name: `lean-interface-iteration`
-
-Rule set ID: `LII`
-
-Status: optional, prompt-activated only
-
-Trigger examples:
-
-- `Apply the lean-interface-iteration rules.`
-- `Apply LII rules.`
-
-LII-0001: Apply this rule set only when it is explicitly requested in the prompt.
-
-LII-0002: The target of work under this rule set is the iterated product state for the addressed iteration only.
-
-LII-0003: Optimize the addressed interface toward the leanest and least complex model that still satisfies the iteration order.
-
-LII-0004: Backward compatibility, legacy aliases, and compatibility shims are not required unless the prompt explicitly asks to preserve them.
-
-LII-0005: Prefer one authoritative interface over multiple overlapping parameters, flags, or naming variants.
-
-LII-0006: Remove or avoid transitional interface layers when they are not required by the addressed iteration order.
-
-LII-0007: Update affected tests, guidance, requirements, and documentation so they describe the simplified interface model rather than a mixed legacy-and-new model.
-
-LII-0008: Never change behavior, interfaces, or surrounding areas that are not addressed by the current iteration order.

guidance/workflow/optional/preparation-script-design.md

@@ -1,56 +0,0 @@
-# Preparation Script Design
-
-Rule set name: `preparation-script-design`
-
-Rule set ID: `PSD`
-
-Status: optional, prompt-activated only
-
-Trigger examples:
-
-- `Apply the preparation-script-design rules.`
-- `Apply PSD rules.`
-
-PSD-0001: Apply this rule set only when it is explicitly requested in the prompt.
-
-PSD-0002: Use this rule set for scripts whose purpose is to prepare, verify, or expose a local development or automation environment rather than to perform product runtime behavior.
-
-PSD-0003: Keep a preparation script focused on environment readiness, dependency installation, local helper exposure, and clear verification output; do not mix unrelated product logic into the script.
-
-PSD-0004: Design the script to be idempotent so repeated runs converge on the same prepared state without unnecessary reinstallation or destructive side effects.
-
-PSD-0005: Provide a verification-only mode such as `--check` that reports readiness without installing, modifying, or creating dependencies.
-
-PSD-0006: Separate component checks from installation steps so the script can report what is missing before or after attempted remediation.
-
-PSD-0007: Group required capabilities into clear purpose-oriented sections such as support toolchains, local package bundles, generated environment helpers, or other relevant readiness areas instead of presenting one undifferentiated dependency list.
-
-PSD-0008: Prefer explicit per-component check helpers over opaque one-shot checks so failures remain traceable and easy to extend.
-
-PSD-0009: Generate or update environment helper files only when they provide a stable, reusable way to expose repo-local or workspace-local tools, paths, or environment variables.
-
-PSD-0010: Generated environment helper files shall be safe to source multiple times and should avoid duplicating path entries or clobbering unrelated user environment state.
-
-PSD-0011: When a preparation flow seeds optional user-owned files such as config templates, do so non-destructively by creating them only when absent unless the prompt explicitly requests overwrite behavior.
-
-PSD-0012: Report status in a concise scan-friendly line format of the shape `[status] Label: detail`, where the label names the checked component and the detail string stays short and specific.
-
-PSD-0013: Prefer a small canonical status vocabulary in those report lines, with `ok` for satisfied checks, `warn` for non-blocking gaps, and a failure status such as `failed` for blocking or unsuccessful states.
-
-PSD-0014: When a preparation script uses terminal colors in its status output, apply a consistent severity mapping so `ok` is green, `warn` is yellow, and all other status levels are red.
-
-PSD-0015: In bracketed status markers such as `[ok]` or `[warn]`, keep the square brackets uncolored and apply the severity color only to the inner status text.
-
-PSD-0016: Colorized status output shall degrade safely in non-terminal or non-color contexts so the script remains readable and automation-friendly without ANSI support.
-
-PSD-0017: End with an explicit readiness conclusion that distinguishes between successful preparation, incomplete prerequisites, and failed installation attempts.
-
-PSD-0018: Installation logic should use the narrowest supported platform-specific package-manager actions necessary for the declared scope and should fail clearly when no supported installation path is available.
-
-PSD-0019: Treat repo-local helper tooling and local package installation boundaries explicitly rather than assuming global installs, especially when the prepared environment is intended to be reproducible.
-
-PSD-0020: Keep the script suitable for both interactive local developer use and non-interactive automation checks by avoiding prompts during normal execution unless the prompt explicitly requires interactivity.
-
-PSD-0021: When a script depends on generated helper files or adjacent validation helpers, update those supporting files only as needed to keep the preparation flow coherent and usable.
-
-PSD-0022: Verify shell syntax after changes and, when feasible, run a dry readiness check so the resulting preparation flow is validated rather than only written.

pyproject.toml

@@ -1,7 +1,7 @@
 [project]
 name = "ffx"
 description = "FFX recoding and metadata managing tool"
-version = "0.2.4"
+version = "0.2.3"
 license = {file = "LICENSE.md"}
 dependencies = [
   "requests",
@@ -27,11 +27,6 @@ Homepage = "https://gitea.maveno.de/Javanaut/ffx"
 Repository = "https://gitea.maveno.de/Javanaut/ffx.git"
 Issues = "https://gitea.maveno.de/Javanaut/ffx/issues"
 
-[project.optional-dependencies]
-test = [
-  "pytest",
-]
-
 [build-system]
 requires = [
     "setuptools",
@@ -40,15 +35,4 @@ requires = [
 build-backend = "setuptools.build_meta"
 
 [project.scripts]
-ffx = "ffx.cli:ffx"
+ffx = "ffx.ffx:ffx"
-
-[tool.pytest.ini_options]
-testpaths = ["tests"]
-python_files = ["test_*.py"]
-norecursedirs = ["tests/legacy", "tests/support"]
-addopts = "-ra"
-markers = [
-  "integration: exercises the FFX bundle with real ffmpeg/ffprobe processes",
-  "pattern_management: covers requirements/pattern_management.md",
-  "subtrack_mapping: covers requirements/subtrack_mapping.md",
-]

requirements/architecture.md

@@ -1,98 +0,0 @@
-# Architecture
-
-## Architecture Goals
-
-- Keep the tool small, local, and easy to reason about.
-- Separate media inspection, stored normalization rules, and conversion execution clearly enough that users can inspect and adjust behavior.
-- Favor explicit local state and deterministic rule application over opaque automation.
-- Make external runtime dependencies and platform assumptions visible.
-
-## System Context
-
-- Primary actors:
-  - Local operator running the CLI.
-  - Local operator using the Textual TUI to inspect files and maintain rules.
-- External systems:
-  - `ffprobe` for media introspection.
-  - `ffmpeg` for conversion and extraction.
-  - TMDB API for optional show and episode metadata.
-  - Local filesystem for source media, generated outputs, subtitles, logs, config, and database files.
-- Data entering the system:
-  - Media container and stream metadata from source files.
-  - Regex patterns and per-show normalization rules entered in the TUI.
-  - Optional config values from `~/.local/etc/ffx.json`.
-  - Optional TMDB identifiers and CLI overrides.
-  - Optional external subtitle files.
-- Data leaving the system:
-  - Normalized output media files.
-  - Extracted stream files from unmux operations.
-  - SQLite rows representing shows, patterns, tracks, tags, shifted seasons, and properties.
-  - Local log output and console messages.
-
-## High-Level Building Blocks
-
-- Frontend, CLI, API, or worker:
-  - A Click-based CLI in [`src/ffx/cli.py`](/home/osgw/.local/src/codex/ffx/src/ffx/cli.py), exposed as the `ffx` command and via `python -m ffx`, including lightweight maintenance wrappers for bundle setup, workstation preparation, and upgrade tasks.
-  - A Textual terminal UI rooted in [`src/ffx/ffx_app.py`](/home/osgw/.local/src/codex/ffx/src/ffx/ffx_app.py) with screens for shows, patterns, file inspection, tracks, tags, and shifted seasons.
-- Core business logic:
-  - Descriptor objects model media files, shows, and tracks.
-  - Controllers encapsulate CRUD operations and workflow orchestration for shows, patterns, tags, tracks, season shifts, configuration, and conversion.
-  - `MediaDescriptorChangeSet` computes differences between a file and its stored target schema to drive metadata and disposition updates.
-  - File inspection caches combined `ffprobe` data and crop-detection results per source and sampling window within one process to avoid repeated subprocess work.
-- Storage:
-  - SQLite via SQLAlchemy ORM, with schema rooted in shows, patterns, tracks, media tags, track tags, shifted seasons, and generic properties.
-  - Ordered schema migrations are loaded dynamically from per-version-step modules under [`src/ffx/model/migration/`](/home/osgw/.local/src/codex/ffx/src/ffx/model/migration/).
-  - A configuration JSON file supplies optional path, metadata-filtering, and filename-template settings.
-- Integration adapters:
-  - Process execution wrapper for `ffmpeg`, `ffprobe`, `nice`, and `cpulimit`, with explicit disabled states for niceness and CPU limiting, support for both absolute `cpulimit` values and machine-wide percent input, and a combined `cpulimit -- nice -n ... <command>` execution shape when both limits are configured.
-  - HTTP adapter for TMDB via `requests`.
-
-## Data And Interface Notes
-
-- Key entities or records:
-  - `Show`: canonical TV show metadata plus digit-formatting rules, optional show-level notes, and an optional show-level encoding-quality fallback.
-  - `Pattern`: regex rule tying filenames to one show and one target media schema.
-  - `Track` and `TrackTag`: persisted target stream records, codec, dispositions, audio layout, and stream-level tags. Detailed source-to-target mapping rules live in `requirements/subtrack_mapping.md`.
-  - `MediaTag`: persisted container-level metadata for a pattern.
-  - `ShiftedSeason`: mapping from source numbering ranges to adjusted season and episode numbers, owned either by a show as fallback or by a pattern as override.
-  - `Property`: internal key-value storage currently used for database versioning.
-- External interfaces:
-  - CLI commands for conversion, inspection, extraction, and crop detection.
-  - TUI workflows for rule authoring and rule maintenance.
-  - Environment variable `TMDB_API_KEY` for TMDB access.
-  - Config keys `databasePath`, `logDirectory`, and `outputFilenameTemplate`, plus optional metadata-filter rules.
-- Validation rules:
-  - Only supported media-file extensions are accepted for conversion.
-  - Stored database version must either match the runtime-required version already or have a supported sequential migration path to it.
-  - A normalized descriptor may have at most one default and one forced stream per relevant track type.
-  - Shifted-season ranges are intended not to overlap within the same owner scope and season, and runtime resolution prefers pattern-owned matches over show-owned matches.
-  - TMDB lookups require a show ID and season and episode numbers.
-- Error-handling approach:
-  - User-facing operational failures are raised as `click.ClickException` or warnings.
-  - Ambiguous default and forced stream states trigger prompts unless `--no-prompt` is set, in which case the command fails fast.
-  - External-process failures and invalid media are surfaced through logs and command errors rather than retries, except for TMDB rate-limit retries.
-
-## Deployment And Operations
-
-- Runtime environment:
-  - Local Python environment with the package installed and `ffmpeg`, `ffprobe`, `nice`, and `cpulimit` available on `PATH`.
-- Deployment shape:
-  - Single-process command execution on demand; no daemon, queue, or network service of its own.
-- Secrets and configuration handling:
-  - TMDB secret is read from `TMDB_API_KEY`.
-  - User config is read from `~/.local/etc/ffx.json`.
-  - Database path may also be overridden per command via `--database-file`.
-- Logging and monitoring approach:
-  - File and console logging configured per invocation.
-  - Default log file path is `~/.local/var/log/ffx.log`.
-  - No dedicated monitoring integration is present.
-
-## Open Technical Questions
-
-- Question: Should Linux-specific assumptions such as `/dev/null`, `nice`, `cpulimit`, and `~/.local` remain part of the supported-platform contract?
-- Risk: Portability and operational behavior are underspecified for non-Linux environments.
-- Next decision needed: Either document Linux-like systems as the official support boundary or refactor the process and path handling for broader portability.
-
-- Question: Should placeholder TUI surfaces such as settings and help become part of the required product surface or stay explicitly out of scope?
-- Risk: The UI appears broader than the actually finished feature set.
-- Next decision needed: Either remove or complete placeholder screens and update requirements accordingly.

requirements/pattern_management.md

@@ -1,68 +0,0 @@
-# Pattern Management
-
-This file defines the behavioral contract for managing shows, patterns, and
-pattern-backed filename matching.
-
-Primary source: actual tool code in `src/ffx/`.
-Secondary source: operator intent captured in task discussion.
-
-## Scope
-
-- The show, pattern, and track hierarchy stored in SQLite.
-- The role of a pattern as a reusable normalization definition for related media files.
-- Filename-driven assignment of a scanned media file to one show through one matching pattern.
-- Duplicate-match handling when more than one pattern matches the same filename.
-
-## Terms
-
-- `show`: logical series identity such as one TV show entry in the database.
-- `pattern`: regex-backed normalization definition attached to one show.
-- `track`: one persisted target-track definition attached to one pattern.
-- `scanned media file`: one source file currently being inspected or converted.
-- `duplicate pattern match`: a filename state where more than one stored pattern matches the same scanned media file.
-- `pattern-backed target schema`: the combination of one pattern's stored media tags and stored track definitions.
-
-## Rules
-
-- `PATTERN_MANAGEMENT-0001`: The domain model shall treat a show as the parent entity for patterns that describe distinct release families or normalization schemas for that show. A show may temporarily exist without patterns during editing or initial TUI creation.
-- `PATTERN_MANAGEMENT-0002`: Each persisted pattern shall belong to exactly one show.
-- `PATTERN_MANAGEMENT-0003`: The domain model shall treat a pattern as the reusable normalization definition for a series of media files expected to share the same internal track layout and materially similar stream and container metadata.
-- `PATTERN_MANAGEMENT-0004`: Each persisted track definition shall belong to exactly one pattern.
-- `PATTERN_MANAGEMENT-0005`: A pattern may also carry pattern-level media tags. The pattern's media tags plus its track definitions together form the pattern-backed target schema.
-- `PATTERN_MANAGEMENT-0006`: A scanned media file shall resolve to at most one pattern and therefore at most one show.
-- `PATTERN_MANAGEMENT-0007`: If no pattern matches a filename, the file shall remain unmatched rather than being assigned implicitly.
-- `PATTERN_MANAGEMENT-0008`: If more than one pattern matches the same filename, the system shall raise a duplicate pattern match error instead of silently selecting one.
-- `PATTERN_MANAGEMENT-0009`: Duplicate-match detection shall apply regardless of whether the competing patterns belong to the same show or to different shows.
-- `PATTERN_MANAGEMENT-0010`: Exact duplicate pattern definitions for the same show should not create multiple persisted pattern rows.
-- `PATTERN_MANAGEMENT-0011`: A persisted pattern shall define one or more tracks. Creating or retaining a zero-track pattern in the database is invalid managed state and shall be prohibited.
-- `PATTERN_MANAGEMENT-0012`: A show may exist without patterns as an intermediate editing state, for example when a user creates the show first in the TUI and adds patterns later.
-- `PATTERN_MANAGEMENT-0013`: Operator-facing pattern management should expose the owning show, regex pattern, stored track set, and stored media-tag set so a user can reason about matching and normalization behavior.
-- `PATTERN_MANAGEMENT-0014`: Matching semantics shall be deterministic and documented. Implicit "last matching pattern wins" behavior is not acceptable released behavior.
-
-## Acceptance
-
-- A filename that matches exactly one pattern yields one matched pattern and one show identity.
-- A filename that matches no pattern yields no matched pattern and an unmatched state.
-- A filename that matches more than one pattern yields an explicit duplicate-match error.
-- A pattern-backed target schema can be reconstructed from one pattern's stored media tags and stored track definitions.
-- A show may be stored before any patterns are attached to it.
-- A pattern cannot be stored or retained as a valid managed pattern unless at least one track is defined for it.
-- Pattern-backed conversion never proceeds with two competing matching patterns for the same input filename.
-
-## Current Code Fit
-
-- `src/ffx/model/show.py` implements a one-to-many `Show -> Pattern` relationship.
-- `src/ffx/model/pattern.py` implements `Pattern.show_id`, a one-to-many `Pattern -> Track` relationship, a one-to-many `Pattern -> MediaTag` relationship, and a unique `(show_id, pattern)` constraint for freshly created databases.
-- `src/ffx/model/track.py` implements `Track.pattern_id`, so each persisted track belongs to one pattern.
-- `src/ffx/model/pattern.py` reconstructs a pattern-backed target schema through `Pattern.getMediaDescriptor(...)`, combining stored media tags and stored tracks.
-- `src/ffx/file_properties.py` assumes a scanned file resolves to at most one pattern, because it stores only one `self.__pattern` and derives one `show_id` from it.
-- `src/ffx/pattern_controller.py` prevents exact duplicate `(show_id, pattern)` definitions during create and update flows, and it refreshes cached compiled regexes when stored pattern expressions change.
-- `src/ffx/pattern_controller.py` now complies with duplicate-match safety. `matchFilename(...)` scans deterministically, returns exactly one match, returns `{}` for no match, and raises an explicit duplicate-pattern-match error when more than one pattern matches the same filename.
-- The current persistence layer already aligns with the intended empty-show workflow because a show can exist without patterns.
-- New pattern creation and schema replacement flows now require at least one track, and `TrackController.deleteTrack(...)` prevents deleting the last persisted track from a pattern.
-- Trackless legacy rows can still exist in preexisting databases, but matching now rejects them explicitly instead of letting them participate silently.
-
-## Risks
-
-- The intended "release family" meaning of a pattern is a domain assumption, not something the code verifies automatically across all files matching that pattern.
-- Preexisting databases created before the newer validation rules may still contain invalid rows, so upgrade and cleanup paths should continue to treat explicit validation failures as recoverable operator signals.

requirements/project.md

@@ -1,124 +0,0 @@
-## Purpose And Scope
-
-- Project name: FFX
-- User problem: TV episode files from mixed sources arrive with inconsistent codecs, stream metadata, subtitle layouts, season and episode numbering, and output filenames, which makes them awkward to archive and use in media-player applications.
-- Target users: Individual operators curating a local TV media library on a workstation, especially users willing to define normalization rules per show.
-- Success outcome: A user can inspect source files, define reusable show and pattern rules, and produce output files whose streams, metadata, and filenames follow a predictable schema for web playback and library import.
-- Out of scope:
-  - Multi-user or hosted service workflows.
-  - General movie-library management.
-  - Distributed transcoding or remote job orchestration.
-  - Broad media-server administration beyond file preparation.
-
-## Required Product
-
-- Deliverable type: Installable Python command-line application with a Textual terminal UI for inspection and rule editing.
-- Core capabilities:
-  - Maintain an SQLite-backed database of shows, filename-matching patterns, per-pattern stream layouts and metadata tags, and optional season-shift rules.
-  - Inspect existing media files through `ffprobe` and compare discovered stream metadata with stored normalization rules.
-  - Convert media files through `ffmpeg` into a normalized output layout, including video recoding, audio transcoding to Opus, metadata cleanup and rewrite, and controlled disposition flags.
-  - Build output filenames from detected or configured show, season, and episode information, optionally enriched from TMDB and a configurable Jinja-style filename template.
-  - Support auxiliary file operations such as subtitle import, unmuxing, crop detection, rename-only conversion runs, and direct in-place episode renaming.
-- Supported environments:
-  - Local execution on a Python-capable workstation.
-  - Best-supported on Linux-like systems because the implementation assumes `~/.local`, `/dev/null`, `nice`, and `cpulimit`.
-  - Requires `ffmpeg`, `ffprobe`, and `cpulimit` on `PATH`.
-- Operational owner: The local user running the tool and maintaining its config, database, and external tooling.
-
-## Suggested User Stories
-
-- As a library maintainer, I want to define show-specific matching rules once so that future source files can be normalized automatically.
-- As an operator, I want to inspect a file before conversion so that I can compare its actual streams and tags against the stored target schema.
-- As a user preparing web-playback files, I want to recode video and audio with a small set of predictable options so that results are compatible and consistently named.
-- As a user dealing with nonstandard releases, I want CLI overrides for language, title, stream order, default and forced tracks, and season and episode data so that one-off fixes do not require database edits first.
-- As a user importing anime or other shifted numbering schemes, I want season and episode offsets at the show level with optional pattern-specific overrides so that generated filenames align with TMDB and media-library expectations.
-
-## Functional Requirements
-
-- The system shall provide a CLI entrypoint named `ffx` with commands for `convert`, `inspect`, `shows`, `rename`, `unmux`, `cropdetect`, `setup`, `configure_workstation`, `upgrade`, `version`, and `help`.
-- The system shall support a two-step local installation and preparation flow:
-  - `tools/setup.sh` is the bootstrap entrypoint for the first step and shall own bundle virtualenv creation, package installation, shell alias exposure, and optional Python test-package installation.
-  - `tools/configure_workstation.sh` is the bootstrap entrypoint for the second step and shall own workstation dependency checks and installation plus local config and directory seeding.
-  - After the bundle is installed, `ffx setup` and `ffx configure_workstation` shall remain aligned wrapper entrypoints for those same two steps.
-- The CLI command `ffx setup` shall act as a wrapper for the first-step bundle-preparation flow in `tools/setup.sh`.
-- The CLI command `ffx configure_workstation` shall act as a wrapper for the second-step preparation flow in `tools/configure_workstation.sh`.
-- The system shall persist reusable normalization rules in SQLite for:
-  - shows and show formatting digits,
-  - optional show-level notes,
-  - optional show-level quality defaults,
-  - regex-based filename patterns,
-  - per-pattern media tags,
-  - per-pattern stream definitions,
-  - show-level and pattern-level shifted-season mappings,
-  - internal database version properties.
-- The system shall apply supported ordered database migrations automatically when opening an older local database file and shall fail fast when no supported path exists.
-- Before applying a required database migration, the system shall show the current version, target version, required sequential steps, and whether each corresponding migration module is present, then require user confirmation.
-- Before applying a confirmed file-backed database migration, the system shall create an in-place backup copy whose filename includes the covered version range.
-- Detailed show, pattern, and duplicate-match management rules live in `requirements/pattern_management.md`.
-- The system shall inspect source media using `ffprobe` and derive a structured description of container metadata and streams.
-- The system shall optionally open a Textual UI to browse shows, inspect files, and create, edit, or delete shows, patterns, stream definitions, tags, and shifted-season rules.
-- The system shall match filenames against stored regex patterns to decide whether an input file should inherit a target stream and metadata schema.
-- The system shall convert supported input files (`mkv`, `mp4`, `avi`, `flv`, `webm`) with `ffmpeg`, supporting at least:
-  - VP9, AV1, and H.264 video encoding,
-  - Opus audio encoding with bitrate selection based on channel layout,
-  - metadata and disposition rewriting,
-  - optional crop detection and crop application,
-  - optional deinterlacing and denoising,
-  - optional subtitle import from external files,
-  - rename-only move mode.
-- The system shall support optional TMDB lookups to resolve show names, years, and episode titles when a show ID, season, and episode are available.
-- The system shall generate output filenames from show metadata, season and episode indices, and episode names using the configured filename template.
-- The system shall allow CLI overrides for stream languages, stream titles, default and forced tracks, stream order, TMDB show and episode data, output directory, label prefix, and processing resource limits.
-- The system shall resolve encoding quality by precedence `CLI override -> pattern -> show -> encoder default` and shall report the chosen value and source.
-- The system shall resolve season shifting by precedence `pattern -> show -> identity default` and shall report the chosen mapping and source.
-- Processing resource limit rules:
-  - `--nice` shall accept niceness values from `-20` through `19`; omitting the option shall disable niceness adjustment.
-  - `--cpu` shall accept either a positive absolute `cpulimit` value such as `200`, or a percentage suffixed with `%` such as `25%` to represent a share of present CPUs; omitting the option or using `0` shall disable CPU limiting.
-  - When both limits are configured, the process wrapper shall execute the target command through `cpulimit` around a `nice -n ...` invocation so both limits apply to the launched media command.
-- The system shall support extracting streams into separate files via `unmux` and reporting suggested crop parameters via `cropdetect`.
-- The system shall support in-place episode renaming via `rename`, requiring a `--prefix`, accepting optional `--season` and `--suffix` overrides, preserving the source extension, and supporting dry-run output without moving files.
-- Crop detection shall use a configurable sampling window, defaulting to a 60-second seek and a 180-second analysis duration, and repeated crop-detection requests for the same source plus sampling window shall reuse cached results within one process.
-- The system shall handle invalid input and system failures gracefully by logging warnings or raising `click` errors for missing files, invalid media, missing TMDB credentials, incompatible database versions, and ambiguous track dispositions when prompting is disabled.
-
-## Quality Requirements
-
-- The system should stay understandable as a small local tool: controllers, descriptors, models, and screens should remain separate enough for contributors to trace a workflow end to end.
-- The system should produce predictable output for the same database rules, CLI overrides, and source files.
-- The system should preserve a lightweight operational footprint: local SQLite state, local log file, no mandatory background services.
-- The system should be testable through modern automatically discovered tests and through remaining legacy harness coverage during migration.
-- The system should expose enough logging to diagnose failed probes, failed conversions, and rule mismatches without requiring a debugger.
-
-## Constraints And Assumptions
-
-- Technology constraints:
-  - Python package built with setuptools.
-  - Primary libraries: `click`, `textual`, `sqlalchemy`, `jinja2`, `requests`.
-  - Conversion and inspection rely on external executables rather than pure-Python media libraries.
-- Hosting or infrastructure constraints:
-  - Intended for local execution, not server deployment.
-  - Stores default state in `~/.local/etc/ffx.json`, `~/.local/var/ffx/ffx.db`, and `~/.local/var/log/ffx.log`.
-- Timeline constraints:
-  - The current implemented scope reflects a compact alpha release stream up to version `0.2.4`.
-- Team capacity assumptions:
-  - Maintained as a small codebase where simple patterns and direct controller logic are preferred over framework-heavy abstractions.
-- Third-party dependencies:
-  - `ffmpeg`, `ffprobe`, and `cpulimit`.
-  - TMDB API access through `TMDB_API_KEY` for metadata enrichment.
-- Installation assumptions:
-  - The Python-side bundle install step and optional Python test extras are managed by `tools/setup.sh`, with `ffx setup` as the aligned wrapper after bootstrap.
-  - The workstation-preparation step is managed separately by `tools/configure_workstation.sh` or `ffx configure_workstation`.
-
-## Acceptance Scope
-
-- First release boundary:
-  - Local installation through `pip`.
-  - Working SQLite-backed rule storage.
-  - Functional CLI conversion and inspection workflows.
-  - Textual CRUD flows for shows, patterns, tags, tracks, and shifted seasons.
-  - TMDB-assisted filename generation, subtitle import, season shifting, database versioning, and configurable output filename templating.
-- Excluded follow-up ideas:
-  - Completing placeholder screens such as settings and help.
-  - Hardening platform portability beyond Linux-like systems.
-  - Broader media types, richer release packaging, and production-grade background processing.
-- Demonstration scenario:
-  - Inspect a TV episode file, define or update the matching show and pattern in the TUI, then run `ffx convert` so the result uses the stored stream schema, optional TMDB episode naming, and a normalized output filename.

requirements/shifted_seasons_handling.md

@@ -1,177 +0,0 @@
-# Shifted Seasons Handling
-
-This file defines the behavioral contract for mapping source season and episode
-numbering to target season and episode numbering through stored shifted-season
-rules.
-
-Primary sources:
-- `requirements/project.md`
-- `requirements/architecture.md`
-- actual tool code in `src/ffx/`
-
-Secondary source:
-- `SCRATCHPAD.md`, used only to clarify current hardening gaps and not as the
-  primary contract source.
-
-## Scope
-
-- Persisting shifted-season rules in SQLite.
-- Allowing shifted-season rules to be attached either to a show or to a
-  specific pattern.
-- Selecting at most one active shifted-season rule for one concrete source
-  season and episode tuple.
-- Applying additive season and episode offsets to produce target numbering.
-- Using shifted target numbering during `convert` for TMDB episode lookup and
-  generated season and episode filename tokens.
-- Managing show-level default mappings and pattern-level override mappings from
-  the Textual editing workflows.
-
-## Out Of Scope
-
-- General filename parsing rules for detecting season and episode values.
-- Standalone `rename` command behavior, which currently uses explicit rename
-  inputs rather than stored shifted-season rules.
-- Stream or track mapping behavior unrelated to season and episode numbering.
-
-## Terms
-
-- `shifted-season rule`: one persisted row describing how one source-numbering
-  range maps to target numbering through additive offsets.
-- `show-level shifted-season rule`: a rule attached directly to a show and used
-  as the fallback mapping layer for that show.
-- `pattern-level shifted-season rule`: a rule attached directly to a pattern and
-  used as the override mapping layer for that pattern.
-- `source numbering`: the season and episode values detected from the current
-  source file or supplied as source-side conversion inputs before shifting.
-- `target numbering`: the season and episode values after one active
-  shifted-season rule has been applied.
-- `original season`: the source-domain season number a shifted-season rule is
-  eligible to match.
-- `episode range`: the optional source-domain episode interval covered by one
-  shifted-season rule.
-- `open bound`: an unbounded start or end of the episode range. Current storage
-  uses `-1` as the internal sentinel for an open bound.
-- `active shifted-season rule`: the single rule selected for one concrete input
-  after precedence resolution.
-- `identity mapping`: the default `1:1` outcome where source numbering is used
-  unchanged.
-
-## Rules
-
-- `SHIFTED_SEASONS_HANDLING-0001`: The domain model shall allow a
-  shifted-season rule to be owned by exactly one of:
-  - one show
-  - one pattern
-- `SHIFTED_SEASONS_HANDLING-0002`: A single shifted-season rule shall not
-  belong to both a show and a pattern at the same time.
-- `SHIFTED_SEASONS_HANDLING-0003`: A shifted-season rule shall carry these
-  fields: `original_season`, `first_episode`, `last_episode`,
-  `season_offset`, and `episode_offset`.
-- `SHIFTED_SEASONS_HANDLING-0004`: `season_offset` and `episode_offset` shall
-  be additive signed integers applied to matched source numbering to produce
-  target numbering.
-- `SHIFTED_SEASONS_HANDLING-0005`: A shifted-season rule shall match a source
-  tuple only when:
-  - the source season equals `original_season`
-  - the source episode is greater than or equal to `first_episode` when the
-    lower bound is closed
-  - the source episode is less than or equal to `last_episode` when the upper
-    bound is closed
-- `SHIFTED_SEASONS_HANDLING-0006`: An open lower or upper episode bound shall
-  represent an unbounded side of the covered source episode range.
-- `SHIFTED_SEASONS_HANDLING-0007`: If one shifted-season rule matches, target
-  numbering shall be:
-  - `target season = source season + season_offset`
-  - `target episode = source episode + episode_offset`
-- `SHIFTED_SEASONS_HANDLING-0008`: If no shifted-season rule matches, source
-  numbering shall pass through unchanged.
-- `SHIFTED_SEASONS_HANDLING-0009`: Shifted-season handling shall operate in a
-  source-to-target numbering model. Stored rules map detected source numbering
-  to the target numbering used by conversion-facing metadata and output naming.
-- `SHIFTED_SEASONS_HANDLING-0010`: Pattern matching identifies the owning show
-  and optionally a more specific owning pattern. Resolution of the active
-  shifted-season rule shall use this precedence order:
-  - matching pattern-level rule
-  - matching show-level rule
-  - identity mapping
-- `SHIFTED_SEASONS_HANDLING-0011`: At most one shifted-season rule may be
-  active for one concrete source season and episode tuple. Shifted-season rules
-  shall never stack or compose.
-- `SHIFTED_SEASONS_HANDLING-0012`: Within one owner scope, shifted-season rules
-  shall not overlap in their effective episode coverage for the same
-  `original_season`.
-- `SHIFTED_SEASONS_HANDLING-0013`: If a shifted-season rule uses two closed
-  episode bounds, `last_episode` shall be greater than or equal to
-  `first_episode`.
-- `SHIFTED_SEASONS_HANDLING-0014`: Shifted-season rule evaluation shall be
-  deterministic. Released behavior shall not depend on arbitrary database row
-  order when invalid overlapping rules exist.
-- `SHIFTED_SEASONS_HANDLING-0015`: A pattern-level rule is permitted to map to
-  zero offsets. Such a rule is a valid explicit override that beats show-level
-  fallback and produces identity mapping for its covered source range.
-- `SHIFTED_SEASONS_HANDLING-0016`: During `convert`, when show, season, and
-  episode values are available and stored shifting is active, the shifted target
-  numbering shall drive:
-  - TMDB episode lookup
-  - season and episode filename tokens such as `S01E02`
-  - generated episode basenames that include season and episode numbering
-- `SHIFTED_SEASONS_HANDLING-0017`: When conversion is supplied explicit
-  target-domain season or episode values for TMDB naming, the system shall not
-  apply stored shifting on top of those already-targeted values.
-- `SHIFTED_SEASONS_HANDLING-0018`: Operator-facing editing shall expose
-  shifted-season rule management in both of these places:
-  - show editing for show-level default mappings
-  - pattern editing for pattern-level override mappings
-- `SHIFTED_SEASONS_HANDLING-0019`: User-facing shifted-season editing should
-  present open episode bounds as a natural empty-state input rather than forcing
-  operators to type the internal sentinel directly.
-
-## Acceptance
-
-- A show can exist with zero or more show-level shifted-season rules.
-- A pattern can exist with zero or more pattern-level shifted-season rules.
-- A shifted-season rule is stored against exactly one owner scope.
-- A source tuple matching a pattern-level rule yields target numbering from that
-  rule even when a matching show-level rule also exists.
-- A source tuple matching no pattern-level rule but matching a show-level rule
-  yields target numbering from the show-level rule.
-- A source tuple matching neither scope yields identity mapping.
-- A pattern-level zero-offset rule can explicitly override a nonzero show-level
-  rule for the same covered source range.
-- Two shifted-season rules for the same owner scope and original season cannot
-  both be valid if they cover overlapping episode ranges.
-- During `convert`, shifted numbering is what TMDB episode lookup and generated
-  season and episode tokens see when stored shifting is active.
-- The TUI can display and maintain shifted-season rules from both the show and
-  pattern editing flows.
-
-## Current Code Fit
-
-- `src/ffx/model/show.py` and `src/ffx/model/pattern.py` now both expose
-  shifted-season relationships, and `src/ffx/model/shifted_season.py` stores
-  each rule against exactly one owner scope through `show_id` or `pattern_id`.
-- `src/ffx/shifted_season_controller.py` now resolves mappings with
-  pattern-over-show precedence and applies at most one active rule for a source
-  tuple.
-- `src/ffx/show_details_screen.py`,
-  `src/ffx/shifted_season_details_screen.py`, and
-  `src/ffx/shifted_season_delete_screen.py` provide reusable shifted-season
-  editing dialogs, and `src/ffx/pattern_details_screen.py` now exposes the
-  pattern-level override flow.
-- `src/ffx/cli.py` now resolves shifted numbering during `convert` from:
-  pattern-level match, then show-level match, then identity mapping.
-- `src/ffx/database.py` now migrates version-2 databases to version 3 by
-  preserving existing show-level rows and extending the schema for pattern-level
-  ownership.
-
-## Risks
-
-- The current CLI groups `--show`, `--season`, and `--episode` under one
-  override bucket used for TMDB-related behavior. Source-domain versus
-  target-domain semantics of each override must stay documented clearly so
-  stored shifting is neither skipped nor double-applied unexpectedly.
-- Existing version-2 databases only contain show-owned shifted-season rows, so a
-  version-3 migration must preserve those rows as the show-level fallback layer.
-- Current modern automated test coverage for shifted-season behavior is light,
-  so precedence, migration, and convert-time numbering behavior need focused
-  tests.

requirements/subtrack_mapping.md

@@ -1,74 +0,0 @@
-# Subtrack Mapping
-
-This file defines the behavioral contract for mapping input subtracks to output
-subtracks during conversion.
-
-Primary source: actual tool code in `src/ffx/`.
-Secondary source: `tests/legacy/`, used only to clarify intent and reveal gaps.
-
-## Scope
-
-- Ensuring each target subtrack is created from the corresponding source-subtrack information, including stream-level metadata.
-- Mapping input streams to output streams during conversion.
-- Using persisted pattern-track definitions from the database as the target schema.
-- Allowing omission and reordering of retained tracks.
-- Keeping stream-level metadata attached to the correct source-derived logical track after remapping.
-- Normalizing target output into ordered track groups: video, audio, subtitle, then special types such as fonts or images.
-
-## Terms
-
-- `source_index`: identity of the originating input stream from ffprobe or an imported source descriptor.
-- `index`: final output-track order across all retained tracks.
-- `sub_index`: per-type position within the retained tracks of one type, for example audio stream `0` or subtitle stream `1`.
-- `target schema`: stored or constructed output-track definition that decides which tracks are kept, omitted, reordered, and rewritten.
-- `separate source file`: additional file bound to one target track slot whose media payload replaces the regular source payload for that slot.
-
-## Rules
-
-- `SUBTRACK_MAPPING-0001`: The system shall represent source-stream identity separately from output order. `source_index`, `index`, and `sub_index` are distinct concepts and shall not be collapsed into one field.
-- `SUBTRACK_MAPPING-0002`: The system shall derive `source_index` for probed tracks from the original ffprobe stream index and preserve that identity through conversion planning.
-- `SUBTRACK_MAPPING-0003`: Pattern-backed track definitions stored in the database shall persist both target output order and originating source-stream identity.
-- `SUBTRACK_MAPPING-0004`: When a filename matches a pattern, the pattern target schema shall be the source of truth for which source tracks are retained, which are omitted, and in what order retained tracks appear in the output.
-- `SUBTRACK_MAPPING-0005`: A target track may refer only to an existing source track of the same type. Conversion shall fail fast when a target track refers to a nonexistent source stream or a source stream of a different type.
-- `SUBTRACK_MAPPING-0006`: The ffmpeg mapping phase shall be generated from target output order while resolving each retained output track back to its originating source stream via `source_index`.
-- `SUBTRACK_MAPPING-0007`: Reordering and omission shall preserve logical track identity. Stream-level metadata, titles, languages, and disposition decisions shall stay attached to the correct source-derived logical track after mapping.
-- `SUBTRACK_MAPPING-0008`: The system shall support one-off CLI stream-order overrides without requiring prior database edits.
-- `SUBTRACK_MAPPING-0009`: Operator-facing inspection and editing surfaces shall expose enough source-versus-target information to let a user reason about subtrack mapping decisions.
-- `SUBTRACK_MAPPING-0010`: Test coverage for subtrack mapping shall assert source-derived identity, omission, and output order explicitly. Final track counts or final type sequences alone are insufficient proof of correct mapping.
-- `SUBTRACK_MAPPING-0011`: Retained target tracks shall appear in ordered groups: video track or tracks first, then audio tracks, then subtitle tracks, then special types such as fonts or images. Within each group, the target schema shall define the order.
-- `SUBTRACK_MAPPING-0012`: Track omission is valid when required by output compatibility, when needed to normalize source tracks into the required target group order and schema, or when explicitly requested by database rules or CLI options.
-- `SUBTRACK_MAPPING-0013`: If source tracks do not already comply with the required target group order, conversion shall reorder retained tracks to match the target ordering contract without losing source-track identity or stream-level metadata lineage.
-
-## Separate Additional Source Files
-
-- `SUBTRACK_MAPPING-0014`: A separate source file may substitute the media payload of one target subtrack without changing that target track's intended output position.
-- `SUBTRACK_MAPPING-0015`: When a separate source file is used, the target track shall remain bound to the corresponding logical source track for mapping, validation, and metadata lineage.
-- `SUBTRACK_MAPPING-0016`: Metadata for a substituted target track shall be merged from the regular source track and the separate source file when available.
-- `SUBTRACK_MAPPING-0017`: If the separate source file provides a metadata field that is also present on the regular source track, the separate source file value shall win in the target output.
-- `SUBTRACK_MAPPING-0018`: If a metadata field is absent from the separate source file, the system shall fall back to the corresponding metadata from the regular source track or target schema rewrite rules.
-
-## Acceptance
-
-- Given a source media descriptor and a pattern-backed target schema, the planned output tracks can be listed in final output order and each retained track can still be traced to one originating source stream.
-- Planned output order follows grouped target order: video, audio, subtitle, then special types.
-- Tracks not referenced by the target schema are omitted from output mapping.
-- Tracks may also be omitted when they are incompatible with the chosen output format or explicitly excluded by database or CLI rules.
-- Two retained target tracks never originate from the same source stream unless duplication is implemented explicitly as a separate feature.
-- If target-track metadata is rewritten after reordering, it is written onto the correct source-derived logical track rather than the track that merely occupies the same final output position.
-- Invalid target-to-source references fail deterministically before the conversion job is launched.
-- If a separate source file substitutes one target track, that track keeps its target slot and ordering while metadata is merged with separate-file values taking precedence when both sides provide the same field.
-- A test proving subtrack mapping must assert at least one of: exact `source_index` to output-order mapping, omission of named source tracks, or preservation of per-track metadata after reorder.
-
-## Test Notes
-
-- `tests/legacy/scenario.py` names pattern behavior as `Filter/Reorder Tracks`.
-- `tests/legacy/scenario_4.py` is the strongest end-to-end signal because it runs DB-backed conversion and reapplies source indices before assertion.
-- `tests/legacy/track_tag_combinator_2_0.py` and `tests/legacy/track_tag_combinator_3_4.py` sort result tracks by `source_index` before checking tags, which matches the intended identity model.
-- Legacy permutation combinators define permutations but their assertion functions are stubs.
-- Some legacy scenarios produce `AP` and `SP` selectors but do not execute them.
-
-## Risks
-
-- `src/ffx/media_descriptor.py` contains an explicit `rearrangeTrackDescriptors()` path whose current implementation appears defective and under-tested.
-- Separate-source-file metadata precedence is only partly expressed in current implementation paths and should be covered directly in the rewritten test suite.
-- Production code expresses the mapping contract more clearly than the legacy harness, so a rewrite should add direct logic-level tests for mapping and reorder planning.

requirements/tests.md

@@ -1,144 +0,0 @@
-# Test Rewrite
-
-This file captures the structure executed by `tests/legacy_runner.py` today and
-defines the target shape for a complete rewrite.
-
-Detailed product rules for source-to-target subtrack mapping live in
-`requirements/subtrack_mapping.md`. This file describes only how tests cover
-that area.
-
-## Interpreter Requirement
-
-- Agents shall run Python-side test commands with `~/.local/share/ffx.venv/bin/python`.
-- This applies to the legacy harness, `unittest`, `pytest`, helper scripts, and `python -m ffx ...` test invocations.
-- Agents shall not silently substitute `python`, `python3`, or another interpreter for Python-side test work.
-- If `~/.local/share/ffx.venv/bin/python` is missing or not executable, agents shall stop and report the missing venv instead of continuing with Python-side test execution.
-
-## Shell Environment Requirement
-
-- Agents shall source `~/.bashrc` from an interactive Bash shell before running TMDB-dependent test commands or TMDB-dependent `python -m ffx ...` test invocations.
-- Agents shall not source `~/.bashrc.d/interactive/77_tmdb.sh` directly for normal test work; `~/.bashrc` is the required entry point.
-- In automation this means agents shall use an interactive Bash invocation such as `bash -ic 'source ~/.bashrc && ...'`, because a non-interactive `bash -lc` returns from `~/.bashrc` before the interactive fragments are loaded.
-- If sourcing `~/.bashrc` still does not provide required shell environment such as `TMDB_API_KEY`, agents shall stop and report the missing environment instead of continuing with TMDB-dependent test execution.
-
-## Current Harness
-
-- Entrypoint: `~/.local/share/ffx.venv/bin/python tests/legacy_runner.py run`
-- Runner style: custom Click CLI, not `pytest` or `unittest`
-- Commands:
-  - `run`: discover scenario files, instantiate each scenario, run yielded jobs
-  - `dupe`: helper command that creates duplicate media fixtures; not part of the test run
-- Filters: `--scenario`, `--variant`, `--limit`
-- Shared context:
-  - builds one mutable dict for the whole run
-  - installs loggers and writes `ffx_test_report.log`
-  - creates `ConfigurationController` eagerly
-  - tracks only passed and failed counters
-- Discovery:
-  - scenario files: `tests/legacy/scenario_*.py`
-  - combinators: `glob + importlib + inspect` by filename convention
-  - ordering: implicit glob order, no explicit sorting
-- Skip behavior:
-  - Scenario 4 is skipped when `TMDB_API_KEY` is missing
-  - only `TMDB_API_KEY_NOT_PRESENT_EXCEPTION` is caught at scenario construction time
-
-## Current Scenarios
-
-- `1`: `tests/legacy/scenario_1.py`
-  - focus: basename generation without pattern lookup or TMDB
-  - inputs per job: `1`
-  - jobs: `140`
-  - expected failures: `0`
-  - execution: build one synthetic source file, run `~/.local/share/ffx.venv/bin/python -m ffx convert`, assert filename selectors only
-  - selectors executed: `B`, `L`, `I`
-  - selectors defined but not executed: `S`, `R`
-- `2`: `tests/legacy/scenario_2.py`
-  - focus: conversion matrix over media layouts, dispositions, tags, and permutations
-  - inputs per job: `1`
-  - jobs: `8193`
-  - expected failures: `3267`
-  - execution: build one synthetic source file, run `~/.local/share/ffx.venv/bin/python -m ffx convert`, probe result with `FileProperties`, assert track layout and selected audio and subtitle metadata
-  - selectors executed: `M`, `AD`, `AT`, `SD`, `ST`
-  - selectors defined but not executed: `MT`, `AP`, `SP`, `J`
-- `4`: `tests/legacy/scenario_4.py`
-  - focus: pattern-driven batch conversion with SQLite state and live TMDB naming
-  - inputs per job: `6`
-  - jobs: `768`
-  - expected failures: `336`
-  - execution: build six synthetic preset files, recreate temp SQLite DB, insert show and pattern, run one batch convert command via `~/.local/share/ffx.venv/bin/python`, query TMDB during assertions
-  - selectors executed: `M`, `AD`, `AT`, `SD`, `ST`
-  - selectors defined but not executed: `MT`, `AP`, `SP`, `J`
-  - notes:
-    - uses `MediaCombinator6` only
-    - issues live HTTP requests through `TmdbController` with no request cache
-
-## Current Combinator Families
-
-- scenario files discovered: `3`
-- basename combinators discovered: `2`
-- media combinators discovered: `8`
-- media tag combinators discovered: `3`
-- disposition combinator 2 variants: `4`
-- disposition combinator 3 variants: `5`
-- track tag combinator 2 variants: `4`
-- track tag combinator 3 variants: `5`
-- indicator variants: `7`
-- label variants: `2`
-- show variants: `3`
-- release variants: `3`
-- permutation 2 variants: `2`
-- permutation 3 variants: `3`
-
-## Current Totals
-
-- full run without TMDB: `8333`
-- full run with TMDB: `9101`
-- Scenario 4 generated source files: `4608`
-- Scenario 4 live TMDB episode queries: `4608`
-
-## Current Behavior Areas
-
-- output basename rules for label, season and episode indicator, show name, and release suffix combinations
-- track layout normalization across the eight media combinator shapes from `VA` through `VAASSS`
-- two-track and three-track disposition edge cases, including intentional failure cases
-- two-track and three-track track-tag preservation checks, including checks that sort results by source identity
-- container-level media tag handling
-- pattern-backed conversion against a temporary SQLite database
-- TMDB-assisted episode naming for batch conversion
-
-## Structural Findings
-
-- The suite is process-heavy: most jobs run `ffmpeg` to generate a fixture and then spawn the FFX CLI as a subprocess.
-- The suite is integration-first and has almost no isolated unit-level coverage for pure logic.
-- The base `Combinator` class is a placeholder and is not the real abstraction boundary used by the suite.
-- Many combinator methods are placeholders: there are `25` `pass` statements across the current test modules.
-- Several assertion families are never executed because scenario selector dispatch is incomplete.
-- Scenario comments mention a Scenario 3, but no `scenario_3.py` exists.
-- `tests/legacy/_basename_combinator_1.py` is effectively orphaned because discovery only matches `basename_combinator_*.py`.
-- `tests/legacy/disposition_combinator_2_3 .py` contains an embedded space in the filename and is still part of discovery.
-- Expected failures are validated only as subprocess return-code matches, not as specific error types or messages.
-- The current suite depends on `ffmpeg`, `ffprobe`, SQLite, the local Python environment, and for Scenario 4 a live TMDB API key plus network access.
-
-## Rewrite Target
-
-- Replace the custom Click harness with a standard test runner, preferably `pytest`.
-- Split the suite into explicit layers: unit, integration, and optional external-system tests.
-- Keep unit tests as the default path and make them runnable without `ffmpeg`, `ffprobe`, TMDB, or a user config directory.
-- Model discovery explicitly in code instead of relying on glob-plus-reflection naming conventions.
-- Convert the current Cartesian-product combinators into readable parametrized cases grouped by behavior area.
-- Preserve the current behavior areas, but represent them with targeted cases instead of thousands of opaque variant IDs.
-- Make every assertion family explicit and executable; there must be no selector that is produced but never consumed.
-- Replace live TMDB access with fixtures or mocks in normal runs; any live-contract test must be opt-in.
-- Replace ad hoc subprocess return-code checks with assertions on typed exceptions, stderr content, or structured outputs.
-- Provide small reusable media fixtures or fixture builders so only a narrow integration slice needs `ffmpeg`-generated media.
-- Make database tests self-contained and fast through temporary databases and direct controller-level assertions.
-- Make ordering, naming, and selection deterministic so a contributor can predict exactly what will run.
-- Expose a small smoke suite for quick local runs and CI, plus a separately marked slower integration suite.
-- Prefer domain-oriented test modules over combinator-family modules: basename, pattern matching, metadata rewrite, track ordering, TMDB naming, CLI smoke, and failure handling.
-
-## Rewrite Acceptance
-
-- A default local test run finishes quickly and without network access.
-- A contributor can identify which behavior a failing test covers without decoding variant strings like `VAASSS-A:D10-S:T001`.
-- All current intended failure behaviors remain covered, but each one is asserted directly and readably.
-- The rewritten suite can be adopted by CI without requiring live TMDB credentials.

src/ffx/__main__.py

@@ -1,9 +0,0 @@
-from .cli import ffx
-
-
-def main():
-    ffx()
-
-
-if __name__ == "__main__":
-    main()

src/ffx/configuration_controller.py

@@ -1,12 +1,5 @@
 import os, json
 
-from .constants import (
-    DEFAULT_SHOW_INDEX_EPISODE_DIGITS,
-    DEFAULT_SHOW_INDEX_SEASON_DIGITS,
-    DEFAULT_SHOW_INDICATOR_EPISODE_DIGITS,
-    DEFAULT_SHOW_INDICATOR_SEASON_DIGITS,
-)
-
 class ConfigurationController():
 
     CONFIG_FILENAME = 'ffx.json'
@@ -15,12 +8,7 @@ class ConfigurationController():
 
     DATABASE_PATH_CONFIG_KEY = 'databasePath'
     LOG_DIRECTORY_CONFIG_KEY = 'logDirectory'
-    SUBTITLES_DIRECTORY_CONFIG_KEY = 'subtitlesDirectory'
     OUTPUT_FILENAME_TEMPLATE_KEY = 'outputFilenameTemplate'
-    DEFAULT_INDEX_SEASON_DIGITS_CONFIG_KEY = 'defaultIndexSeasonDigits'
-    DEFAULT_INDEX_EPISODE_DIGITS_CONFIG_KEY = 'defaultIndexEpisodeDigits'
-    DEFAULT_INDICATOR_SEASON_DIGITS_CONFIG_KEY = 'defaultIndicatorSeasonDigits'
-    DEFAULT_INDICATOR_EPISODE_DIGITS_CONFIG_KEY = 'defaultIndicatorEpisodeDigits'
 
 
     def __init__(self):
@@ -61,48 +49,6 @@ class ConfigurationController():
     def getDatabaseFilePath(self):
         return self.__databaseFilePath
 
-    def getSubtitlesDirectoryPath(self):
-        subtitlesDirectory = self.__configurationData.get(
-            ConfigurationController.SUBTITLES_DIRECTORY_CONFIG_KEY,
-            '',
-        )
-        return os.path.expanduser(str(subtitlesDirectory)) if subtitlesDirectory else ''
-
-    @classmethod
-    def getConfiguredIntegerValue(cls, configurationData: dict, configKey: str, defaultValue: int) -> int:
-        configuredValue = configurationData.get(configKey, defaultValue)
-        try:
-            return int(configuredValue)
-        except (TypeError, ValueError):
-            return int(defaultValue)
-
-    def getDefaultIndexSeasonDigits(self):
-        return ConfigurationController.getConfiguredIntegerValue(
-            self.__configurationData,
-            ConfigurationController.DEFAULT_INDEX_SEASON_DIGITS_CONFIG_KEY,
-            DEFAULT_SHOW_INDEX_SEASON_DIGITS,
-        )
-
-    def getDefaultIndexEpisodeDigits(self):
-        return ConfigurationController.getConfiguredIntegerValue(
-            self.__configurationData,
-            ConfigurationController.DEFAULT_INDEX_EPISODE_DIGITS_CONFIG_KEY,
-            DEFAULT_SHOW_INDEX_EPISODE_DIGITS,
-        )
-
-    def getDefaultIndicatorSeasonDigits(self):
-        return ConfigurationController.getConfiguredIntegerValue(
-            self.__configurationData,
-            ConfigurationController.DEFAULT_INDICATOR_SEASON_DIGITS_CONFIG_KEY,
-            DEFAULT_SHOW_INDICATOR_SEASON_DIGITS,
-        )
-
-    def getDefaultIndicatorEpisodeDigits(self):
-        return ConfigurationController.getConfiguredIntegerValue(
-            self.__configurationData,
-            ConfigurationController.DEFAULT_INDICATOR_EPISODE_DIGITS_CONFIG_KEY,
-            DEFAULT_SHOW_INDICATOR_EPISODE_DIGITS,
-        )
 
     def getData(self):
         return self.__configurationData

src/ffx/constants.py

@@ -1,30 +1,15 @@
-VERSION='0.2.4'
+VERSION='0.2.3'
-DATABASE_VERSION = 3
+DATABASE_VERSION = 2
 
 DEFAULT_QUALITY = 32
 DEFAULT_AV1_PRESET = 5
 
-DEFAULT_VIDEO_ENCODER_LABEL = "vp9"
-DEFAULT_CONTAINER_FORMAT = "webm"
-DEFAULT_CONTAINER_EXTENSION = "webm"
-SUPPORTED_INPUT_FILE_EXTENSIONS = ("mkv", "mp4", "avi", "flv", "webm")
-FFMPEG_COMMAND_TOKENS = ("ffmpeg", "-y")
-FFMPEG_NULL_OUTPUT_TOKENS = ("-f", "null", "/dev/null")
-
 DEFAULT_STEREO_BANDWIDTH    = "112"
 DEFAULT_AC3_BANDWIDTH       = "256"
 DEFAULT_DTS_BANDWIDTH       = "320"
 DEFAULT_7_1_BANDWIDTH       = "384"
 
-DEFAULT_CROPDETECT_SEEK_SECONDS = 60
-DEFAULT_CROPDETECT_DURATION_SECONDS = 180
-
 DEFAULT_cut_start = 60
 DEFAULT_cut_length = 180
 
-DEFAULT_SHOW_INDEX_SEASON_DIGITS = 2
-DEFAULT_SHOW_INDEX_EPISODE_DIGITS = 2
-DEFAULT_SHOW_INDICATOR_SEASON_DIGITS = 2
-DEFAULT_SHOW_INDICATOR_EPISODE_DIGITS = 2
-
 DEFAULT_OUTPUT_FILENAME_TEMPLATE = '{{ ffx_show_name }} - {{ ffx_index }}{{ ffx_index_separator }}{{ ffx_episode_name }}{{ ffx_indicator_separator }}{{ ffx_indicator }}'

src/ffx/database.py

@@ -1,25 +1,20 @@
-import os, shutil, click
+import os, click
 
-from sqlalchemy import create_engine, inspect, text
+from sqlalchemy import create_engine
 from sqlalchemy.orm import sessionmaker
 
-# Import the full model package so SQLAlchemy registers every mapped class
-# before metadata creation and the first ORM query.
-import ffx.model
 from ffx.model.show import Base
 
 from ffx.model.property import Property
-from ffx.model.migration import (
-    DatabaseVersionException,
-    getMigrationPlan,
-    migrateDatabase,
-)
 
 from ffx.constants import DATABASE_VERSION
 
 
 DATABASE_VERSION_KEY = 'database_version'
-EXPECTED_TABLE_NAMES = set(Base.metadata.tables.keys())
+
+class DatabaseVersionException(Exception):
+    def __init__(self, errorMessage):
+        super().__init__(errorMessage)
 
 def databaseContext(databasePath: str = ''):
 
@@ -34,18 +29,12 @@ def databaseContext(databasePath: str = ''):
         if not os.path.exists(ffxVarDir):
             os.makedirs(ffxVarDir)
         databasePath = os.path.join(ffxVarDir, 'ffx.db')
-    else:
-        databasePath = os.path.expanduser(databasePath)
 
-    if databasePath != ':memory:':
-        databasePath = os.path.abspath(databasePath)
-
-    databaseContext['path'] = databasePath
     databaseContext['url'] = f"sqlite:///{databasePath}"
     databaseContext['engine'] = create_engine(databaseContext['url'])
     databaseContext['session'] = sessionmaker(bind=databaseContext['engine'])
 
-    bootstrapDatabaseIfNeeded(databaseContext)
+    Base.metadata.create_all(databaseContext['engine'])
 
     # isSyncronuous = False
     # while not isSyncronuous:
@@ -62,126 +51,14 @@ def databaseContext(databasePath: str = ''):
 
     return databaseContext
 
-
-def databaseNeedsBootstrap(databaseContext) -> bool:
-    inspector = inspect(databaseContext['engine'])
-    existingTableNames = set(inspector.get_table_names())
-    return not EXPECTED_TABLE_NAMES.issubset(existingTableNames)
-
-
-def bootstrapDatabaseIfNeeded(databaseContext):
-    if not databaseNeedsBootstrap(databaseContext):
-        return
-
-    Base.metadata.create_all(databaseContext['engine'])
-
-
 def ensureDatabaseVersion(databaseContext):
 
     currentDatabaseVersion = getDatabaseVersion(databaseContext)
-    if not currentDatabaseVersion:
+    if currentDatabaseVersion:
-        setDatabaseVersion(databaseContext, DATABASE_VERSION)
-        return
-
-    if currentDatabaseVersion > DATABASE_VERSION:
-        raise DatabaseVersionException(
-            f"Current database version ({currentDatabaseVersion}) does not match required ({DATABASE_VERSION})"
-        )
-
-    if currentDatabaseVersion < DATABASE_VERSION:
-        promptForDatabaseMigration(databaseContext, currentDatabaseVersion, DATABASE_VERSION)
-        migrateDatabase(databaseContext, currentDatabaseVersion, DATABASE_VERSION, setDatabaseVersion)
-        currentDatabaseVersion = getDatabaseVersion(databaseContext)
-
         if currentDatabaseVersion != DATABASE_VERSION:
-        raise DatabaseVersionException(
+            raise DatabaseVersionException(f"Current database version ({currentDatabaseVersion}) does not match required ({DATABASE_VERSION})")
-            f"Current database version ({currentDatabaseVersion}) does not match required ({DATABASE_VERSION})"
+    else:
-        )
+        setDatabaseVersion(databaseContext, DATABASE_VERSION)
-
-    ensureCurrentSchemaCompatibility(databaseContext)
-
-
-def ensureCurrentSchemaCompatibility(databaseContext):
-    engine = databaseContext['engine']
-    inspector = inspect(engine)
-    showColumns = {
-        column['name']
-        for column in inspector.get_columns('shows')
-    }
-
-    alterStatements = []
-    if 'quality' not in showColumns:
-        alterStatements.append("ALTER TABLE shows ADD COLUMN quality INTEGER DEFAULT 0")
-    if 'notes' not in showColumns:
-        alterStatements.append("ALTER TABLE shows ADD COLUMN notes TEXT DEFAULT ''")
-
-    if not alterStatements:
-        return
-
-    with engine.begin() as connection:
-        for alterStatement in alterStatements:
-            connection.execute(text(alterStatement))
-
-
-def promptForDatabaseMigration(databaseContext, currentDatabaseVersion: int, targetDatabaseVersion: int):
-    migrationPlan = getMigrationPlan(currentDatabaseVersion, targetDatabaseVersion)
-
-    click.echo("Database migration required.")
-    click.echo(f"Current version: {currentDatabaseVersion}")
-    click.echo(f"Target version: {targetDatabaseVersion}")
-    click.echo("Steps required:")
-
-    missingSteps = []
-    for migrationStep in migrationPlan:
-        moduleStatus = "present" if migrationStep.modulePresent else "missing"
-        click.echo(
-            f"  {migrationStep.versionFrom} -> {migrationStep.versionTo}: "
-            + f"{migrationStep.moduleName} [{moduleStatus}]"
-        )
-        if not migrationStep.modulePresent:
-            missingSteps.append(migrationStep)
-
-    if missingSteps:
-        firstMissingStep = missingSteps[0]
-        raise DatabaseVersionException(
-            f"No migration path from database version "
-            + f"{firstMissingStep.versionFrom} to {firstMissingStep.versionTo}"
-        )
-
-    if not click.confirm(
-        "Create a backup and continue with database migration?",
-        default=True,
-    ):
-        raise click.ClickException("Database migration aborted by user.")
-
-    backupPath = backupDatabaseBeforeMigration(
-        databaseContext,
-        currentDatabaseVersion,
-        targetDatabaseVersion,
-    )
-    click.echo(f"Database backup created: {backupPath}")
-
-
-def backupDatabaseBeforeMigration(databaseContext, currentDatabaseVersion: int, targetDatabaseVersion: int) -> str:
-    databasePath = databaseContext.get('path', '')
-    if not databasePath or databasePath == ':memory:':
-        raise click.ClickException("Database migration backup requires a file-backed SQLite database.")
-
-    if not os.path.isfile(databasePath):
-        raise click.ClickException(f"Database file not found for backup: {databasePath}")
-
-    backupPath = f"{databasePath}.v{currentDatabaseVersion}-to-v{targetDatabaseVersion}.bak"
-    backupIndex = 1
-    while os.path.exists(backupPath):
-        backupPath = (
-            f"{databasePath}.v{currentDatabaseVersion}-to-v{targetDatabaseVersion}.{backupIndex}.bak"
-        )
-        backupIndex += 1
-
-    databaseContext['engine'].dispose()
-    shutil.copy2(databasePath, backupPath)
-
-    return backupPath
 
 
 def getDatabaseVersion(databaseContext):
@@ -190,9 +67,9 @@ def getDatabaseVersion(databaseContext):
         
         Session = databaseContext['session']
         s = Session()
-        versionProperty = s.query(Property).filter(Property.key == DATABASE_VERSION_KEY).first()
+        q = s.query(Property).filter(Property.key == DATABASE_VERSION_KEY)
 
-        return int(versionProperty.value) if versionProperty is not None else 0
+        return int(q.first().value) if q.count() else 0
 
     except Exception as ex:
         raise click.ClickException(f"getDatabaseVersion(): {repr(ex)}")

src/ffx/ffx.py

@@ -1,250 +1,42 @@
 #! /usr/bin/python3
 
-from __future__ import annotations
+import os, click, time, logging, shutil, subprocess
 
-import os, sys, click, time, shutil, subprocess
+from ffx.configuration_controller import ConfigurationController
-from typing import TYPE_CHECKING
 
-# Allow direct execution via `python src/ffx/cli.py` by preferring the package
+from ffx.file_properties import FileProperties
-# root on sys.path.
-if __package__ in (None, ''):
-    script_dir = os.path.dirname(__file__)
-    package_root = os.path.dirname(os.path.dirname(__file__))
-    sys.path = [p for p in sys.path if os.path.abspath(p) != os.path.abspath(script_dir)]
-    sys.path.insert(0, package_root)
 
-from ffx.constants import (
+from ffx.ffx_app import FfxApp
-    DEFAULT_AC3_BANDWIDTH,
+from ffx.ffx_controller import FfxController
-    DEFAULT_CROPDETECT_DURATION_SECONDS,
+from ffx.tmdb_controller import TmdbController
-    DEFAULT_CROPDETECT_SEEK_SECONDS,
-    DEFAULT_cut_length,
-    DEFAULT_cut_start,
-    DEFAULT_CONTAINER_EXTENSION,
-    DEFAULT_CONTAINER_FORMAT,
-    DEFAULT_DTS_BANDWIDTH,
-    DEFAULT_STEREO_BANDWIDTH,
-    DEFAULT_VIDEO_ENCODER_LABEL,
-    FFMPEG_COMMAND_TOKENS,
-    SUPPORTED_INPUT_FILE_EXTENSIONS,
-    VERSION,
-)
 
-if TYPE_CHECKING:
+from ffx.database import databaseContext
-    from ffx.media_descriptor import MediaDescriptor
-    from ffx.track_descriptor import TrackDescriptor
 
-LIGHTWEIGHT_COMMANDS = {None, 'version', 'help', 'setup', 'configure_workstation', 'upgrade', 'rename'}
+from ffx.media_descriptor import MediaDescriptor
-CPU_OPTION_HELP = (
+from ffx.track_descriptor import TrackDescriptor
-    "Limit CPU for started processes. Use an absolute cpulimit value such as 200 "
+from ffx.show_descriptor import ShowDescriptor
-    + "(about 2 cores), or use a percentage such as 25% for a share of present cores. "
-    + "Omit to disable; 0 also disables."
-)
-SUBTITLE_DIRECTORY_OPTION_HELP = (
-    "Load subtitles from here. When omitted and --subtitle-prefix is set, "
-    + "FFX uses the configured subtitlesDirectory base path plus the prefix as a subdirectory."
-)
-SUBTITLE_PREFIX_OPTION_HELP = (
-    "Subtitle filename prefix. Requires --subtitle-directory, or a configured "
-    + "subtitlesDirectory base path that contains a matching <prefix>/ subdirectory."
-)
-UNMUX_OUTPUT_DIRECTORY_OPTION_HELP = (
-    "Write extracted streams here. When omitted together with --subtitles-only and "
-    + "--label, FFX uses the configured subtitlesDirectory base path plus the label."
-)
-CROPDETECT_SEEK_OPTION_HELP = (
-    "Start crop detection this many seconds into the input. "
-    + "Useful for skipping logos, intros, or black frames."
-)
-CROPDETECT_DURATION_OPTION_HELP = (
-    "Analyze this many seconds for crop detection. "
-    + "Shorter windows are faster; longer windows are usually steadier."
-)
-DEFAULT_CUT_OPTION_VALUE = f"{DEFAULT_cut_start},{DEFAULT_cut_length}"
-CUT_OPTION_HELP = (
-    "Cut output in seconds. "
-    + f"Use --cut for the default {DEFAULT_CUT_OPTION_VALUE}, "
-    + "--cut DURATION to cut from 0 for DURATION seconds, "
-    + "or --cut START,DURATION for an explicit start and duration. "
-    + "Omit to disable."
-)
 
+from ffx.track_type import TrackType
+from ffx.video_encoder import VideoEncoder
+from ffx.track_disposition import TrackDisposition
+from ffx.track_codec import TrackCodec
 
-def normalizeNicenessOption(ctx, param, value):
+from ffx.process import executeProcess
-    from ffx.process import normalizeNiceness
+from ffx.helper import filterFilename, substituteTmdbFilename
+from ffx.helper import getEpisodeFileBasename
 
-    try:
+from ffx.constants import DEFAULT_STEREO_BANDWIDTH, DEFAULT_AC3_BANDWIDTH, DEFAULT_DTS_BANDWIDTH, DEFAULT_7_1_BANDWIDTH
-        return normalizeNiceness(value)
-    except ValueError as ex:
-        raise click.BadParameter(str(ex)) from ex
 
+from ffx.filter.quality_filter import QualityFilter
+from ffx.filter.preset_filter import PresetFilter
 
-def normalizeCpuOption(ctx, param, value):
+from ffx.filter.crop_filter import CropFilter
-    from ffx.process import normalizeCpuPercent
+from ffx.filter.nlmeans_filter import NlmeansFilter
+from ffx.filter.deinterlace_filter import DeinterlaceFilter
 
-    try:
+from ffx.constants import VERSION
-        return normalizeCpuPercent(value)
-    except ValueError as ex:
-        raise click.BadParameter(str(ex)) from ex
-
-
-def parseCutOptionValue(value) -> tuple[int, int] | None:
-    if value is None:
-        return None
-
-    cutValue = str(value).strip()
-    if not cutValue:
-        raise ValueError(
-            "Cut value must be DURATION or START,DURATION, or use --cut without a value."
-        )
-
-    cutTokens = [token.strip() for token in cutValue.split(',')]
-
-    try:
-        if len(cutTokens) == 1:
-            cutStart = 0
-            cutLength = int(cutTokens[0])
-        elif len(cutTokens) == 2:
-            cutStart = int(cutTokens[0])
-            cutLength = int(cutTokens[1])
-        else:
-            raise ValueError
-    except ValueError as ex:
-        raise ValueError(
-            "Cut value must be DURATION or START,DURATION, or use --cut without a value."
-        ) from ex
-
-    if cutStart < 0:
-        raise ValueError("Cut start must be 0 or greater.")
-
-    if cutLength <= 0:
-        raise ValueError("Cut duration must be greater than 0.")
-
-    return cutStart, cutLength
-
-
-def normalizeCutOption(ctx, param, value):
-    try:
-        return parseCutOptionValue(value)
-    except ValueError as ex:
-        raise click.BadParameter(str(ex)) from ex
-
-
-def resolveSubtitleImportOptions(context, subtitleDirectory, subtitlePrefix):
-    resolvedSubtitlePrefix = str(subtitlePrefix).strip()
-    resolvedSubtitleDirectory = (
-        os.path.expanduser(str(subtitleDirectory).strip())
-        if subtitleDirectory
-        else ''
-    )
-
-    if not resolvedSubtitlePrefix:
-        return False, resolvedSubtitleDirectory, resolvedSubtitlePrefix
-
-    if resolvedSubtitleDirectory:
-        return True, resolvedSubtitleDirectory, resolvedSubtitlePrefix
-
-    configuredSubtitlesBaseDirectory = context['config'].getSubtitlesDirectoryPath()
-    if not configuredSubtitlesBaseDirectory:
-        raise click.ClickException(
-            "Subtitle prefix was set but no --subtitle-directory was provided and "
-            + "no subtitlesDirectory default is configured in ffx.json."
-        )
-
-    resolvedSubtitleDirectory = os.path.join(
-        configuredSubtitlesBaseDirectory,
-        resolvedSubtitlePrefix,
-    )
-
-    if not os.path.isdir(resolvedSubtitleDirectory):
-        raise click.ClickException(
-            "Subtitle prefix was set but the resolved subtitle directory does not exist: "
-            + resolvedSubtitleDirectory
-        )
-
-    return True, resolvedSubtitleDirectory, resolvedSubtitlePrefix
-
-
-def resolveUnmuxOutputDirectory(context, outputDirectory, subtitlesOnly, label):
-    resolvedOutputDirectory = (
-        os.path.expanduser(str(outputDirectory).strip())
-        if outputDirectory
-        else ''
-    )
-    resolvedLabel = str(label).strip()
-
-    if resolvedOutputDirectory or not subtitlesOnly or not resolvedLabel:
-        return resolvedOutputDirectory, False
-
-    configuredSubtitlesBaseDirectory = context['config'].getSubtitlesDirectoryPath()
-    if not configuredSubtitlesBaseDirectory:
-        raise click.ClickException(
-            "Subtitles-only unmux with --label requires --output-directory or a configured "
-            + "subtitlesDirectory default in ffx.json."
-        )
-
-    return os.path.join(configuredSubtitlesBaseDirectory, resolvedLabel), True
-
-
-def resolveIndicatorDigitLengths(context=None, showDescriptor=None):
-    from ffx.show_descriptor import ShowDescriptor
-
-    defaultDigitLengths = ShowDescriptor.getDefaultDigitLengths(context)
-    if showDescriptor is None:
-        return (
-            defaultDigitLengths[ShowDescriptor.INDICATOR_SEASON_DIGITS_KEY],
-            defaultDigitLengths[ShowDescriptor.INDICATOR_EPISODE_DIGITS_KEY],
-        )
-
-    return (
-        int(showDescriptor.getIndicatorSeasonDigits()),
-        int(showDescriptor.getIndicatorEpisodeDigits()),
-    )
-
-
-def buildRenameTargetFilename(
-    sourcePath,
-    prefix,
-    seasonOverride=None,
-    suffix='',
-    indicatorSeasonDigits=None,
-    indicatorEpisodeDigits=None,
-):
-    from ffx.file_properties import FileProperties
-    from ffx.show_descriptor import ShowDescriptor
-
-    sourceFilename = os.path.basename(sourcePath)
-    seasonEpisodeValues = FileProperties.extractSeasonEpisodeValues(sourceFilename)
-    if seasonEpisodeValues is None:
-        return None
-
-    sourceSeason, sourceEpisode = seasonEpisodeValues
-    resolvedSeason = int(seasonOverride) if seasonOverride is not None else (
-        int(sourceSeason) if sourceSeason is not None else 1
-    )
-    resolvedIndicatorSeasonDigits = (
-        int(indicatorSeasonDigits)
-        if indicatorSeasonDigits is not None
-        else ShowDescriptor.DEFAULT_INDICATOR_SEASON_DIGITS
-    )
-    resolvedIndicatorEpisodeDigits = (
-        int(indicatorEpisodeDigits)
-        if indicatorEpisodeDigits is not None
-        else ShowDescriptor.DEFAULT_INDICATOR_EPISODE_DIGITS
-    )
-
-    _sourceBasename, sourceExtension = os.path.splitext(sourceFilename)
-
-    targetFilenameTokens = [
-        str(prefix).strip(),
-        f"s{resolvedSeason:0{resolvedIndicatorSeasonDigits}d}e{int(sourceEpisode):0{resolvedIndicatorEpisodeDigits}d}",
-    ]
-
-    resolvedSuffix = str(suffix).strip()
-    if resolvedSuffix:
-        targetFilenameTokens.append(resolvedSuffix)
-
-    return f"{'_'.join(targetFilenameTokens)}{sourceExtension}"
 
+from ffx.shifted_season_controller import ShiftedSeasonController
 
 
 @click.group()
@@ -257,18 +49,11 @@ def ffx(ctx, database_file, verbose, dry_run):
 
     ctx.obj = {}
 
-    if ctx.resilient_parsing:
+    if ctx.invoked_subcommand in ('setup_dependencies', 'upgrade'):
-        return
-
-    if ctx.invoked_subcommand in LIGHTWEIGHT_COMMANDS:
         ctx.obj['dry_run'] = dry_run
         ctx.obj['verbosity'] = verbose
         return
 
-    from ffx.configuration_controller import ConfigurationController
-    from ffx.database import databaseContext
-    from ffx.logging_utils import configure_ffx_logger
-
     ctx.obj['config'] = ConfigurationController()
 
     ctx.obj['database'] = databaseContext(databasePath=database_file
@@ -285,11 +70,23 @@ def ffx(ctx, database_file, verbose, dry_run):
     fileLogVerbosity = max(40 - verbose * 10, 10)
     consoleLogVerbosity = max(20 - verbose * 10, 10)
 
-    ctx.obj['logger'] = configure_ffx_logger(
+    ctx.obj['logger'] = logging.getLogger('FFX')
-        ctx.obj['config'].getLogFilePath(),
+    ctx.obj['logger'].setLevel(logging.DEBUG)
-        fileLogVerbosity,
+
-        consoleLogVerbosity,
+    ffxFileHandler = logging.FileHandler(ctx.obj['config'].getLogFilePath())
-    )
+    ffxFileHandler.setLevel(fileLogVerbosity)
+    ffxConsoleHandler = logging.StreamHandler()
+    ffxConsoleHandler.setLevel(consoleLogVerbosity)
+
+    fileFormatter = logging.Formatter(
+        '%(asctime)s - %(name)s - %(levelname)s - %(message)s')
+    ffxFileHandler.setFormatter(fileFormatter)
+    consoleFormatter = logging.Formatter(
+        '%(message)s')
+    ffxConsoleHandler.setFormatter(consoleFormatter)
+
+    ctx.obj['logger'].addHandler(ffxConsoleHandler)
+    ctx.obj['logger'].addHandler(ffxFileHandler)
 
 
 # Define a subcommand
@@ -302,9 +99,7 @@ def version():
 @ffx.command()
 def help():
     click.echo(f"ffx {VERSION}\n")
-    click.echo("Maintenance commands: setup, configure_workstation, upgrade")
+    click.echo(f"Usage: ffx [input file] [output file] [vp9|av1] [q=[nn[,nn,...]]] [p=nn] [a=nnn[k]] [ac3=nnn[k]] [dts=nnn[k]] [crop]")
-    click.echo("Media commands: shows, inspect, convert, rename, unmux, cropdetect")
-    click.echo("Use 'ffx --help' or 'ffx <command> --help' for full command help.")
 
 
 def getRepoRootPath():
@@ -312,12 +107,8 @@ def getRepoRootPath():
     return os.path.dirname(os.path.dirname(os.path.dirname(currentFilePath)))
 
 
-def getConfigureWorkstationScriptPath():
+def getPrepareScriptPath():
-    return os.path.join(getRepoRootPath(), 'tools', 'configure_workstation.sh')
+    return os.path.join(getRepoRootPath(), 'tools', 'prepare.sh')
-
-
-def getSetupScriptPath():
-    return os.path.join(getRepoRootPath(), 'tools', 'setup.sh')
 
 
 def getBundleVenvDirectory():
@@ -332,29 +123,22 @@ def getBundleRepoPath():
     return getRepoRootPath()
 
 
-def getTrackedGitChanges(repoPath):
+@ffx.command(name='setup_dependencies')
-    completed = subprocess.run(
+@click.pass_context
-        ['git', 'status', '--porcelain', '--untracked-files=no'],
+@click.option('--check', is_flag=True, default=False, help='Only verify dependency readiness')
-        cwd=repoPath,
+@click.argument('prepare_args', nargs=-1, type=click.UNPROCESSED)
-        capture_output=True,
+def setup_dependencies(ctx, check, prepare_args):
-        text=True,
+    prepareScriptPath = getPrepareScriptPath()
-    )
 
-    if completed.returncode != 0:
+    if not os.path.isfile(prepareScriptPath):
-        commandLabel = 'git status --porcelain --untracked-files=no'
+        raise click.ClickException(f"Preparation script not found at {prepareScriptPath}")
-        errorOutput = completed.stderr.strip() or completed.stdout.strip()
-        raise click.ClickException(
-            f"Unable to inspect bundle repository state using '{commandLabel}': {errorOutput}"
-        )
 
-    return [line for line in completed.stdout.splitlines() if line.strip()]
+    commandSequence = ['bash', prepareScriptPath]
 
+    if check:
+        commandSequence.append('--check')
 
-def runScriptWrapper(ctx, scriptPath, missingDescription, commandArgs):
+    commandSequence += list(prepare_args)
-    if not os.path.isfile(scriptPath):
-        raise click.ClickException(f"{missingDescription} not found at {scriptPath}")
-
-    commandSequence = ['bash', scriptPath] + list(commandArgs)
 
     if ctx.obj.get('dry_run', False):
         click.echo(' '.join(commandSequence))
@@ -364,44 +148,6 @@ def runScriptWrapper(ctx, scriptPath, missingDescription, commandArgs):
     ctx.exit(completed.returncode)
 
 
-@ffx.command(name='setup')
-@click.pass_context
-@click.option('--check', is_flag=True, default=False, help='Only verify bundle-setup readiness')
-@click.option('--with-tests', is_flag=True, default=False, help='Also install or verify Python test packages in the bundle venv')
-@click.argument('setup_args', nargs=-1, type=click.UNPROCESSED)
-def setup(ctx, check, with_tests, setup_args):
-    """Prepare or repair the FFX bundle virtualenv and shell alias."""
-    commandArgs = []
-
-    if check:
-        commandArgs.append('--check')
-    if with_tests:
-        commandArgs.append('--with-tests')
-
-    commandArgs += list(setup_args)
-    runScriptWrapper(ctx, getSetupScriptPath(), "Bundle setup script", commandArgs)
-
-
-@ffx.command(name='configure_workstation')
-@click.pass_context
-@click.option('--check', is_flag=True, default=False, help='Only verify workstation-configuration readiness')
-@click.argument('configure_args', nargs=-1, type=click.UNPROCESSED)
-def configure_workstation(ctx, check, configure_args):
-    """Prepare workstation dependencies and local config after bundle install."""
-    commandArgs = []
-
-    if check:
-        commandArgs.append('--check')
-
-    commandArgs += list(configure_args)
-    runScriptWrapper(
-        ctx,
-        getConfigureWorkstationScriptPath(),
-        "Workstation configuration script",
-        commandArgs,
-    )
-
-
 @ffx.command(name='upgrade')
 @click.pass_context
 @click.option('--branch', type=str, default='', help='Checkout this branch before pulling')
@@ -416,35 +162,12 @@ def upgrade(ctx, branch):
         raise click.ClickException(f"Bundle pip not found at {bundlePipPath}")
 
     commandSequences = []
-    trackedChanges = getTrackedGitChanges(bundleRepoPath)
-
-    if trackedChanges:
-        click.echo("Tracked local changes detected in the bundle repository:")
-        for trackedChange in trackedChanges:
-            click.echo(f"  {trackedChange}")
-
-        shouldReset = click.confirm(
-            "Discard these tracked changes with 'git reset --hard HEAD' before upgrade?",
-            default=False,
-        )
-
-        if not shouldReset:
-            raise click.ClickException(
-                "Upgrade aborted because tracked local changes are present."
-            )
-
-        commandSequences.append(['git', 'reset', '--hard', 'HEAD'])
 
     if branch:
-        commandSequences += [
+        commandSequences.append(['git', 'checkout', branch])
-            ['git', 'fetch', 'origin', branch],
-            ['git', 'checkout', '-B', branch, 'FETCH_HEAD'],
-        ]
-    else:
-        commandSequences.append(['git', 'pull'])
 
     commandSequences += [
-        [bundlePipPath, 'install', '--upgrade', 'pip', 'setuptools', 'wheel'],
+        ['git', 'pull'],
         [bundlePipPath, 'install', '--editable', '.'],
     ]
 
@@ -463,7 +186,6 @@ def upgrade(ctx, branch):
 @click.pass_context
 @click.argument('filename', nargs=1)
 def inspect(ctx, filename):
-    from ffx.ffx_app import FfxApp
 
     ctx.obj['command'] = 'inspect'
     ctx.obj['arguments'] = {}
@@ -473,66 +195,10 @@ def inspect(ctx, filename):
     app.run()
 
 
-@ffx.command()
-@click.pass_context
-@click.argument('paths', nargs=-1)
-@click.option('--prefix', type=str, required=True, help='Required target filename prefix')
-@click.option('--season', type=int, default=None, help='Override target season index')
-@click.option('--suffix', type=str, default='', help='Optional target filename suffix')
-@click.option('--dry-run', is_flag=True, default=False, help='Only print planned renames')
-def rename(ctx, paths, prefix, season, suffix, dry_run):
-    """Rename matching episode files in place."""
-    from ffx.configuration_controller import ConfigurationController
-
-    resolvedPrefix = str(prefix).strip()
-    resolvedSuffix = str(suffix).strip()
-    effectiveDryRun = bool(ctx.obj.get('dry_run', False) or dry_run)
-    renameContext = {
-        'config': ctx.obj.get('config') or ConfigurationController(),
-    }
-    indicatorSeasonDigits, indicatorEpisodeDigits = resolveIndicatorDigitLengths(renameContext)
-
-    if not resolvedPrefix:
-        raise click.ClickException("Rename prefix must not be empty.")
-
-    processedCount = 0
-
-    for sourcePath in paths:
-        if not os.path.isfile(sourcePath):
-            continue
-
-        targetFilename = buildRenameTargetFilename(
-            sourcePath,
-            resolvedPrefix,
-            seasonOverride=season,
-            suffix=resolvedSuffix,
-            indicatorSeasonDigits=indicatorSeasonDigits,
-            indicatorEpisodeDigits=indicatorEpisodeDigits,
-        )
-        if targetFilename is None:
-            continue
-
-        sourceFilename = os.path.basename(sourcePath)
-        targetPath = os.path.join(os.path.dirname(sourcePath), targetFilename)
-        click.echo(f"{sourceFilename} -> {targetFilename}")
-        processedCount += 1
-
-        if effectiveDryRun or os.path.abspath(sourcePath) == os.path.abspath(targetPath):
-            continue
-
-        if os.path.exists(targetPath):
-            raise click.ClickException(f"Target file already exists: {targetPath}")
-
-        shutil.move(sourcePath, targetPath)
-
-    if processedCount == 0:
-        click.echo("No matching files found.")
-
-
 def getUnmuxSequence(trackDescriptor: TrackDescriptor, sourcePath, targetPrefix, targetDirectory = ''):
 
     # executable and input file
-    commandTokens = list(FFMPEG_COMMAND_TOKENS) + ['-i', sourcePath]
+    commandTokens = FfxController.COMMAND_TOKENS + ['-i', sourcePath]
 
     trackType = trackDescriptor.getType()
 
@@ -562,24 +228,10 @@ def getUnmuxSequence(trackDescriptor: TrackDescriptor, sourcePath, targetPrefix,
 
 @click.argument('paths', nargs=-1)
 @click.option('-l', '--label', type=str, default='', help='Label to be used as filename prefix')
-@click.option("-o", "--output-directory", type=str, default='', help=UNMUX_OUTPUT_DIRECTORY_OPTION_HELP)
+@click.option("-o", "--output-directory", type=str, default='')
 @click.option("-s", "--subtitles-only", is_flag=True, default=False)
-@click.option(
+@click.option('--nice', type=int, default=99, help='Niceness of started processes')
-    '--nice',
+@click.option('--cpu', type=int, default=0, help='Limit CPU for started processes to percent')
-    type=int,
-    default=None,
-    callback=normalizeNicenessOption,
-    show_default='disabled',
-    help='Adjust niceness of started processes (-20..19). Omit to disable; 99 also disables.',
-)
-@click.option(
-    '--cpu',
-    type=str,
-    default=None,
-    callback=normalizeCpuOption,
-    show_default='disabled',
-    help=CPU_OPTION_HELP,
-)
 def unmux(ctx,
             paths,
             label,
@@ -587,31 +239,14 @@ def unmux(ctx,
             subtitles_only,
             nice,
             cpu):
-    from ffx.file_properties import FileProperties
-    from ffx.process import executeProcess
-    from ffx.shifted_season_controller import ShiftedSeasonController
-    from ffx.track_disposition import TrackDisposition
-    from ffx.track_type import TrackType
 
     existingSourcePaths = [p for p in paths if os.path.isfile(p)]
     ctx.obj['logger'].debug(f"\nUnmuxing {len(existingSourcePaths)} files")
 
     ctx.obj['resource_limits'] = {}
     ctx.obj['resource_limits']['niceness'] = nice
-    ctx.obj['resource_limits']['cpu_limit'] = cpu
     ctx.obj['resource_limits']['cpu_percent'] = cpu
 
-    output_directory, create_output_directory = resolveUnmuxOutputDirectory(
-        ctx.obj,
-        output_directory,
-        subtitles_only,
-        label,
-    )
-    if create_output_directory and existingSourcePaths and not ctx.obj.get('dry_run', False):
-        os.makedirs(output_directory, exist_ok=True)
-
-    shiftedSeasonController = ShiftedSeasonController(ctx.obj)
-
     for sourcePath in existingSourcePaths:
 
         fp = FileProperties(ctx.obj, sourcePath)
@@ -619,29 +254,13 @@ def unmux(ctx,
  
         try:
             sourceMediaDescriptor = fp.getMediaDescriptor()
-            currentPattern = fp.getPattern()
-            currentShowDescriptor = (
-                currentPattern.getShowDescriptor(ctx.obj) if currentPattern is not None else None
-            )
-            indicatorSeasonDigits, indicatorEpisodeDigits = resolveIndicatorDigitLengths(
-                ctx.obj,
-                currentShowDescriptor,
-            )
 
-            season, episode = shiftedSeasonController.shiftSeason(
+            season = fp.getSeason()
-                fp.getShowId(),
+            episode = fp.getEpisode()
-                season=fp.getSeason(),
-                episode=fp.getEpisode(),
-                patternId=currentPattern.getId() if currentPattern is not None else None,
-            )
 
             #TODO: Recognition für alle Formate anpassen
             targetLabel = label if label else fp.getFileBasename()
-            targetIndicator = (
+            targetIndicator = f"_S{season}E{episode}" if label and season != -1 and episode != -1 else ''
-                f"_S{season:0{indicatorSeasonDigits}d}E{episode:0{indicatorEpisodeDigits}d}"
-                if label and season != -1 and episode != -1
-                else ''
-            )
             
             if label and not targetIndicator:
                 ctx.obj['logger'].warning(f"Skipping file {fp.getFilename()}: Label set but no indicator recognized")
@@ -684,55 +303,19 @@ def unmux(ctx,
 @click.pass_context
 
 @click.argument('paths', nargs=-1)
-@click.option(
+@click.option('--nice', type=int, default=99, help='Niceness of started processes')
-    '--nice',
+@click.option('--cpu', type=int, default=0, help='Limit CPU for started processes to percent')
-    type=int,
-    default=None,
-    callback=normalizeNicenessOption,
-    show_default='disabled',
-    help='Adjust niceness of started processes (-20..19). Omit to disable; 99 also disables.',
-)
-@click.option(
-    '--cpu',
-    type=str,
-    default=None,
-    callback=normalizeCpuOption,
-    show_default='disabled',
-    help=CPU_OPTION_HELP,
-)
-@click.option(
-    '--crop-seek',
-    type=click.IntRange(min=0),
-    default=DEFAULT_CROPDETECT_SEEK_SECONDS,
-    show_default=True,
-    help=CROPDETECT_SEEK_OPTION_HELP,
-)
-@click.option(
-    '--crop-duration',
-    type=click.IntRange(min=1),
-    default=DEFAULT_CROPDETECT_DURATION_SECONDS,
-    show_default=True,
-    help=CROPDETECT_DURATION_OPTION_HELP,
-)
 def cropdetect(ctx,
             paths,
             nice,
-            cpu,
+            cpu):
-            crop_seek,
-            crop_duration):
-    from ffx.file_properties import FileProperties
 
     existingSourcePaths = [p for p in paths if os.path.isfile(p)]
     ctx.obj['logger'].debug(f"\nUnmuxing {len(existingSourcePaths)} files")
 
     ctx.obj['resource_limits'] = {}
     ctx.obj['resource_limits']['niceness'] = nice
-    ctx.obj['resource_limits']['cpu_limit'] = cpu
     ctx.obj['resource_limits']['cpu_percent'] = cpu
-    ctx.obj['cropdetect'] = {
-        'seek_seconds': crop_seek,
-        'duration_seconds': crop_duration,
-    }
 
     for sourcePath in existingSourcePaths:
 
@@ -740,7 +323,7 @@ def cropdetect(ctx,
         try:
 
             fp = FileProperties(ctx.obj, sourcePath)
-            cropParams = fp.findCropArguments()
+            cropParams = fp.findCropParams()
 
             click.echo(cropParams)
 
@@ -752,7 +335,6 @@ def cropdetect(ctx,
 @click.pass_context
 
 def shows(ctx):
-    from ffx.ffx_app import FfxApp
 
     ctx.obj['command'] = 'shows'
 
@@ -761,8 +343,6 @@ def shows(ctx):
 
 
 def checkUniqueDispositions(context, mediaDescriptor: MediaDescriptor):
-    from ffx.track_disposition import TrackDisposition
-    from ffx.track_type import TrackType
     
     # Check for multiple default or forced dispositions if not set by user input or database requirements
     #
@@ -812,7 +392,7 @@ def checkUniqueDispositions(context, mediaDescriptor: MediaDescriptor):
 
 @click.option('-l', '--label', type=str, default='', help='Label to be used as filename prefix')
 
-@click.option('-v', '--video-encoder', type=str, default=DEFAULT_VIDEO_ENCODER_LABEL, help=f"Target video encoder (vp9, av1, h264 or copy)", show_default=True)
+@click.option('-v', '--video-encoder', type=str, default=FfxController.DEFAULT_VIDEO_ENCODER, help=f"Target video encoder (vp9, av1 or h264)", show_default=True)
 
 @click.option('-q', '--quality', type=str, default="", help=f"Quality settings to be used with VP9/H264 encoder")
 @click.option('-p', '--preset', type=str, default="", help=f"Quality preset to be used with AV1 encoder")
@@ -821,8 +401,8 @@ def checkUniqueDispositions(context, mediaDescriptor: MediaDescriptor):
 @click.option('--ac3', type=int, default=DEFAULT_AC3_BANDWIDTH, help=f"Bitrate in kbit/s to be used to encode 5.1 audio streams", show_default=True)
 @click.option('--dts', type=int, default=DEFAULT_DTS_BANDWIDTH, help=f"Bitrate in kbit/s to be used to encode 6.1 audio streams", show_default=True)
 
-@click.option('--subtitle-directory', type=str, default='', help=SUBTITLE_DIRECTORY_OPTION_HELP)
+@click.option('--subtitle-directory', type=str, default='', help='Load subtitles from here')
-@click.option('--subtitle-prefix', type=str, default='', help=SUBTITLE_PREFIX_OPTION_HELP)
+@click.option('--subtitle-prefix', type=str, default='', help='Subtitle filename prefix')
 
 @click.option('--language', type=str, multiple=True, help='Set stream language. Use format <stream index>:<3 letter iso code>')
 @click.option('--title', type=str, multiple=True, help='Set stream title. Use format <stream index>:<title>')
@@ -837,30 +417,7 @@ def checkUniqueDispositions(context, mediaDescriptor: MediaDescriptor):
 @click.option('--rearrange-streams', type=str, default="", help='Rearrange output streams order. Use format comma separated integers')
 
 @click.option("--crop", is_flag=False, flag_value="auto", default="none")
-@click.option(
+@click.option("--cut", is_flag=False, flag_value="default", default="none")
-    '--crop-seek',
-    type=click.IntRange(min=0),
-    default=DEFAULT_CROPDETECT_SEEK_SECONDS,
-    show_default=True,
-    help='When --crop auto is used, start crop detection this many seconds into the input.',
-)
-@click.option(
-    '--crop-duration',
-    type=click.IntRange(min=1),
-    default=DEFAULT_CROPDETECT_DURATION_SECONDS,
-    show_default=True,
-    help='When --crop auto is used, analyze this many seconds for crop detection.',
-)
-@click.option(
-    "--cut",
-    type=str,
-    metavar="DURATION|START,DURATION",
-    is_flag=False,
-    flag_value=DEFAULT_CUT_OPTION_VALUE,
-    default=None,
-    callback=normalizeCutOption,
-    help=CUT_OPTION_HELP,
-)
 
 @click.option("--output-directory", type=str, default='')
 
@@ -887,24 +444,10 @@ def checkUniqueDispositions(context, mediaDescriptor: MediaDescriptor):
 @click.option("--no-signature", is_flag=True, default=False)
 @click.option("--keep-mkvmerge-metadata", is_flag=True, default=False)
 
-@click.option(
+@click.option('--nice', type=int, default=99, help='Niceness of started processes')
-    '--nice',
+@click.option('--cpu', type=int, default=0, help='Limit CPU for started processes to percent')
-    type=int,
-    default=None,
-    callback=normalizeNicenessOption,
-    show_default='disabled',
-    help='Adjust niceness of started processes (-20..19). Omit to disable; 99 also disables.',
-)
-@click.option(
-    '--cpu',
-    type=str,
-    default=None,
-    callback=normalizeCpuOption,
-    show_default='disabled',
-    help=CPU_OPTION_HELP,
-)
 
-@click.option('--rename-only', is_flag=True, default=False, help='Only renaming and moving, no recoding')
+@click.option('--rename-only', is_flag=True, default=False, help='Only renaming, no recoding')
 
 def convert(ctx,
             paths,
@@ -932,8 +475,6 @@ def convert(ctx,
             rearrange_streams,
 
             crop,
-            crop_seek,
-            crop_duration,
             cut,
 
             output_directory,
@@ -968,21 +509,6 @@ def convert(ctx,
     Filename extensions will be changed appropriately.
     Suffices will we appended to filename in case of multiple created files
     or if the filename has not changed."""
-    from ffx.ffx_controller import FfxController
-    from ffx.file_properties import FileProperties
-    from ffx.filter.crop_filter import CropFilter
-    from ffx.filter.deinterlace_filter import DeinterlaceFilter
-    from ffx.filter.nlmeans_filter import NlmeansFilter
-    from ffx.filter.preset_filter import PresetFilter
-    from ffx.filter.quality_filter import QualityFilter
-    from ffx.helper import filterFilename, getEpisodeFileBasename, substituteTmdbFilename
-    from ffx.shifted_season_controller import ShiftedSeasonController
-    from ffx.show_controller import ShowController
-    from ffx.show_descriptor import ShowDescriptor
-    from ffx.tmdb_controller import TmdbController
-    from ffx.track_codec import TrackCodec
-    from ffx.track_disposition import TrackDisposition
-    from ffx.video_encoder import VideoEncoder
 
     startTime = time.perf_counter()
 
@@ -990,13 +516,9 @@ def convert(ctx,
     
     context['video_encoder'] = VideoEncoder.fromLabel(video_encoder)
 
-    # HINT: quick and dirty override for h264, todo improve
+    #HINT: quick and dirty override for h264, todo improve
-    if context['video_encoder'] in (VideoEncoder.H264, VideoEncoder.COPY):
+    targetFormat = '' if context['video_encoder'] == VideoEncoder.H264 else FfxController.DEFAULT_FILE_FORMAT
-        targetFormat = ''
+    targetExtension  = 'mkv' if context['video_encoder'] == VideoEncoder.H264 else FfxController.DEFAULT_FILE_EXTENSION
-        targetExtension = 'mkv'
-    else:
-        targetFormat = DEFAULT_CONTAINER_FORMAT
-        targetExtension = DEFAULT_CONTAINER_EXTENSION
 
     context['use_tmdb'] = not no_tmdb
     context['use_pattern'] = not no_pattern
@@ -1007,29 +529,16 @@ def convert(ctx,
 
     context['resource_limits'] = {}
     context['resource_limits']['niceness'] = nice
-    context['resource_limits']['cpu_limit'] = cpu
     context['resource_limits']['cpu_percent'] = cpu
-    context['cropdetect'] = {
-        'seek_seconds': crop_seek,
-        'duration_seconds': crop_duration,
-    }
 
 
-    (
+    context['import_subtitles'] = (subtitle_directory and subtitle_prefix)
-        context['import_subtitles'],
-        resolvedSubtitleDirectory,
-        resolvedSubtitlePrefix,
-    ) = resolveSubtitleImportOptions(
-        context,
-        subtitle_directory,
-        subtitle_prefix,
-    )
     if context['import_subtitles']:
-        context['subtitle_directory'] = resolvedSubtitleDirectory
+        context['subtitle_directory'] = subtitle_directory
-        context['subtitle_prefix'] = resolvedSubtitlePrefix
+        context['subtitle_prefix'] = subtitle_prefix
 
 
-    existingSourcePaths = [p for p in paths if os.path.isfile(p) and p.split('.')[-1] in SUPPORTED_INPUT_FILE_EXTENSIONS]
+    existingSourcePaths = [p for p in paths if os.path.isfile(p) and p.split('.')[-1] in FfxController.INPUT_FILE_EXTENSIONS]
 
 
     # CLI Overrides
@@ -1110,15 +619,13 @@ def convert(ctx,
 
     #->
     # Process cut parameters
-    context['perform_cut'] = (cut is not None)
+    context['perform_cut'] = (cut != 'none')
     if context['perform_cut']:
-        context['cut_start'], context['cut_length'] = cut
+        cutTokens = cut.split(',')
-        click.echo(
+        if cutTokens and len(cutTokens) == 2:
-            f"Cutting enabled: start {context['cut_start']} s, duration {context['cut_length']} s."
+            context['cut_start'] = int(cutTokens[0])
-        )
+            context['cut_length'] = int(cutTokens[1])
-        ctx.obj['logger'].debug(
+            ctx.obj['logger'].debug(f"Cut start={context['cut_start']} length={context['cut_length']}")
-            f"Cut start={context['cut_start']} length={context['cut_length']}"
-        )
 
 
     tc = TmdbController() if context['use_tmdb'] else None
@@ -1161,7 +668,6 @@ def convert(ctx,
     ctx.obj['logger'].info(f"\nRunning {len(existingSourcePaths) * len(chainYield)} jobs")
 
     jobIndex = 0
-    showController = ShowController(context)
  
     for sourcePath in existingSourcePaths:
  
@@ -1194,7 +700,7 @@ def convert(ctx,
 
         ssc = ShiftedSeasonController(context)
         
-        matchedShowId = mediaFileProperties.getShowId()
+        showId = mediaFileProperties.getShowId()
 
         #HINT: -1 if not set
         if 'tmdb' in cliOverrides.keys() and 'season' in cliOverrides['tmdb']:
@@ -1276,8 +782,7 @@ def convert(ctx,
                 targetMediaDescriptor.importSubtitles(context['subtitle_directory'],
                                                         context['subtitle_prefix'],
                                                         showSeason,
-                                                        showEpisode,
+                                                        showEpisode)
-                                                        preserve_dispositions=True)
 
             # ctx.obj['logger'].debug(f"tmd subindices: {[t.getIndex() for t in targetMediaDescriptor.getAllTrackDescriptors()]} {[t.getSubIndex() for t in targetMediaDescriptor.getAllTrackDescriptors()]}  {[t.getDispositionFlag(TrackDisposition.DEFAULT) for t in targetMediaDescriptor.getAllTrackDescriptors()]}")
             ctx.obj['logger'].debug(f"tmd subindices: {[t.getIndex() for t in targetMediaDescriptor.getTrackDescriptors()]} {[t.getSubIndex() for t in targetMediaDescriptor.getTrackDescriptors()]}  {[t.getDispositionFlag(TrackDisposition.DEFAULT) for t in targetMediaDescriptor.getTrackDescriptors()]}")
@@ -1292,59 +797,26 @@ def convert(ctx,
 
             fc = FfxController(context, targetMediaDescriptor, sourceMediaDescriptor)
 
-        qualityShowId = (
+
-            cliOverrides['tmdb']['show']
+        indexSeasonDigits = currentShowDescriptor.getIndexSeasonDigits() if not currentPattern is None else ShowDescriptor.DEFAULT_INDEX_SEASON_DIGITS
-            if 'tmdb' in cliOverrides.keys() and 'show' in cliOverrides['tmdb']
+        indexEpisodeDigits = currentShowDescriptor.getIndexEpisodeDigits() if not currentPattern is None else ShowDescriptor.DEFAULT_INDEX_EPISODE_DIGITS
-            else matchedShowId
+        indicatorSeasonDigits = currentShowDescriptor.getIndicatorSeasonDigits() if not currentPattern is None else ShowDescriptor.DEFAULT_INDICATOR_SEASON_DIGITS
-        )
+        indicatorEpisodeDigits = currentShowDescriptor.getIndicatorEpisodeDigits() if not currentPattern is None else ShowDescriptor.DEFAULT_INDICATOR_EPISODE_DIGITS
-        if currentShowDescriptor is None and qualityShowId != -1:
-            currentShowDescriptor = showController.getShowDescriptor(qualityShowId)
 
 
-        defaultDigitLengths = ShowDescriptor.getDefaultDigitLengths(context)
+        # Shift season and episode if defined for this show
-        indexSeasonDigits = currentShowDescriptor.getIndexSeasonDigits() if not currentPattern is None else defaultDigitLengths[ShowDescriptor.INDEX_SEASON_DIGITS_KEY]
+        if ('tmdb' not in cliOverrides.keys() and showId != -1
-        indexEpisodeDigits = currentShowDescriptor.getIndexEpisodeDigits() if not currentPattern is None else defaultDigitLengths[ShowDescriptor.INDEX_EPISODE_DIGITS_KEY]
+                    and showSeason != -1 and showEpisode != -1):
-        indicatorSeasonDigits = currentShowDescriptor.getIndicatorSeasonDigits() if not currentPattern is None else defaultDigitLengths[ShowDescriptor.INDICATOR_SEASON_DIGITS_KEY]
+            shiftedShowSeason, shiftedShowEpisode = ssc.shiftSeason(showId,
-        indicatorEpisodeDigits = currentShowDescriptor.getIndicatorEpisodeDigits() if not currentPattern is None else defaultDigitLengths[ShowDescriptor.INDICATOR_EPISODE_DIGITS_KEY]
-
-
-        showIdForShift = (
-            cliOverrides['tmdb']['show']
-            if 'tmdb' in cliOverrides.keys() and 'show' in cliOverrides['tmdb']
-            else matchedShowId
-        )
-        patternIdForShift = currentPattern.getId() if currentPattern is not None else None
-        hasExplicitTargetSeasonOrEpisode = (
-            'tmdb' in cliOverrides.keys()
-            and (
-                'season' in cliOverrides['tmdb']
-                or 'episode' in cliOverrides['tmdb']
-            )
-        )
-
-        # Shift season and episode if defined for the matched pattern or show
-        if (
-            not hasExplicitTargetSeasonOrEpisode
-            and showSeason != -1
-            and showEpisode != -1
-        ):
-            shiftedShowSeason, shiftedShowEpisode = ssc.shiftSeason(
-                showIdForShift,
                                                         season=showSeason,
-                episode=showEpisode,
+                                                        episode=showEpisode)
-                patternId=patternIdForShift,
-            )
         else:
             shiftedShowSeason = showSeason
             shiftedShowEpisode = showEpisode
 
         # Assemble target filename accordingly depending on TMDB lookup is enabled
         #HINT: -1 if not set
-        showId = (
+        showId = cliOverrides['tmdb']['show'] if 'tmdb' in cliOverrides.keys() and 'show' in cliOverrides['tmdb'] else (-1 if currentShowDescriptor is None else currentShowDescriptor.getId())
-            cliOverrides['tmdb']['show']
-            if 'tmdb' in cliOverrides.keys() and 'show' in cliOverrides['tmdb']
-            else (-1 if currentShowDescriptor is None else currentShowDescriptor.getId())
-        )
 
         if context['use_tmdb'] and showId != -1 and shiftedShowSeason != -1 and shiftedShowEpisode != -1:
 
@@ -1423,15 +895,14 @@ def convert(ctx,
 
 
             if rename_only:
-                shutil.move(sourcePath, targetPath)
+                shutil.copyfile(sourcePath, targetPath)
             else:
                 fc.runJob(sourcePath,
                             targetPath,
                             targetFormat,
                             chainIteration,
                             cropArguments,
-                            currentPattern,
+                            currentPattern)
-                            currentShowDescriptor)
 
 
 

src/ffx/ffx_controller.py

@@ -10,16 +10,7 @@ from ffx.track_codec import TrackCodec
 from ffx.video_encoder import VideoEncoder
 from ffx.process import executeProcess
 
-from ffx.constants import (
+from ffx.constants import DEFAULT_cut_start, DEFAULT_cut_length
-    DEFAULT_CONTAINER_EXTENSION,
-    DEFAULT_CONTAINER_FORMAT,
-    DEFAULT_VIDEO_ENCODER_LABEL,
-    DEFAULT_cut_start,
-    DEFAULT_cut_length,
-    FFMPEG_COMMAND_TOKENS,
-    FFMPEG_NULL_OUTPUT_TOKENS,
-    SUPPORTED_INPUT_FILE_EXTENSIONS,
-)
 
 from ffx.filter.quality_filter import QualityFilter
 from ffx.filter.preset_filter import PresetFilter
@@ -30,17 +21,17 @@ from ffx.model.pattern import Pattern
 
 class FfxController():
 
-    COMMAND_TOKENS = list(FFMPEG_COMMAND_TOKENS)
+    COMMAND_TOKENS = ['ffmpeg', '-y']
-    NULL_TOKENS = list(FFMPEG_NULL_OUTPUT_TOKENS) # -f null /dev/null
+    NULL_TOKENS = ['-f', 'null', '/dev/null'] # -f null /dev/null
 
     TEMP_FILE_NAME = "ffmpeg2pass-0.log"
 
-    DEFAULT_VIDEO_ENCODER = DEFAULT_VIDEO_ENCODER_LABEL
+    DEFAULT_VIDEO_ENCODER = VideoEncoder.VP9.label()
 
-    DEFAULT_FILE_FORMAT = DEFAULT_CONTAINER_FORMAT
+    DEFAULT_FILE_FORMAT = 'webm'
-    DEFAULT_FILE_EXTENSION = DEFAULT_CONTAINER_EXTENSION
+    DEFAULT_FILE_EXTENSION = 'webm'
 
-    INPUT_FILE_EXTENSIONS = list(SUPPORTED_INPUT_FILE_EXTENSIONS)
+    INPUT_FILE_EXTENSIONS = ['mkv', 'mp4', 'avi', 'flv', 'webm']
     
     CHANNEL_MAP_5_1 = 'FL-FL|FR-FR|FC-FC|LFE-LFE|SL-BL|SR-BR:5.1'
 
@@ -63,13 +54,6 @@ class FfxController():
         self.__logger: Logger = context['logger']
 
 
-    def executeCommandSequence(self, commandSequence):
-        out, err, rc = executeProcess(commandSequence, context=self.__context)
-        if rc:
-            raise click.ClickException(f"Command resulted in error: rc={rc} error={err}")
-        return out, err, rc
-
-
     def generateAV1Tokens(self, quality, preset, subIndex : int = 0):
 
         return [f"-c:v:{int(subIndex)}", 'libsvtav1',
@@ -116,37 +100,6 @@ class FfxController():
         return [f"-c:v:{int(subIndex)}",
                 'copy']
         
-    def generateAudioCopyTokens(self, subIndex):
-        return [f"-c:a:{int(subIndex)}", 'copy']
-
-    def generateSubtitleCopyTokens(self, subIndex):
-        return [f"-c:s:{int(subIndex)}", 'copy']
-
-    def generateAttachmentCopyTokens(self, subIndex):
-        return [f"-c:t:{int(subIndex)}", 'copy']
-
-    def generateCopyTokens(self):
-        copyTokens = []
-
-        for trackDescriptor in self.__targetMediaDescriptor.getTrackDescriptors(trackType=TrackType.VIDEO):
-            copyTokens += self.generateVideoCopyTokens(trackDescriptor.getSubIndex())
-
-        for trackDescriptor in self.__targetMediaDescriptor.getTrackDescriptors(trackType=TrackType.AUDIO):
-            copyTokens += self.generateAudioCopyTokens(trackDescriptor.getSubIndex())
-
-        for trackDescriptor in self.__targetMediaDescriptor.getTrackDescriptors(trackType=TrackType.SUBTITLE):
-            copyTokens += self.generateSubtitleCopyTokens(trackDescriptor.getSubIndex())
-
-        attachmentDescriptors = (
-            self.__sourceMediaDescriptor.getTrackDescriptors(trackType=TrackType.ATTACHMENT)
-            if self.__sourceMediaDescriptor is not None
-            else self.__targetMediaDescriptor.getTrackDescriptors(trackType=TrackType.ATTACHMENT)
-        )
-        for trackDescriptor in attachmentDescriptors:
-            copyTokens += self.generateAttachmentCopyTokens(trackDescriptor.getSubIndex())
-
-        return copyTokens
-        
 
     def generateCropTokens(self):
 
@@ -171,18 +124,6 @@ class FfxController():
             return [outputFilePath]
 
 
-    def generateEncodingMetadataTags(self, videoEncoder: VideoEncoder, quality, preset) -> dict:
-        metadataTags = {}
-
-        if videoEncoder in (VideoEncoder.AV1, VideoEncoder.H264, VideoEncoder.VP9):
-            metadataTags["ENCODING_QUALITY"] = str(quality)
-
-        if videoEncoder == VideoEncoder.AV1:
-            metadataTags["ENCODING_PRESET"] = str(preset)
-
-        return metadataTags
-
-
     def generateAudioEncodingTokens(self):
         """Generates ffmpeg options audio streams including channel remapping, codec and bitrate"""
 
@@ -245,8 +186,7 @@ class FfxController():
                 targetFormat: str = '',
                 chainIteration: list = [],
                 cropArguments: dict = {},
-                currentPattern: Pattern = None,
+                currentPattern: Pattern = None):
-                currentShowDescriptor = None):
                 # quality: int = DEFAULT_QUALITY,
                 # preset: int = DEFAULT_AV1_PRESET):
 
@@ -263,11 +203,9 @@ class FfxController():
 
 
         if qualityFilters and (quality := qualityFilters[0]['parameters']['quality']):
-            self.__logger.info(f"Setting quality {quality} from command line")
+            self.__logger.info(f"Setting quality {quality} from command line parameter")
-        elif currentPattern is not None and (quality := currentPattern.quality):
+        elif (quality := currentPattern.quality):
-            self.__logger.info(f"Setting quality {quality} from pattern")
+            self.__logger.info(f"Setting quality {quality} from pattern default")
-        elif currentShowDescriptor is not None and (quality := currentShowDescriptor.getQuality()):
-            self.__logger.info(f"Setting quality {quality} from show")
         else:
             quality = (QualityFilter.DEFAULT_H264_QUALITY
                         if (videoEncoder == VideoEncoder.H264)
@@ -276,11 +214,6 @@ class FfxController():
 
 
         preset = presetFilters[0]['parameters']['preset'] if presetFilters else PresetFilter.DEFAULT_PRESET
-        self.__context['encoding_metadata_tags'] = self.generateEncodingMetadataTags(
-            videoEncoder,
-            quality,
-            preset,
-        )
 
 
         filterParamTokens = []
@@ -305,28 +238,6 @@ class FfxController():
 
         commandTokens = FfxController.COMMAND_TOKENS + ['-i', sourcePath]
 
-        if videoEncoder == VideoEncoder.COPY:
-
-            commandSequence = (commandTokens
-                                + self.__targetMediaDescriptor.getImportFileTokens()
-                                + self.__targetMediaDescriptor.getInputMappingTokens(sourceMediaDescriptor = self.__sourceMediaDescriptor)
-                                + self.__mdcs.generateDispositionTokens())
-
-            commandSequence += self.__mdcs.generateMetadataTokens()
-            commandSequence += self.generateCopyTokens()
-
-            if self.__context['perform_cut']:
-                commandSequence += self.generateCropTokens()
-
-            commandSequence += self.generateOutputTokens(targetPath,
-                                                        targetFormat)
-
-            self.__logger.debug("FfxController.runJob(): Running command sequence")
-
-            if not self.__context['dry_run']:
-                self.executeCommandSequence(commandSequence)
-            return
-
         if videoEncoder == VideoEncoder.AV1:
 
             commandSequence = (commandTokens
@@ -354,7 +265,7 @@ class FfxController():
             self.__logger.debug(f"FfxController.runJob(): Running command sequence")
 
             if not self.__context['dry_run']:
-                self.executeCommandSequence(commandSequence)
+                executeProcess(commandSequence, context = self.__context)
 
 
         if videoEncoder == VideoEncoder.H264:
@@ -384,7 +295,7 @@ class FfxController():
             self.__logger.debug(f"FfxController.runJob(): Running command sequence")
 
             if not self.__context['dry_run']:
-                self.executeCommandSequence(commandSequence)
+                executeProcess(commandSequence, context = self.__context)
 
 
 
@@ -416,7 +327,7 @@ class FfxController():
             self.__logger.debug(f"FfxController.runJob(): Running command sequence 1")
 
             if not self.__context['dry_run']:
-                self.executeCommandSequence(commandSequence1)
+                executeProcess(commandSequence1, context = self.__context)
 
             commandSequence2 = (commandTokens
                                 + self.__targetMediaDescriptor.getImportFileTokens()
@@ -443,7 +354,9 @@ class FfxController():
             self.__logger.debug(f"FfxController.runJob(): Running command sequence 2")
 
             if not self.__context['dry_run']:            
-                self.executeCommandSequence(commandSequence2)
+                out, err, rc = executeProcess(commandSequence2, context = self.__context)
+                if rc:
+                    raise click.ClickException(f"Command resulted in error: rc={rc} error={err}")
 
 
 
@@ -468,4 +381,4 @@ class FfxController():
                             str(length),
                             path]
 
-        self.executeCommandSequence(commandTokens)
+        out, err, rc = executeProcess(commandTokens, context = self.__context)

src/ffx/ffx_tests.py

@@ -1,33 +1,15 @@
 #! /usr/bin/python3
 
-import os, sys, logging, click
+import os, logging, click
-
-# Allow direct execution from the source tree by exposing both the repository
-# root for `tests.*` imports and `src/` for `ffx.*` imports.
-script_dir = os.path.dirname(os.path.abspath(__file__))
-repo_root = os.path.dirname(script_dir)
-src_root = os.path.join(repo_root, 'src')
-
-sys.path = [p for p in sys.path if os.path.abspath(p) != script_dir]
-for path in [repo_root, src_root]:
-    if path not in sys.path:
-        sys.path.insert(0, path)
-
-existing_pythonpath = [p for p in os.environ.get('PYTHONPATH', '').split(os.pathsep) if p]
-pythonpath_entries = []
-for path in [src_root, repo_root] + existing_pythonpath:
-    if path not in pythonpath_entries:
-        pythonpath_entries.append(path)
-os.environ['PYTHONPATH'] = os.pathsep.join(pythonpath_entries)
 
 from ffx.configuration_controller import ConfigurationController
 
 from ffx.file_properties import FileProperties
 from ffx.ffx_controller import FfxController
 
-from tests.legacy.helper import createMediaTestFile
+from ffx.test.helper import createMediaTestFile
 
-from tests.legacy.scenario import Scenario
+from ffx.test.scenario import Scenario
 from ffx.tmdb_controller import TMDB_API_KEY_NOT_PRESENT_EXCEPTION
 
 

src/ffx/file_properties.py

@@ -1,11 +1,5 @@
 import os, re, json
 
-from .constants import (
-    DEFAULT_CROPDETECT_DURATION_SECONDS,
-    DEFAULT_CROPDETECT_SEEK_SECONDS,
-    FFMPEG_COMMAND_TOKENS,
-    FFMPEG_NULL_OUTPUT_TOKENS,
-)
 from .media_descriptor import MediaDescriptor
 from .pattern_controller import PatternController
 
@@ -17,10 +11,8 @@ from ffx.model.pattern import Pattern
 
 
 class FileProperties():
-    _cropdetect_cache: dict[tuple[str, int, int, int, int], dict[str, str]] = {}
 
     FILE_EXTENSIONS = ['mkv', 'mp4', 'avi', 'flv', 'webm']
-    FFPROBE_COMMAND_TOKENS = ["ffprobe", "-hide_banner", "-show_format", "-show_streams", "-of", "json"]
 
     SE_INDICATOR_PATTERN = '([sS][0-9]+[eE][0-9]+)'
     SEASON_EPISODE_INDICATOR_MATCH = '[sS]([0-9]+)[eE]([0-9]+)'
@@ -30,18 +22,6 @@ class FileProperties():
 
     DEFAULT_INDEX_DIGITS = 3
 
-    @classmethod
-    def extractSeasonEpisodeValues(cls, sourceText: str) -> tuple[int | None, int] | None:
-        seasonEpisodeMatch = re.search(cls.SEASON_EPISODE_INDICATOR_MATCH, str(sourceText))
-        if seasonEpisodeMatch is not None:
-            return int(seasonEpisodeMatch.group(1)), int(seasonEpisodeMatch.group(2))
-
-        episodeMatch = re.search(cls.EPISODE_INDICATOR_MATCH, str(sourceText))
-        if episodeMatch is not None:
-            return None, int(episodeMatch.group(1))
-
-        return None
-
     def __init__(self, context, sourcePath):
 
         self.context = context
@@ -64,10 +44,9 @@ class FileProperties():
             self.__sourceFilenameExtension = ''
 
         self.__pc = PatternController(context)
-        self.__usePattern = bool(self.context.get('use_pattern', True))
 
         # Checking if database contains matching pattern
-        matchResult = self.__pc.matchFilename(self.__sourceFilename) if self.__usePattern else {}
+        matchResult = self.__pc.matchFilename(self.__sourceFilename)
 
         self.__logger.debug(f"FileProperties.__init__(): Match result: {matchResult}")
         
@@ -77,67 +56,26 @@ class FileProperties():
             databaseMatchedGroups = matchResult['match'].groups()
             self.__logger.debug(f"FileProperties.__init__(): Matched groups: {databaseMatchedGroups}")
 
-            indicatorSource = databaseMatchedGroups[0]
+            seIndicator = databaseMatchedGroups[0]
+
+            se_match = re.search(FileProperties.SEASON_EPISODE_INDICATOR_MATCH, seIndicator)
+            e_match = re.search(FileProperties.EPISODE_INDICATOR_MATCH, seIndicator)
+ 
         else:
             self.__logger.debug(f"FileProperties.__init__(): Checking file name for indicator {self.__sourceFilename}")
-            indicatorSource = self.__sourceFilename
 
-        seasonEpisodeValues = self.extractSeasonEpisodeValues(indicatorSource)
+            se_match = re.search(FileProperties.SEASON_EPISODE_INDICATOR_MATCH, self.__sourceFilename)
-        if seasonEpisodeValues is None:
+            e_match = re.search(FileProperties.EPISODE_INDICATOR_MATCH, self.__sourceFilename)
+
+        if se_match is not None:
+            self.__season = int(se_match.group(1))
+            self.__episode = int(se_match.group(2))
+        elif e_match is not None:
+            self.__season = -1
+            self.__episode = int(e_match.group(1))
+        else:
             self.__season = -1
             self.__episode = -1
-        else:
-            sourceSeason, sourceEpisode = seasonEpisodeValues
-            self.__season = -1 if sourceSeason is None else int(sourceSeason)
-            self.__episode = int(sourceEpisode)
-
-        self.__ffprobeData = None
-
-    def _getCropdetectWindow(self):
-        cropdetectContext = self.context.get('cropdetect', {})
-
-        seekSeconds = int(cropdetectContext.get('seek_seconds', DEFAULT_CROPDETECT_SEEK_SECONDS))
-        durationSeconds = int(cropdetectContext.get('duration_seconds', DEFAULT_CROPDETECT_DURATION_SECONDS))
-
-        if seekSeconds < 0:
-            raise ValueError("Crop detection seek seconds must be zero or greater.")
-        if durationSeconds <= 0:
-            raise ValueError("Crop detection duration seconds must be greater than zero.")
-
-        return seekSeconds, durationSeconds
-
-    def _getCropdetectCacheKey(self):
-        sourceStat = os.stat(self.__sourcePath)
-        seekSeconds, durationSeconds = self._getCropdetectWindow()
-
-        return (
-            os.path.abspath(self.__sourcePath),
-            sourceStat.st_mtime_ns,
-            sourceStat.st_size,
-            seekSeconds,
-            durationSeconds,
-        )
-
-    @classmethod
-    def _clear_cropdetect_cache(cls):
-        cls._cropdetect_cache.clear()
-
-    def _getFfprobeData(self):
-        if self.__ffprobeData is not None:
-            return self.__ffprobeData
-
-        ffprobeOutput, ffprobeError, returnCode = executeProcess(
-            FileProperties.FFPROBE_COMMAND_TOKENS + [self.__sourcePath]
-        )
-
-        if 'Invalid data found when processing input' in ffprobeError:
-            raise Exception(f"File {self.__sourcePath} does not contain valid stream data")
-
-        if returnCode != 0:
-            raise Exception(f"ffprobe returned with error {returnCode}")
-
-        self.__ffprobeData = json.loads(ffprobeOutput)
-        return self.__ffprobeData
 
 
     def getFormatData(self):
@@ -160,7 +98,22 @@ class FileProperties():
             }
         }       
         """
-        return self._getFfprobeData()['format']
+
+        # ffprobe -hide_banner -show_format -of json
+        ffprobeOutput, ffprobeError, returnCode = executeProcess(["ffprobe",
+                                                        "-hide_banner",
+                                                        "-show_format",
+                                                        "-of", "json",
+                                                        self.__sourcePath]) #,
+                                                        #context = self.context)
+
+        if 'Invalid data found when processing input' in ffprobeError:
+            raise Exception(f"File {self.__sourcePath} does not contain valid stream data")
+
+        if returnCode != 0:
+            raise Exception(f"ffprobe returned with error {returnCode}")
+
+        return json.loads(ffprobeOutput)['format']
 
 
     def getStreamData(self):
@@ -205,32 +158,40 @@ class FileProperties():
             }
         }
         """
-        return self._getFfprobeData()['streams']
+
+        # ffprobe -hide_banner -show_streams -of json
+        ffprobeOutput, ffprobeError, returnCode = executeProcess(["ffprobe",
+                                                        "-hide_banner",
+                                                        "-show_streams",
+                                                        "-of", "json",
+                                                        self.__sourcePath]) #,
+                                                        #context = self.context)
+
+        if 'Invalid data found when processing input' in ffprobeError:
+            raise Exception(f"File {self.__sourcePath} does not contain valid stream data")
+
+
+        if returnCode != 0:
+            raise Exception(f"ffprobe returned with error {returnCode}")
+
+
+        return json.loads(ffprobeOutput)['streams']
 
 
 
     def findCropArguments(self):
         """"""
 
-        cacheKey = self._getCropdetectCacheKey()
+        # ffmpeg -i <input.file> -vf cropdetect -f null -
-        cachedCropArguments = FileProperties._cropdetect_cache.get(cacheKey)
+        ffprobeOutput, ffprobeError, returnCode = executeProcess(["ffmpeg", "-i",
-        if cachedCropArguments is not None:
-            self.__logger.debug(
-                "FileProperties.findCropArguments(): Reusing cached cropdetect result for %s",
                                                         self.__sourcePath,
-            )
+                                                        "-vf", "cropdetect",
-            return dict(cachedCropArguments)
+                                                        "-ss", "60",
+                                                        "-t", "180",
+                                                        "-f", "null", "-"
+                                                        ])
 
-        seekSeconds, durationSeconds = self._getCropdetectWindow()
+        errorLines = ffprobeError.split('\n')
-
-        cropdetectCommand = (
-            list(FFMPEG_COMMAND_TOKENS)
-            + ["-ss", str(seekSeconds), "-i", self.__sourcePath, "-t", str(durationSeconds), "-vf", "cropdetect"]
-            + list(FFMPEG_NULL_OUTPUT_TOKENS)
-        )
-        _ffmpegOutput, ffmpegError, returnCode = executeProcess(cropdetectCommand, context=self.context)
-
-        errorLines = ffmpegError.split('\n')
 
         crops = {}
         for el in errorLines:
@@ -243,25 +204,20 @@ class FileProperties():
                 crops[cropParam] = crops.get(cropParam, 0) + 1
 
         if crops:
-            cropString = max(crops.items(), key=lambda item: (item[1], item[0]))[0]
+            cropHistogram = sorted(crops, reverse=True)
+            cropString = cropHistogram[0]
 
             cropTokens = cropString.split('=')
             cropValueTokens = cropTokens[1]
             cropValues = cropValueTokens.split(':')
 
-            cropArguments = {
+            return {
                 CropFilter.OUTPUT_WIDTH_KEY: cropValues[0],
                 CropFilter.OUTPUT_HEIGHT_KEY: cropValues[1],
                 CropFilter.OFFSET_X_KEY: cropValues[2],
                 CropFilter.OFFSET_Y_KEY: cropValues[3]
             }
-            FileProperties._cropdetect_cache[cacheKey] = dict(cropArguments)
+        else:
-            return cropArguments
-
-        if returnCode != 0:
-            raise Exception(f"ffmpeg cropdetect returned with error {returnCode}")
-
-        FileProperties._cropdetect_cache[cacheKey] = {}
             return {}
 
 

src/ffx/helper.py

@@ -1,10 +1,8 @@
-import re
+import re, logging
 
 from jinja2 import Environment, Undefined
 from .constants import DEFAULT_OUTPUT_FILENAME_TEMPLATE
 from .configuration_controller import ConfigurationController
-from .logging_utils import get_ffx_logger
-from .show_descriptor import ShowDescriptor
 
 
 class EmptyStringUndefined(Undefined):
@@ -17,21 +15,7 @@ DIFF_REMOVED_KEY = 'removed'
 DIFF_CHANGED_KEY = 'changed'
 DIFF_UNCHANGED_KEY = 'unchanged'
 
-FILENAME_FILTER_TRANSLATION = str.maketrans(
+RICH_COLOR_PATTERN = '\[[a-z_]+\](.+)\[\/[a-z_]+\]'
-    {
-        "/": "-",
-        ":": ";",
-        "*": "",
-        "'": "",
-        "?": "#",
-        "♥": "",
-        "’": "",
-    }
-)
-TMDB_FILLER_MARKERS = (" (*)", "(*)")
-TMDB_EPISODE_RANGE_SUFFIX_REGEX = re.compile(r"\(([0-9]+)[-/]([0-9]+)\)$")
-TMDB_EPISODE_PART_SUFFIX_REGEX = re.compile(r"\(([0-9]+)\)$")
-RICH_COLOR_REGEX = re.compile(r"\[[a-z_]+\](.+)\[/[a-z_]+\]")
 
 
 def dictDiff(a : dict, b : dict, ignoreKeys: list = [], removeKeys: list = []):
@@ -130,45 +114,49 @@ def filterFilename(fileName: str) -> str:
     """This filter replaces charactes from TMDB responses with characters
     less problemating when using in filenames or removes them"""
 
-    return str(fileName).translate(FILENAME_FILTER_TRANSLATION).strip()
+    fileName = str(fileName).replace('/', '-')
+    fileName = str(fileName).replace(':', ';')
+    fileName = str(fileName).replace('*', '')
+    fileName = str(fileName).replace("'", '')
+    fileName = str(fileName).replace("?", '#')
+    fileName = str(fileName).replace('♥', '')
+    fileName = str(fileName).replace('’', '')
+
+    return fileName.strip()
 
 def substituteTmdbFilename(fileName: str) -> str:
     """If chaining this method with filterFilename use this one first as the latter will destroy some patterns"""
 
-    normalizedFileName = str(fileName)
+    # This indicates filler episodes in TMDB episode names
+    fileName = str(fileName).replace(' (*)', '')
+    fileName = str(fileName).replace('(*)', '')
 
-    for fillerMarker in TMDB_FILLER_MARKERS:
+    # This indicates the index of multi-episode files
-        normalizedFileName = normalizedFileName.replace(fillerMarker, '')
+    episodePartMatch = re.search("\\(([0-9]+)\\)$", fileName)
-
-    episodeRangeMatch = TMDB_EPISODE_RANGE_SUFFIX_REGEX.search(normalizedFileName)
-    if episodeRangeMatch is not None:
-        partFirstIndex, partLastIndex = episodeRangeMatch.groups()
-        return TMDB_EPISODE_RANGE_SUFFIX_REGEX.sub(
-            f"Teil {partFirstIndex}-{partLastIndex}",
-            normalizedFileName,
-            count=1,
-        )
-
-    episodePartMatch = TMDB_EPISODE_PART_SUFFIX_REGEX.search(normalizedFileName)
     if episodePartMatch is not None:
-        partIndex = episodePartMatch.group(1)
+        partSuffix = str(episodePartMatch.group(0))
-        return TMDB_EPISODE_PART_SUFFIX_REGEX.sub(
+        partIndex = episodePartMatch.groups()[0]
-            f"Teil {partIndex}",
+        fileName = str(fileName).replace(partSuffix, f"Teil {partIndex}")
-            normalizedFileName,
-            count=1,
-        )
 
-    return normalizedFileName
+    # Also multi-episodes with first and last episode index
+    episodePartMatch = re.search("\\(([0-9]+)[-\\/]([0-9]+)\\)$", fileName)
+    if episodePartMatch is not None:
+        partSuffix = str(episodePartMatch.group(0))
+        partFirstIndex = episodePartMatch.groups()[0]
+        partLastIndex = episodePartMatch.groups()[1]
+        fileName = str(fileName).replace(partSuffix, f"Teil {partFirstIndex}-{partLastIndex}")
+
+    return fileName
 
 
 def getEpisodeFileBasename(showName,
                             episodeName,
                             season,
                             episode,
-                            indexSeasonDigits = None,
+                            indexSeasonDigits = 2,
-                            indexEpisodeDigits = None,
+                            indexEpisodeDigits = 2,
-                            indicatorSeasonDigits = None,
+                            indicatorSeasonDigits = 2,
-                            indicatorEpisodeDigits = None,
+                            indicatorEpisodeDigits = 2,
                             context = None):
     """
     One Piece:
@@ -200,21 +188,12 @@ def getEpisodeFileBasename(showName,
     configData = cc.getData() if cc is not None else {}
     outputFilenameTemplate = configData.get(ConfigurationController.OUTPUT_FILENAME_TEMPLATE_KEY,
                                             DEFAULT_OUTPUT_FILENAME_TEMPLATE)
-    defaultDigitLengths = ShowDescriptor.getDefaultDigitLengths(context)
-
-    if indexSeasonDigits is None:
-        indexSeasonDigits = defaultDigitLengths[ShowDescriptor.INDEX_SEASON_DIGITS_KEY]
-    if indexEpisodeDigits is None:
-        indexEpisodeDigits = defaultDigitLengths[ShowDescriptor.INDEX_EPISODE_DIGITS_KEY]
-    if indicatorSeasonDigits is None:
-        indicatorSeasonDigits = defaultDigitLengths[ShowDescriptor.INDICATOR_SEASON_DIGITS_KEY]
-    if indicatorEpisodeDigits is None:
-        indicatorEpisodeDigits = defaultDigitLengths[ShowDescriptor.INDICATOR_EPISODE_DIGITS_KEY]
 
     if context is not None and 'logger' in context.keys():
         logger = context['logger']
     else:
-        logger = get_ffx_logger()
+        logger = logging.getLogger('FFX')
+        logger.addHandler(logging.NullHandler())        
 
 
     indexSeparator = ' ' if indexSeasonDigits or indexEpisodeDigits else ''
@@ -252,8 +231,9 @@ def formatRichColor(text: str, color: str = None):
         return f"[{color}]{text}[/{color}]"
 
 def removeRichColor(text: str):
-    richColorMatch = RICH_COLOR_REGEX.search(str(text))
+    richColorMatch = re.search(RICH_COLOR_PATTERN, text)
     if richColorMatch is None:
         return text
     else:
         return str(richColorMatch.group(1))
+

src/ffx/iso_language.py

@@ -1,155 +1,68 @@
 from enum import Enum
 import difflib
 
-
 class IsoLanguage(Enum):
 
-    ABKHAZIAN         = {"name": "Abkhazian", "iso639_1": "ab", "iso639_2": ["abk"]}
-    AFAR              = {"name": "Afar", "iso639_1": "aa", "iso639_2": ["aar"]}
     AFRIKAANS       = {"name": "Afrikaans", "iso639_1": "af", "iso639_2": ["afr"]}
-    AKAN              = {"name": "Akan", "iso639_1": "ak", "iso639_2": ["aka"]}
+    ALBANIAN        = {"name": "Albanian", "iso639_1": "sq", "iso639_2": ["alb"]}
-    ALBANIAN          = {"name": "Albanian", "iso639_1": "sq", "iso639_2": ["sqi", "alb"]}
-    AMHARIC           = {"name": "Amharic", "iso639_1": "am", "iso639_2": ["amh"]}
     ARABIC          = {"name": "Arabic", "iso639_1": "ar", "iso639_2": ["ara"]}
-    ARAGONESE         = {"name": "Aragonese", "iso639_1": "an", "iso639_2": ["arg"]}
+    ARMENIAN        = {"name": "Armenian", "iso639_1": "hy", "iso639_2": ["arm"]}
-    ARMENIAN          = {"name": "Armenian", "iso639_1": "hy", "iso639_2": ["hye", "arm"]}
-    ASSAMESE          = {"name": "Assamese", "iso639_1": "as", "iso639_2": ["asm"]}
-    AVARIC            = {"name": "Avaric", "iso639_1": "av", "iso639_2": ["ava"]}
-    AVESTAN           = {"name": "Avestan", "iso639_1": "ae", "iso639_2": ["ave"]}
-    AYMARA            = {"name": "Aymara", "iso639_1": "ay", "iso639_2": ["aym"]}
     AZERBAIJANI     = {"name": "Azerbaijani", "iso639_1": "az", "iso639_2": ["aze"]}
-    BAMBARA           = {"name": "Bambara", "iso639_1": "bm", "iso639_2": ["bam"]}
+    BASQUE          = {"name": "Basque", "iso639_1": "eu", "iso639_2": ["baq"]}
-    BASHKIR           = {"name": "Bashkir", "iso639_1": "ba", "iso639_2": ["bak"]}
-    BASQUE            = {"name": "Basque", "iso639_1": "eu", "iso639_2": ["eus", "baq"]}
     BELARUSIAN      = {"name": "Belarusian", "iso639_1": "be", "iso639_2": ["bel"]}
-    BENGALI           = {"name": "Bengali", "iso639_1": "bn", "iso639_2": ["ben"]}
+    BOKMAL          = {"name": "Bokmål", "iso639_1": "nb", "iso639_2": ["nob"]} # Norwegian Bokmål
-    BISLAMA           = {"name": "Bislama", "iso639_1": "bi", "iso639_2": ["bis"]}
-    BOKMAL            = {"name": "Bokmål", "iso639_1": "nb", "iso639_2": ["nob"]}
-    BOSNIAN           = {"name": "Bosnian", "iso639_1": "bs", "iso639_2": ["bos"]}
-    BRETON            = {"name": "Breton", "iso639_1": "br", "iso639_2": ["bre"]}
     BULGARIAN       = {"name": "Bulgarian", "iso639_1": "bg", "iso639_2": ["bul"]}
-    BURMESE           = {"name": "Burmese", "iso639_1": "my", "iso639_2": ["mya", "bur"]}
     CATALAN         = {"name": "Catalan", "iso639_1": "ca", "iso639_2": ["cat"]}
-    CHAMORRO          = {"name": "Chamorro", "iso639_1": "ch", "iso639_2": ["cha"]}
-    CHECHEN           = {"name": "Chechen", "iso639_1": "ce", "iso639_2": ["che"]}
-    CHICHEWA          = {"name": "Chichewa", "iso639_1": "ny", "iso639_2": ["nya"]}
     CHINESE         = {"name": "Chinese", "iso639_1": "zh", "iso639_2": ["zho", "chi"]}
-    CHURCH_SLAVIC     = {"name": "Church Slavic", "iso639_1": "cu", "iso639_2": ["chu"]}
-    CHUVASH           = {"name": "Chuvash", "iso639_1": "cv", "iso639_2": ["chv"]}
-    CORNISH           = {"name": "Cornish", "iso639_1": "kw", "iso639_2": ["cor"]}
-    CORSICAN          = {"name": "Corsican", "iso639_1": "co", "iso639_2": ["cos"]}
-    CREE              = {"name": "Cree", "iso639_1": "cr", "iso639_2": ["cre"]}
     CROATIAN        = {"name": "Croatian", "iso639_1": "hr", "iso639_2": ["hrv"]}
-    CZECH             = {"name": "Czech", "iso639_1": "cs", "iso639_2": ["ces", "cze"]}
+    CZECH           = {"name": "Czech", "iso639_1": "cs", "iso639_2": ["cze"]}
     DANISH          = {"name": "Danish", "iso639_1": "da", "iso639_2": ["dan"]}
-    DIVEHI            = {"name": "Divehi", "iso639_1": "dv", "iso639_2": ["div"]}
     DUTCH           = {"name": "Dutch", "iso639_1": "nl", "iso639_2": ["nld", "dut"]}
-    DZONGKHA          = {"name": "Dzongkha", "iso639_1": "dz", "iso639_2": ["dzo"]}
     ENGLISH         = {"name": "English", "iso639_1": "en", "iso639_2": ["eng"]}
-    ESPERANTO         = {"name": "Esperanto", "iso639_1": "eo", "iso639_2": ["epo"]}
     ESTONIAN        = {"name": "Estonian", "iso639_1": "et", "iso639_2": ["est"]}
-    EWE               = {"name": "Ewe", "iso639_1": "ee", "iso639_2": ["ewe"]}
+    FILIPINO        = {"name": "Filipino", "iso639_1": "tl", "iso639_2": ["fil"]} # Tagalog
-    FAROESE           = {"name": "Faroese", "iso639_1": "fo", "iso639_2": ["fao"]}
-    FIJIAN            = {"name": "Fijian", "iso639_1": "fj", "iso639_2": ["fij"]}
     FINNISH         = {"name": "Finnish", "iso639_1": "fi", "iso639_2": ["fin"]}
     FRENCH          = {"name": "French", "iso639_1": "fr", "iso639_2": ["fra", "fre"]}
-    FULAH             = {"name": "Fulah", "iso639_1": "ff", "iso639_2": ["ful"]}
     GALICIAN        = {"name": "Galician", "iso639_1": "gl", "iso639_2": ["glg"]}
-    GANDA             = {"name": "Ganda", "iso639_1": "lg", "iso639_2": ["lug"]}
+    GEORGIAN        = {"name": "Georgian", "iso639_1": "ka", "iso639_2": ["geo"]}
-    GEORGIAN          = {"name": "Georgian", "iso639_1": "ka", "iso639_2": ["kat", "geo"]}
     GERMAN          = {"name": "German", "iso639_1": "de", "iso639_2": ["deu", "ger"]}
-    GREEK             = {"name": "Greek", "iso639_1": "el", "iso639_2": ["ell", "gre"]}
+    GREEK           = {"name": "Greek", "iso639_1": "el", "iso639_2": ["gre"]}
-    GUARANI           = {"name": "Guarani", "iso639_1": "gn", "iso639_2": ["grn"]}
-    GUJARATI          = {"name": "Gujarati", "iso639_1": "gu", "iso639_2": ["guj"]}
-    HAITIAN           = {"name": "Haitian", "iso639_1": "ht", "iso639_2": ["hat"]}
-    HAUSA             = {"name": "Hausa", "iso639_1": "ha", "iso639_2": ["hau"]}
     HEBREW          = {"name": "Hebrew", "iso639_1": "he", "iso639_2": ["heb"]}
-    HERERO            = {"name": "Herero", "iso639_1": "hz", "iso639_2": ["her"]}
     HINDI           = {"name": "Hindi", "iso639_1": "hi", "iso639_2": ["hin"]}
-    HIRI_MOTU         = {"name": "Hiri Motu", "iso639_1": "ho", "iso639_2": ["hmo"]}
     HUNGARIAN       = {"name": "Hungarian", "iso639_1": "hu", "iso639_2": ["hun"]}
-    ICELANDIC         = {"name": "Icelandic", "iso639_1": "is", "iso639_2": ["isl", "ice"]}
+    ICELANDIC       = {"name": "Icelandic", "iso639_1": "is", "iso639_2": ["ice"]}
-    IDO               = {"name": "Ido", "iso639_1": "io", "iso639_2": ["ido"]}
-    IGBO              = {"name": "Igbo", "iso639_1": "ig", "iso639_2": ["ibo"]}
     INDONESIAN      = {"name": "Indonesian", "iso639_1": "id", "iso639_2": ["ind"]}
-    INTERLINGUA       = {"name": "Interlingua", "iso639_1": "ia", "iso639_2": ["ina"]}
-    INTERLINGUE       = {"name": "Interlingue", "iso639_1": "ie", "iso639_2": ["ile"]}
-    INUKTITUT         = {"name": "Inuktitut", "iso639_1": "iu", "iso639_2": ["iku"]}
-    INUPIAQ           = {"name": "Inupiaq", "iso639_1": "ik", "iso639_2": ["ipk"]}
     IRISH           = {"name": "Irish", "iso639_1": "ga", "iso639_2": ["gle"]}
     ITALIAN         = {"name": "Italian", "iso639_1": "it", "iso639_2": ["ita"]}
     JAPANESE        = {"name": "Japanese", "iso639_1": "ja", "iso639_2": ["jpn"]}
-    JAVANESE          = {"name": "Javanese", "iso639_1": "jv", "iso639_2": ["jav"]}
-    KALAALLISUT       = {"name": "Kalaallisut", "iso639_1": "kl", "iso639_2": ["kal"]}
     KANNADA         = {"name": "Kannada", "iso639_1": "kn", "iso639_2": ["kan"]}
-    KANURI            = {"name": "Kanuri", "iso639_1": "kr", "iso639_2": ["kau"]}
-    KASHMIRI          = {"name": "Kashmiri", "iso639_1": "ks", "iso639_2": ["kas"]}
     KAZAKH          = {"name": "Kazakh", "iso639_1": "kk", "iso639_2": ["kaz"]}
-    KHMER             = {"name": "Khmer", "iso639_1": "km", "iso639_2": ["khm"]}
-    KIKUYU            = {"name": "Kikuyu", "iso639_1": "ki", "iso639_2": ["kik"]}
-    KINYARWANDA       = {"name": "Kinyarwanda", "iso639_1": "rw", "iso639_2": ["kin"]}
-    KIRGHIZ           = {"name": "Kirghiz", "iso639_1": "ky", "iso639_2": ["kir"]}
-    KOMI              = {"name": "Komi", "iso639_1": "kv", "iso639_2": ["kom"]}
-    KONGO             = {"name": "Kongo", "iso639_1": "kg", "iso639_2": ["kon"]}
     KOREAN          = {"name": "Korean", "iso639_1": "ko", "iso639_2": ["kor"]}
-    KUANYAMA          = {"name": "Kuanyama", "iso639_1": "kj", "iso639_2": ["kua"]}
-    KURDISH           = {"name": "Kurdish", "iso639_1": "ku", "iso639_2": ["kur"]}
-    LAO               = {"name": "Lao", "iso639_1": "lo", "iso639_2": ["lao"]}
     LATIN           = {"name": "Latin", "iso639_1": "la", "iso639_2": ["lat"]}
     LATVIAN         = {"name": "Latvian", "iso639_1": "lv", "iso639_2": ["lav"]}
-    LIMBURGAN         = {"name": "Limburgan", "iso639_1": "li", "iso639_2": ["lim"]}
-    LINGALA           = {"name": "Lingala", "iso639_1": "ln", "iso639_2": ["lin"]}
     LITHUANIAN      = {"name": "Lithuanian", "iso639_1": "lt", "iso639_2": ["lit"]}
-    LUBA_KATANGA      = {"name": "Luba-Katanga", "iso639_1": "lu", "iso639_2": ["lub"]}
+    MACEDONIAN      = {"name": "Macedonian", "iso639_1": "mk", "iso639_2": ["mac"]}
-    LUXEMBOURGISH     = {"name": "Luxembourgish", "iso639_1": "lb", "iso639_2": ["ltz"]}
+    MALAY           = {"name": "Malay", "iso639_1": "ms", "iso639_2": ["may"]}
-    MACEDONIAN        = {"name": "Macedonian", "iso639_1": "mk", "iso639_2": ["mkd", "mac"]}
-    MALAGASY          = {"name": "Malagasy", "iso639_1": "mg", "iso639_2": ["mlg"]}
-    MALAY             = {"name": "Malay", "iso639_1": "ms", "iso639_2": ["msa", "may"]}
     MALAYALAM       = {"name": "Malayalam", "iso639_1": "ml", "iso639_2": ["mal"]}
     MALTESE         = {"name": "Maltese", "iso639_1": "mt", "iso639_2": ["mlt"]}
-    MANX              = {"name": "Manx", "iso639_1": "gv", "iso639_2": ["glv"]}
-    MAORI             = {"name": "Maori", "iso639_1": "mi", "iso639_2": ["mri", "mao"]}
-    MARATHI           = {"name": "Marathi", "iso639_1": "mr", "iso639_2": ["mar"]}
-    MARSHALLESE       = {"name": "Marshallese", "iso639_1": "mh", "iso639_2": ["mah"]}
-    MONGOLIAN         = {"name": "Mongolian", "iso639_1": "mn", "iso639_2": ["mon"]}
-    NAURU             = {"name": "Nauru", "iso639_1": "na", "iso639_2": ["nau"]}
-    NAVAJO            = {"name": "Navajo", "iso639_1": "nv", "iso639_2": ["nav"]}
-    NDONGA            = {"name": "Ndonga", "iso639_1": "ng", "iso639_2": ["ndo"]}
-    NEPALI            = {"name": "Nepali", "iso639_1": "ne", "iso639_2": ["nep"]}
-    NORTH_NDEBELE     = {"name": "North Ndebele", "iso639_1": "nd", "iso639_2": ["nde"]}
-    NORTHERN_SAMI     = {"name": "Northern Sami", "iso639_1": "se", "iso639_2": ["sme"]}
     NORWEGIAN       = {"name": "Norwegian", "iso639_1": "no", "iso639_2": ["nor"]}
-    NORWEGIAN_NYNORSK = {"name": "Nynorsk", "iso639_1": "nn", "iso639_2": ["nno"]}
+    PERSIAN         = {"name": "Persian", "iso639_1": "fa", "iso639_2": ["per"]}
-    OCCITAN           = {"name": "Occitan", "iso639_1": "oc", "iso639_2": ["oci"]}
-    OJIBWA            = {"name": "Ojibwa", "iso639_1": "oj", "iso639_2": ["oji"]}
-    ORIYA             = {"name": "Oriya", "iso639_1": "or", "iso639_2": ["ori"]}
-    OROMO             = {"name": "Oromo", "iso639_1": "om", "iso639_2": ["orm"]}
-    OSSETIAN          = {"name": "Ossetian", "iso639_1": "os", "iso639_2": ["oss"]}
-    PALI              = {"name": "Pali", "iso639_1": "pi", "iso639_2": ["pli"]}
-    PANJABI           = {"name": "Panjabi", "iso639_1": "pa", "iso639_2": ["pan"]}
-    PERSIAN           = {"name": "Persian", "iso639_1": "fa", "iso639_2": ["fas", "per"]}
     POLISH          = {"name": "Polish", "iso639_1": "pl", "iso639_2": ["pol"]}
     PORTUGUESE      = {"name": "Portuguese", "iso639_1": "pt", "iso639_2": ["por"]}
-    PUSHTO            = {"name": "Pushto", "iso639_1": "ps", "iso639_2": ["pus"]}
+    ROMANIAN        = {"name": "Romanian", "iso639_1": "ro", "iso639_2": ["rum"]}
-    QUECHUA           = {"name": "Quechua", "iso639_1": "qu", "iso639_2": ["que"]}
-    ROMANIAN          = {"name": "Romanian", "iso639_1": "ro", "iso639_2": ["ron", "rum"]}
-    ROMANSH           = {"name": "Romansh", "iso639_1": "rm", "iso639_2": ["roh"]}
-    RUNDI             = {"name": "Rundi", "iso639_1": "rn", "iso639_2": ["run"]}
     RUSSIAN         = {"name": "Russian", "iso639_1": "ru", "iso639_2": ["rus"]}
+    NORTHERN_SAMI   = {"name": "Northern Sami", "iso639_1": "se", "iso639_2": ["sme"]}
     SAMOAN          = {"name": "Samoan", "iso639_1": "sm", "iso639_2": ["smo"]}
     SANGO           = {"name": "Sango", "iso639_1": "sg", "iso639_2": ["sag"]}
     SANSKRIT        = {"name": "Sanskrit", "iso639_1": "sa", "iso639_2": ["san"]}
     SARDINIAN       = {"name": "Sardinian", "iso639_1": "sc", "iso639_2": ["srd"]}
-    SCOTTISH_GAELIC   = {"name": "Scottish Gaelic", "iso639_1": "gd", "iso639_2": ["gla"]}
     SERBIAN         = {"name": "Serbian", "iso639_1": "sr", "iso639_2": ["srp"]}
     SHONA           = {"name": "Shona", "iso639_1": "sn", "iso639_2": ["sna"]}
-    SICHUAN_YI        = {"name": "Sichuan Yi", "iso639_1": "ii", "iso639_2": ["iii"]}
     SINDHI          = {"name": "Sindhi", "iso639_1": "sd", "iso639_2": ["snd"]}
     SINHALA         = {"name": "Sinhala", "iso639_1": "si", "iso639_2": ["sin"]}
-    SLOVAK            = {"name": "Slovak", "iso639_1": "sk", "iso639_2": ["slk", "slo"]}
+    SLOVAK          = {"name": "Slovak", "iso639_1": "sk", "iso639_2": ["slk"]}
     SLOVENIAN       = {"name": "Slovenian", "iso639_1": "sl", "iso639_2": ["slv"]}
     SOMALI          = {"name": "Somali", "iso639_1": "so", "iso639_2": ["som"]}
-    SOUTH_NDEBELE     = {"name": "South Ndebele", "iso639_1": "nr", "iso639_2": ["nbl"]}
     SOUTHERN_SOTHO  = {"name": "Southern Sotho", "iso639_1": "st", "iso639_2": ["sot"]}
     SPANISH         = {"name": "Spanish", "iso639_1": "es", "iso639_2": ["spa"]}
     SUNDANESE       = {"name": "Sundanese", "iso639_1": "su", "iso639_2": ["sun"]}
@@ -157,38 +70,14 @@ class IsoLanguage(Enum):
     SWATI           = {"name": "Swati", "iso639_1": "ss", "iso639_2": ["ssw"]}
     SWEDISH         = {"name": "Swedish", "iso639_1": "sv", "iso639_2": ["swe"]}
     TAGALOG         = {"name": "Tagalog", "iso639_1": "tl", "iso639_2": ["tgl"]}
-    TAHITIAN          = {"name": "Tahitian", "iso639_1": "ty", "iso639_2": ["tah"]}
-    TAJIK             = {"name": "Tajik", "iso639_1": "tg", "iso639_2": ["tgk"]}
     TAMIL           = {"name": "Tamil", "iso639_1": "ta", "iso639_2": ["tam"]}
-    TATAR             = {"name": "Tatar", "iso639_1": "tt", "iso639_2": ["tat"]}
     TELUGU          = {"name": "Telugu", "iso639_1": "te", "iso639_2": ["tel"]}
     THAI            = {"name": "Thai", "iso639_1": "th", "iso639_2": ["tha"]}
-    TIBETAN           = {"name": "Tibetan", "iso639_1": "bo", "iso639_2": ["bod", "tib"]}
-    TIGRINYA          = {"name": "Tigrinya", "iso639_1": "ti", "iso639_2": ["tir"]}
-    TONGA             = {"name": "Tonga", "iso639_1": "to", "iso639_2": ["ton"]}
-    TSONGA            = {"name": "Tsonga", "iso639_1": "ts", "iso639_2": ["tso"]}
-    TSWANA            = {"name": "Tswana", "iso639_1": "tn", "iso639_2": ["tsn"]}
     TURKISH         = {"name": "Turkish", "iso639_1": "tr", "iso639_2": ["tur"]}
-    TURKMEN           = {"name": "Turkmen", "iso639_1": "tk", "iso639_2": ["tuk"]}
-    TWI               = {"name": "Twi", "iso639_1": "tw", "iso639_2": ["twi"]}
-    UIGHUR            = {"name": "Uighur", "iso639_1": "ug", "iso639_2": ["uig"]}
     UKRAINIAN       = {"name": "Ukrainian", "iso639_1": "uk", "iso639_2": ["ukr"]}
     URDU            = {"name": "Urdu", "iso639_1": "ur", "iso639_2": ["urd"]}
-    UZBEK             = {"name": "Uzbek", "iso639_1": "uz", "iso639_2": ["uzb"]}
+    VIETNAMESE      = {"name": "Vietnamese", "iso639_1": "vi", "iso639_2":[ "vie"]}
-    VENDA             = {"name": "Venda", "iso639_1": "ve", "iso639_2": ["ven"]}
+    WELSH           = {"name": "Welsh", "iso639_1": "cy", "iso639_2": ["wel"]}
-    VIETNAMESE        = {"name": "Vietnamese", "iso639_1": "vi", "iso639_2": ["vie"]}
-    VOLAPUK           = {"name": "Volapük", "iso639_1": "vo", "iso639_2": ["vol"]}
-    WALLOON           = {"name": "Walloon", "iso639_1": "wa", "iso639_2": ["wln"]}
-    WELSH             = {"name": "Welsh", "iso639_1": "cy", "iso639_2": ["cym", "wel"]}
-    WESTERN_FRISIAN   = {"name": "Western Frisian", "iso639_1": "fy", "iso639_2": ["fry"]}
-    WOLOF             = {"name": "Wolof", "iso639_1": "wo", "iso639_2": ["wol"]}
-    XHOSA             = {"name": "Xhosa", "iso639_1": "xh", "iso639_2": ["xho"]}
-    YIDDISH           = {"name": "Yiddish", "iso639_1": "yi", "iso639_2": ["yid"]}
-    YORUBA            = {"name": "Yoruba", "iso639_1": "yo", "iso639_2": ["yor"]}
-    ZHUANG            = {"name": "Zhuang", "iso639_1": "za", "iso639_2": ["zha"]}
-    ZULU              = {"name": "Zulu", "iso639_1": "zu", "iso639_2": ["zul"]}
-
-    FILIPINO          = {"name": "Filipino", "iso639_1": "tl", "iso639_2": ["fil"]}
 
     UNDEFINED       = {"name": "undefined", "iso639_1": "xx", "iso639_2": ["und"]}
 
@@ -199,22 +88,24 @@ class IsoLanguage(Enum):
         closestMatches = difflib.get_close_matches(label, [l.value["name"] for l in IsoLanguage], n=1)
 
         if closestMatches:
-            foundLangs = [l for l in IsoLanguage if l.value["name"] == closestMatches[0]]
+            foundLangs = [l for l in IsoLanguage if l.value['name'] == closestMatches[0]]
             return foundLangs[0] if foundLangs else IsoLanguage.UNDEFINED
         else:
             return IsoLanguage.UNDEFINED
 
     @staticmethod
     def findThreeLetter(theeLetter : str):
-        foundLangs = [l for l in IsoLanguage if str(theeLetter) in l.value["iso639_2"]]
+        foundLangs = [l for l in IsoLanguage if str(theeLetter) in l.value['iso639_2']]
         return foundLangs[0] if foundLangs else IsoLanguage.UNDEFINED
 
 
     def label(self):
-        return str(self.value["name"])
+        return str(self.value['name'])
 
     def twoLetter(self):
-        return str(self.value["iso639_1"])
+        return str(self.value['iso639_1'])
     
     def threeLetter(self):
-        return str(self.value["iso639_2"][0])
+        return str(self.value['iso639_2'][0])
+
+    

src/ffx/logging_utils.py

@@ -1,68 +0,0 @@
-import logging
-import os
-
-
-FFX_LOGGER_NAME = "FFX"
-CONSOLE_HANDLER_NAME = "ffx-console"
-FILE_HANDLER_NAME = "ffx-file"
-
-
-def get_ffx_logger(name: str = FFX_LOGGER_NAME) -> logging.Logger:
-    logger = logging.getLogger(name)
-    logger.setLevel(logging.DEBUG)
-
-    if not logger.handlers:
-        logger.addHandler(logging.NullHandler())
-
-    return logger
-
-
-def configure_ffx_logger(
-    log_file_path: str,
-    file_level: int,
-    console_level: int,
-    name: str = FFX_LOGGER_NAME,
-) -> logging.Logger:
-    logger = get_ffx_logger(name)
-    logger.propagate = False
-
-    for handler in list(logger.handlers):
-        if isinstance(handler, logging.NullHandler):
-            logger.removeHandler(handler)
-
-    console_handler = next(
-        (handler for handler in logger.handlers if handler.get_name() == CONSOLE_HANDLER_NAME),
-        None,
-    )
-    if console_handler is None:
-        console_handler = logging.StreamHandler()
-        console_handler.set_name(CONSOLE_HANDLER_NAME)
-        logger.addHandler(console_handler)
-
-    console_handler.setLevel(console_level)
-    console_handler.setFormatter(logging.Formatter("%(message)s"))
-
-    normalized_log_path = os.path.abspath(log_file_path)
-    file_handler = next(
-        (handler for handler in logger.handlers if handler.get_name() == FILE_HANDLER_NAME),
-        None,
-    )
-    if (
-        file_handler is not None
-        and os.path.abspath(file_handler.baseFilename) != normalized_log_path
-    ):
-        logger.removeHandler(file_handler)
-        file_handler.close()
-        file_handler = None
-
-    if file_handler is None:
-        file_handler = logging.FileHandler(normalized_log_path)
-        file_handler.set_name(FILE_HANDLER_NAME)
-        logger.addHandler(file_handler)
-
-    file_handler.setLevel(file_level)
-    file_handler.setFormatter(
-        logging.Formatter("%(asctime)s - %(name)s - %(levelname)s - %(message)s")
-    )
-
-    return logger

src/ffx/media_controller.py

@@ -25,9 +25,10 @@ class MediaController():
             pid = int(patternId)
 
             s = self.Session()
-            pattern = s.query(Pattern).filter(Pattern.id == pid).first()
+            q = s.query(Pattern).filter(Pattern.id == pid)
 
-            if pattern is not None:
+            if q.count():
+                pattern = q.first
 
                 for mediaTagKey, mediaTagValue in mediaDescriptor.getTags():
                     self.__tac.updateMediaTag(pid, mediaTagKey, mediaTagValue)

src/ffx/media_descriptor.py

@@ -1,4 +1,4 @@
-import os, re, click
+import os, re, click, logging
 
 from typing import List, Self
 
@@ -9,7 +9,6 @@ from ffx.track_disposition import TrackDisposition
 from ffx.track_codec import TrackCodec
 
 from ffx.track_descriptor import TrackDescriptor
-from ffx.logging_utils import get_ffx_logger
 
 
 class MediaDescriptor:
@@ -47,7 +46,8 @@ class MediaDescriptor:
             self.__logger = self.__context['logger']
         else:
             self.__context = {}
-            self.__logger = get_ffx_logger()
+            self.__logger = logging.getLogger('FFX')
+            self.__logger.addHandler(logging.NullHandler())
 
         if MediaDescriptor.TAGS_KEY in kwargs.keys():
             if type(kwargs[MediaDescriptor.TAGS_KEY]) is not dict:
@@ -207,7 +207,7 @@ class MediaDescriptor:
     def rearrangeTrackDescriptors(self, newOrder: List[int]):
         if len(newOrder) != len(self.__trackDescriptors):
             raise ValueError('Length of list with reordered indices does not match number of track descriptors')
-        reorderedTrackDescriptors = []
+        reorderedTrackDescriptors = {}
         for oldIndex in newOrder:
             reorderedTrackDescriptors.append(self.__trackDescriptors[oldIndex])
         self.__trackDescriptors = reorderedTrackDescriptors
@@ -362,14 +362,6 @@ class MediaDescriptor:
         inputMappingTokens = []
         
         sortedTrackDescriptors = sorted(self.__trackDescriptors, key=lambda d: d.getIndex())
-        sourceTrackDescriptorsByIndex = {
-            td.getIndex(): td
-            for td in (
-                sourceMediaDescriptor.getTrackDescriptors()
-                if sourceMediaDescriptor is not None
-                else sortedTrackDescriptors
-            )
-        }
 
         # raise click.ClickException(' '.join([f"\nindex={td.getIndex()} subIndex={td.getSubIndex()} srcIndex={td.getSourceIndex()} type={td.getType().label()}" for td in self.__trackDescriptors]))
 
@@ -381,12 +373,8 @@ class MediaDescriptor:
             #HINT: Attached thumbnails are not supported by .webm container format
             if td.getCodec() != TrackCodec.PNG:
 
-                sourceTrackDescriptor = sourceTrackDescriptorsByIndex.get(td.getSourceIndex())
+                stdi = sortedTrackDescriptors[td.getSourceIndex()].getIndex()
-                if sourceTrackDescriptor is None:
+                stdsi = sortedTrackDescriptors[td.getSourceIndex()].getSubIndex()
-                    raise ValueError(f"No source track descriptor found for source index {td.getSourceIndex()}")
-
-                stdi = sourceTrackDescriptor.getIndex()
-                stdsi = sourceTrackDescriptor.getSubIndex()
 
                 trackType = td.getType()
                 trackCodec = td.getCodec()
@@ -500,14 +488,7 @@ class MediaDescriptor:
         return subtitleFileDescriptors
 
 
-    def importSubtitles(
+    def importSubtitles(self, searchDirectory, prefix, season: int = -1, episode: int = -1):
-        self,
-        searchDirectory,
-        prefix,
-        season: int = -1,
-        episode: int = -1,
-        preserve_dispositions: bool = False,
-    ):
         
         # click.echo(f"Season: {season} Episode: {episode}")
         self.__logger.debug(f"importSubtitles(): Season: {season} Episode: {episode}")
@@ -526,10 +507,7 @@ class MediaDescriptor:
                     d
                     for d in availableFileSubtitleDescriptors
                     if ((season == -1 and episode == -1)
-                        or (
+                        or (d["season"] == int(season) and d["episode"] == int(episode)))
-                            d.get("season") == int(season)
-                            and d.get("episode") == int(episode)
-                        ))
                 ],
                 key=lambda d: d["index"],
             )
@@ -544,14 +522,10 @@ class MediaDescriptor:
             if matchingSubtitleTrackDescriptor:
                 # click.echo(f"Found matching subtitle file {msfd["path"]}\n")
                 self.__logger.debug(f"importSubtitles(): Found matching subtitle file {msfd['path']}")
-                matchingTrack = matchingSubtitleTrackDescriptor[0]
+                matchingSubtitleTrackDescriptor[0].setExternalSourceFilePath(msfd["path"])
-                matchingTrack.setExternalSourceFilePath(msfd["path"])
 
-                # Prefer metadata coming from the external single-track source when
+                # TODO: Check if useful
-                # it is provided explicitly by the filename contract.
+                # matchingSubtitleTrackDescriptor[0].setDispositionSet(msfd["disposition_set"])
-                matchingTrack.getTags()["language"] = msfd["language"]
-                if msfd["disposition_set"] and not preserve_dispositions:
-                    matchingTrack.setDispositionSet(msfd["disposition_set"])
 
 
     def getConfiguration(self, label: str = ''):

src/ffx/media_descriptor_change_set.py

@@ -1,6 +1,5 @@
 import click
 
-from ffx.iso_language import IsoLanguage
 from ffx.media_descriptor import MediaDescriptor
 from ffx.track_descriptor import TrackDescriptor
 
@@ -43,14 +42,6 @@ class MediaDescriptorChangeSet():
 
         self.__targetTrackDescriptors = targetMediaDescriptor.getTrackDescriptors() if targetMediaDescriptor is not None else []
         self.__sourceTrackDescriptors = sourceMediaDescriptor.getTrackDescriptors() if sourceMediaDescriptor is not None else []
-        self.__targetTrackDescriptorsByIndex = {
-            trackDescriptor.getIndex(): trackDescriptor
-            for trackDescriptor in self.__targetTrackDescriptors
-        }
-        self.__sourceTrackDescriptorsByIndex = {
-            trackDescriptor.getIndex(): trackDescriptor
-            for trackDescriptor in self.__sourceTrackDescriptors
-        }
 
         targetMediaTags = targetMediaDescriptor.getTags() if targetMediaDescriptor is not None else {}
         sourceMediaTags = sourceMediaDescriptor.getTags() if sourceMediaDescriptor is not None else {}
@@ -79,34 +70,51 @@ class MediaDescriptorChangeSet():
         
         self.__numSourceTracks = len(self.__sourceTrackDescriptors)
 
+        maxNumOfTracks = max(self.__numSourceTracks, self.__numTargetTracks)
+
         trackCompareResult = {}
 
-        for targetTrackDescriptor in self.__targetTrackDescriptors:
-            sourceTrackDescriptor = self.__sourceTrackDescriptorsByIndex.get(
-                targetTrackDescriptor.getSourceIndex()
-            )
 
-            if sourceTrackDescriptor is None:
+        for trackIndex in range(maxNumOfTracks):
+
+            correspondingSourceTrackDescriptors = [st for st in self.__sourceTrackDescriptors if st.getIndex() == trackIndex]
+            correspondingTargetTrackDescriptors = [tt for tt in self.__targetTrackDescriptors if tt.getIndex() == trackIndex]
+
+            # Track present in target but not in source
+            if (not correspondingSourceTrackDescriptors
+                and correspondingTargetTrackDescriptors):
+
                 if DIFF_ADDED_KEY not in trackCompareResult.keys():
                     trackCompareResult[DIFF_ADDED_KEY] = {}
-                trackCompareResult[DIFF_ADDED_KEY][targetTrackDescriptor.getIndex()] = targetTrackDescriptor
+
+                trackCompareResult[DIFF_ADDED_KEY][trackIndex] = correspondingTargetTrackDescriptors[0]
                 continue
 
-            trackDiff = self.compareTracks(targetTrackDescriptor, sourceTrackDescriptor)
+            # Track present in target but not in source
+            if (correspondingSourceTrackDescriptors
+                and not correspondingTargetTrackDescriptors):
+
+                if DIFF_REMOVED_KEY not in trackCompareResult.keys():
+                    trackCompareResult[DIFF_REMOVED_KEY] = {}
+
+                trackCompareResult[DIFF_REMOVED_KEY][trackIndex] = correspondingSourceTrackDescriptors[0]
+                continue
+
+            if (correspondingSourceTrackDescriptors
+                and correspondingTargetTrackDescriptors):
+
+                # if correspondingTargetTrackDescriptors[0].getIndex() == 3:
+                #     raise click.ClickException(f"{correspondingSourceTrackDescriptors[0].getDispositionSet()} {correspondingTargetTrackDescriptors[0].getDispositionSet()}")
+
+
+                trackDiff = self.compareTracks(correspondingTargetTrackDescriptors[0],
+                                                correspondingSourceTrackDescriptors[0])
+
                 if trackDiff:
                     if DIFF_CHANGED_KEY not in trackCompareResult.keys():
                         trackCompareResult[DIFF_CHANGED_KEY] = {}
-                trackCompareResult[DIFF_CHANGED_KEY][targetTrackDescriptor.getIndex()] = trackDiff
 
-        targetSourceIndices = {
+                    trackCompareResult[DIFF_CHANGED_KEY][trackIndex] = trackDiff
-            targetTrackDescriptor.getSourceIndex()
-            for targetTrackDescriptor in self.__targetTrackDescriptors
-        }
-        for sourceTrackDescriptor in self.__sourceTrackDescriptors:
-            if sourceTrackDescriptor.getIndex() not in targetSourceIndices:
-                if DIFF_REMOVED_KEY not in trackCompareResult.keys():
-                    trackCompareResult[DIFF_REMOVED_KEY] = {}
-                trackCompareResult[DIFF_REMOVED_KEY][sourceTrackDescriptor.getIndex()] = sourceTrackDescriptor
 
 
         if trackCompareResult:
@@ -118,11 +126,7 @@ class MediaDescriptorChangeSet():
                 sourceTrackDescriptor: TrackDescriptor = None):
 
         sourceTrackTags = sourceTrackDescriptor.getTags() if sourceTrackDescriptor is not None else {}
-        targetTrackTags = (
+        targetTrackTags = targetTrackDescriptor.getTags() if targetTrackDescriptor is not None else {}
-            self.normalizeTrackTags(targetTrackDescriptor.getTags())
-            if targetTrackDescriptor is not None
-            else {}
-        )
 
         trackCompareResult = {}
 
@@ -147,25 +151,6 @@ class MediaDescriptorChangeSet():
 
         return trackCompareResult
 
-    def normalizeTrackTagValue(self, tagKey, tagValue):
-        if tagKey != "language":
-            return tagValue
-
-        if isinstance(tagValue, IsoLanguage):
-            return tagValue.threeLetter()
-
-        trackLanguage = IsoLanguage.findThreeLetter(str(tagValue))
-        if trackLanguage != IsoLanguage.UNDEFINED:
-            return trackLanguage.threeLetter()
-
-        return tagValue
-
-    def normalizeTrackTags(self, trackTags: dict):
-        return {
-            tagKey: self.normalizeTrackTagValue(tagKey, tagValue)
-            for tagKey, tagValue in trackTags.items()
-        }
-
 
     def generateDispositionTokens(self):
         """
@@ -267,7 +252,7 @@ class MediaDescriptorChangeSet():
                 addedTracks: dict = self.__changeSetObj[MediaDescriptorChangeSet.TRACKS_KEY][DIFF_ADDED_KEY]
                 trackDescriptor: TrackDescriptor
                 for trackDescriptor in addedTracks.values():
-                    for tagKey, tagValue in self.normalizeTrackTags(trackDescriptor.getTags()).items():
+                    for tagKey, tagValue in trackDescriptor.getTags().items():
                         if not tagKey in self.__removeTrackKeys:
                             metadataTokens += [f"-metadata:s:{trackDescriptor.getType().indicator()}"
                                                 + f":{trackDescriptor.getSubIndex()}",
@@ -289,58 +274,29 @@ class MediaDescriptorChangeSet():
 
                         outputTrackTags = addedTrackTags | changedTrackTags
 
-                        trackDescriptor = self.__targetTrackDescriptorsByIndex[trackIndex]
+                        trackDescriptor = self.__targetTrackDescriptors[trackIndex]
 
-                        for tagKey, tagValue in self.normalizeTrackTags(outputTrackTags).items():
+                        for tagKey, tagValue in outputTrackTags.items():
                             metadataTokens += [f"-metadata:s:{trackDescriptor.getType().indicator()}"
                                                 + f":{trackDescriptor.getSubIndex()}",
                                                 f"{tagKey}={tagValue}"]
 
-                        if trackDescriptor.getExternalSourceFilePath():
-                            # When a single-track external file substitutes the
-                            # media payload, keep metadata from the regular
-                            # source track unless the external/target side
-                            # overrides it explicitly.
-                            preservedTrackTags = (
-                                {
-                                    tagKey: tagValue
-                                    for tagKey, tagValue in removedTrackTags.items()
-                                    if tagKey not in self.__removeTrackKeys
-                                }
-                                | unchangedTrackTags
-                            )
-                            for tagKey, tagValue in self.normalizeTrackTags(preservedTrackTags).items():
-                                metadataTokens += [f"-metadata:s:{trackDescriptor.getType().indicator()}"
-                                                + f":{trackDescriptor.getSubIndex()}",
-                                                f"{tagKey}={tagValue}"]
-                        else:
                         for removeKey in removedTrackTags.keys():
                             metadataTokens += [f"-metadata:s:{trackDescriptor.getType().indicator()}"
                                                 + f":{trackDescriptor.getSubIndex()}",
                                                 f"{removeKey}="]
                             
-        for tagKey, tagValue in self.__context.get('encoding_metadata_tags', {}).items():
+                        #HINT: In case of loading a track from an external file
-            metadataTokens += [f"-metadata:g", f"{tagKey}={tagValue}"]
+                        # no tags from source are present for the track so
-
+                        # the unchanged tracks are passed to the output file as well
-        metadataTokens += self.generateConfiguredRemovalMetadataTokens()
+                        if trackDescriptor.getExternalSourceFilePath():
+                            for tagKey, tagValue in unchangedTrackTags.items():
+                                metadataTokens += [f"-metadata:s:{trackDescriptor.getType().indicator()}"
+                                                + f":{trackDescriptor.getSubIndex()}",
+                                                f"{tagKey}={tagValue}"]
 
         return metadataTokens
 
 
     def getChangeSetObj(self):
         return self.__changeSetObj
-
-    def generateConfiguredRemovalMetadataTokens(self):
-        metadataTokens = []
-
-        for removeKey in self.__removeGlobalKeys:
-            metadataTokens += ["-metadata:g", f"{removeKey}="]
-
-        for trackDescriptor in self.__targetTrackDescriptors:
-            for removeKey in self.__removeTrackKeys:
-                metadataTokens += [
-                    f"-metadata:s:{trackDescriptor.getType().indicator()}:{trackDescriptor.getSubIndex()}",
-                    f"{removeKey}=",
-                ]
-
-        return metadataTokens

src/ffx/media_details_screen.py

@@ -6,9 +6,13 @@ from textual.containers import Grid
 
 from ffx.audio_layout import AudioLayout
 
+from .pattern_controller import PatternController
+from .show_controller import ShowController
+from .track_controller import TrackController
+from .tag_controller import TagController
+
 from .show_details_screen import ShowDetailsScreen
 from .pattern_details_screen import PatternDetailsScreen
-from .screen_support import build_screen_bootstrap, build_screen_controllers
 
 from ffx.track_type import TrackType
 from ffx.track_codec import TrackCodec
@@ -131,23 +135,29 @@ class MediaDetailsScreen(Screen):
     def __init__(self):
         super().__init__()
 
-        bootstrap = build_screen_bootstrap(self.app.getContext())
+        self.context = self.app.getContext()
-        self.context = bootstrap.context
+        self.Session = self.context['database']['session'] # convenience
 
-        self.__removeGlobalKeys = bootstrap.remove_global_keys
-        self.__ignoreGlobalKeys = bootstrap.ignore_global_keys
 
-        controllers = build_screen_controllers(
+        self.__configurationData = self.context['config'].getData()
-            self.context,
+
-            pattern=True,
+        metadataConfiguration = self.__configurationData['metadata'] if 'metadata' in self.__configurationData.keys() else {}
-            show=True,
+
-            track=True,
+        self.__signatureTags = metadataConfiguration['signature'] if 'signature' in metadataConfiguration.keys() else {}
-            tag=True,
+        self.__removeGlobalKeys = metadataConfiguration['remove'] if 'remove' in metadataConfiguration.keys() else []
-        )
+        self.__ignoreGlobalKeys = metadataConfiguration['ignore'] if 'ignore' in metadataConfiguration.keys() else []
-        self.__pc = controllers['pattern']
+        self.__removeTrackKeys = (metadataConfiguration['streams']['remove']
-        self.__sc = controllers['show']
+                                    if 'streams' in metadataConfiguration.keys()
-        self.__tc = controllers['track']
+                                    and 'remove' in metadataConfiguration['streams'].keys() else [])
-        self.__tac = controllers['tag']
+        self.__ignoreTrackKeys = (metadataConfiguration['streams']['ignore']
+                                    if 'streams' in metadataConfiguration.keys()
+                                    and 'ignore' in metadataConfiguration['streams'].keys() else [])
+
+
+        self.__pc = PatternController(context = self.context)
+        self.__sc = ShowController(context = self.context)
+        self.__tc = TrackController(context = self.context)
+        self.__tac = TagController(context = self.context)
 
         if not 'command' in self.context.keys() or self.context['command'] != 'inspect':
             raise click.ClickException(f"MediaDetailsScreen.__init__(): Can only perform command 'inspect'")
@@ -559,7 +569,6 @@ class MediaDetailsScreen(Screen):
                 try:
                     kwargs = {}
 
-                    kwargs[ShowDescriptor.CONTEXT_KEY] = self.context
                     kwargs[ShowDescriptor.ID_KEY] = int(selected_row_data[0])                    
                     kwargs[ShowDescriptor.NAME_KEY] = str(selected_row_data[1])
                     kwargs[ShowDescriptor.YEAR_KEY] = int(selected_row_data[2])
@@ -593,20 +602,19 @@ class MediaDetailsScreen(Screen):
         patternObj = self.getPatternObjFromInput()
         
         if patternObj:
-            mediaTags = {}
+            patternId = self.__pc.addPattern(patternObj)
+            if patternId:
+                self.highlightPattern(False)
+
                 for tagKey, tagValue in self.__sourceMediaDescriptor.getTags().items():
 
                     # Filter tags that make no sense to preserve
                     if tagKey not in self.__ignoreGlobalKeys and not tagKey in self.__removeGlobalKeys:
-                    mediaTags[tagKey] = tagValue
+                        self.__tac.updateMediaTag(patternId, tagKey, tagValue)
 
-            patternId = self.__pc.savePatternSchema(
+                # for trackDescriptor in self.__sourceMediaDescriptor.getAllTrackDescriptors():
-                patternObj,
+                for trackDescriptor in self.__sourceMediaDescriptor.getTrackDescriptors():
-                trackDescriptors=self.__sourceMediaDescriptor.getTrackDescriptors(),
+                    self.__tc.addTrack(trackDescriptor, patternId = patternId)
-                mediaTags=mediaTags,
-            )
-            if patternId:
-                self.highlightPattern(False)
 
 
     def action_new_pattern(self):
@@ -746,3 +754,4 @@ class MediaDetailsScreen(Screen):
     def handle_edit_pattern(self, screenResult):
         self.query_one("#pattern_input", Input).value = screenResult['pattern']
         self.updateDifferences()
+

src/ffx/model/__init__.py

@@ -1,20 +0,0 @@
-"""Load ORM model modules so SQLAlchemy relationship strings can resolve."""
-
-from .show import Base, Show
-from .pattern import Pattern
-from .track import Track
-from .track_tag import TrackTag
-from .media_tag import MediaTag
-from .shifted_season import ShiftedSeason
-from .property import Property
-
-__all__ = [
-    'Base',
-    'Show',
-    'Pattern',
-    'Track',
-    'TrackTag',
-    'MediaTag',
-    'ShiftedSeason',
-    'Property',
-]

src/ffx/model/conversions/conversion.py

@@ -0,0 +1,47 @@
+import os, sys, importlib, inspect, glob, re
+
+from ffx.configuration_controller import ConfigurationController
+from ffx.database import databaseContext
+
+from sqlalchemy import Engine
+from sqlalchemy.orm import sessionmaker
+
+
+class Conversion():
+
+    def __init__(self):
+
+        self._context = {}
+        self._context['config'] = ConfigurationController()
+
+        self._context['database'] = databaseContext(databasePath=self._context['config'].getDatabaseFilePath())
+
+        self.__databaseSession: sessionmaker = self._context['database']['session']
+        self.__databaseEngine: Engine = self._context['database']['engine']
+
+
+    @staticmethod    
+    def list():
+
+        basePath = os.path.dirname(__file__)
+
+        filenamePattern = re.compile("conversion_([0-9]+)_([0-9]+)\\.py")
+
+        filenameList = [os.path.basename(fp) for fp in glob.glob(f"{ basePath }/*.py") if fp != __file__]
+
+        versionTupleList = [(fm.group(1), fm.group(2)) for fn in filenameList if (fm := filenamePattern.search(fn))]
+
+        return versionTupleList
+
+
+    @staticmethod
+    def getClassReference(versionFrom, versionTo):
+        importlib.import_module(f"ffx.model.conversions.conversion_{ versionFrom }_{ versionTo }")
+        for name, obj in inspect.getmembers(sys.modules[f"ffx.model.conversions.conversion_{ versionFrom }_{ versionTo }"]):
+            #HINT: Excluding DispositionCombination as it seems to be included by import (?)
+            if inspect.isclass(obj) and name != 'Conversion' and name.startswith('Conversion'):
+                return obj
+
+    @staticmethod
+    def getAllClassReferences():
+        return [Conversion.getClassReference(verFrom, verTo) for verFrom, verTo in Conversion.list()]

src/ffx/model/conversions/conversion_2_3.py

@@ -0,0 +1,17 @@
+import os, sys, importlib, inspect, glob, re
+
+from .conversion import Conversion
+
+
+class Conversion_2_3(Conversion):
+    
+    def __init__(self):
+        super().__init__()
+
+    def applyConversion(self):
+
+        s = self.__databaseSession()
+        e = self.__databaseEngine
+
+        with e.connect() as c:
+            c.execute("ALTER TABLE user ADD COLUMN email VARCHAR(255)")

src/ffx/model/conversions/conversion_3_4.py

@@ -0,0 +1,7 @@
+import os, sys, importlib, inspect, glob, re
+
+from .conversion import Conversion
+
+
+class Conversion_3_4(Conversion):
+    pass

src/ffx/model/migration/__init__.py

@@ -1,82 +0,0 @@
-from __future__ import annotations
-
-from dataclasses import dataclass
-import importlib
-import importlib.util
-
-
-class DatabaseVersionException(Exception):
-    def __init__(self, errorMessage):
-        super().__init__(errorMessage)
-
-
-@dataclass(frozen=True)
-class MigrationStep:
-    versionFrom: int
-    versionTo: int
-    moduleName: str
-    modulePresent: bool
-
-
-def getMigrationStepModuleName(versionFrom: int, versionTo: int) -> str:
-    return f"ffx.model.migration.step_{int(versionFrom)}_{int(versionTo)}"
-
-
-def migrationStepModuleExists(versionFrom: int, versionTo: int) -> bool:
-    moduleName = getMigrationStepModuleName(versionFrom, versionTo)
-
-    try:
-        return importlib.util.find_spec(moduleName) is not None
-    except ModuleNotFoundError:
-        return False
-
-
-def getMigrationPlan(currentVersion: int, targetVersion: int) -> list[MigrationStep]:
-    version = int(currentVersion)
-    target = int(targetVersion)
-    migrationPlan = []
-
-    while version < target:
-        nextVersion = version + 1
-        migrationPlan.append(
-            MigrationStep(
-                versionFrom=version,
-                versionTo=nextVersion,
-                moduleName=getMigrationStepModuleName(version, nextVersion),
-                modulePresent=migrationStepModuleExists(version, nextVersion),
-            )
-        )
-        version = nextVersion
-
-    return migrationPlan
-
-
-def loadMigrationStep(versionFrom: int, versionTo: int):
-    moduleName = getMigrationStepModuleName(versionFrom, versionTo)
-
-    try:
-        module = importlib.import_module(moduleName)
-    except ModuleNotFoundError as ex:
-        if ex.name == moduleName:
-            raise DatabaseVersionException(
-                f"No migration path from database version {versionFrom} to {versionTo}"
-            ) from ex
-        raise
-
-    migrationStep = getattr(module, "applyMigration", None)
-    if migrationStep is None:
-        raise DatabaseVersionException(
-            f"Migration module {moduleName} does not define applyMigration()"
-        )
-
-    return migrationStep
-
-
-def migrateDatabase(databaseContext, currentVersion: int, targetVersion: int, setDatabaseVersion):
-    for migrationStepInfo in getMigrationPlan(currentVersion, targetVersion):
-        migrationStep = loadMigrationStep(
-            migrationStepInfo.versionFrom,
-            migrationStepInfo.versionTo,
-        )
-        migrationStep(databaseContext)
-        setDatabaseVersion(databaseContext, migrationStepInfo.versionTo)

src/ffx/model/migration/step_2_3.py

@@ -1,84 +0,0 @@
-from sqlalchemy import inspect, text
-
-
-def applyMigration(databaseContext):
-    engine = databaseContext['engine']
-    inspector = inspect(engine)
-    shiftedSeasonColumns = {
-        column['name']
-        for column in inspector.get_columns('shifted_seasons')
-    }
-    showColumns = {
-        column['name']
-        for column in inspector.get_columns('shows')
-    }
-
-    with engine.begin() as connection:
-        if 'pattern_id' not in shiftedSeasonColumns:
-            connection.execute(text("PRAGMA foreign_keys=OFF"))
-            connection.execute(
-                text(
-                    """
-                    CREATE TABLE shifted_seasons_v3 (
-                        id INTEGER PRIMARY KEY,
-                        show_id INTEGER,
-                        pattern_id INTEGER,
-                        original_season INTEGER,
-                        first_episode INTEGER DEFAULT -1,
-                        last_episode INTEGER DEFAULT -1,
-                        season_offset INTEGER DEFAULT 0,
-                        episode_offset INTEGER DEFAULT 0,
-                        FOREIGN KEY(show_id) REFERENCES shows(id) ON DELETE CASCADE,
-                        FOREIGN KEY(pattern_id) REFERENCES patterns(id) ON DELETE CASCADE,
-                        CHECK (
-                            (show_id IS NOT NULL AND pattern_id IS NULL)
-                            OR (show_id IS NULL AND pattern_id IS NOT NULL)
-                        )
-                    )
-                    """
-                )
-            )
-            connection.execute(
-                text(
-                    """
-                    INSERT INTO shifted_seasons_v3 (
-                        id,
-                        show_id,
-                        pattern_id,
-                        original_season,
-                        first_episode,
-                        last_episode,
-                        season_offset,
-                        episode_offset
-                    )
-                    SELECT
-                        id,
-                        show_id,
-                        NULL,
-                        original_season,
-                        first_episode,
-                        last_episode,
-                        season_offset,
-                        episode_offset
-                    FROM shifted_seasons
-                    """
-                )
-            )
-            connection.execute(text("DROP TABLE shifted_seasons"))
-            connection.execute(text("ALTER TABLE shifted_seasons_v3 RENAME TO shifted_seasons"))
-            connection.execute(
-                text("CREATE INDEX ix_shifted_seasons_show_id ON shifted_seasons(show_id)")
-            )
-            connection.execute(
-                text("CREATE INDEX ix_shifted_seasons_pattern_id ON shifted_seasons(pattern_id)")
-            )
-            connection.execute(text("PRAGMA foreign_keys=ON"))
-
-        if 'quality' not in showColumns:
-            connection.execute(
-                text("ALTER TABLE shows ADD COLUMN quality INTEGER DEFAULT 0")
-            )
-        if 'notes' not in showColumns:
-            connection.execute(
-                text("ALTER TABLE shows ADD COLUMN notes TEXT DEFAULT ''")
-            )

src/ffx/model/pattern.py

@@ -1,6 +1,6 @@
 import click
 
-from sqlalchemy import Column, Integer, String, Text, ForeignKey, UniqueConstraint
+from sqlalchemy import Column, Integer, String, Text, ForeignKey
 from sqlalchemy.orm import relationship
 
 from .show import Base, Show
@@ -12,9 +12,6 @@ from ffx.show_descriptor import ShowDescriptor
 class Pattern(Base):
 
     __tablename__ = 'patterns'
-    __table_args__ = (
-        UniqueConstraint('show_id', 'pattern', name='uq_patterns_show_id_pattern'),
-    )
 
     # v1.x
     id = Column(Integer, primary_key=True)
@@ -35,7 +32,6 @@ class Pattern(Base):
     tracks = relationship('Track', back_populates='pattern', cascade="all, delete", lazy='joined')
 
     media_tags = relationship('MediaTag', back_populates='pattern', cascade="all, delete", lazy='joined')
-    shifted_seasons = relationship('ShiftedSeason', back_populates='pattern', cascade="all, delete", lazy='joined')
 
     quality = Column(Integer, default=0)
 

src/ffx/model/shifted_season.py

@@ -1,6 +1,6 @@
 import click
 
-from sqlalchemy import CheckConstraint, Column, ForeignKey, Index, Integer
+from sqlalchemy import Column, Integer, ForeignKey
 from sqlalchemy.orm import relationship
 
 from .show import Base, Show
@@ -9,14 +9,6 @@ from .show import Base, Show
 class ShiftedSeason(Base):
 
     __tablename__ = 'shifted_seasons'
-    __table_args__ = (
-        CheckConstraint(
-            "(show_id IS NOT NULL AND pattern_id IS NULL) OR (show_id IS NULL AND pattern_id IS NOT NULL)",
-            name="ck_shifted_seasons_single_owner",
-        ),
-        Index("ix_shifted_seasons_show_id", "show_id"),
-        Index("ix_shifted_seasons_pattern_id", "pattern_id"),
-    )
 
     # v1.x
     id = Column(Integer, primary_key=True)
@@ -27,12 +19,9 @@ class ShiftedSeason(Base):
     # pattern: Mapped[str] = mapped_column(String, nullable=False)
 
     # v1.x
-    show_id = Column(Integer, ForeignKey('shows.id', ondelete="CASCADE"), nullable=True)
+    show_id = Column(Integer, ForeignKey('shows.id', ondelete="CASCADE"))
     show = relationship(Show, back_populates='shifted_seasons', lazy='joined')
 
-    pattern_id = Column(Integer, ForeignKey('patterns.id', ondelete="CASCADE"), nullable=True)
-    pattern = relationship('Pattern', back_populates='shifted_seasons', lazy='joined')
-
     # v2.0
     # show_id: Mapped[int] = mapped_column(ForeignKey("shows.id", ondelete="CASCADE"))
     # show: Mapped["Show"] = relationship(back_populates="patterns")
@@ -50,12 +39,6 @@ class ShiftedSeason(Base):
     def getId(self):
         return self.id
 
-    def getShowId(self):
-        return self.show_id
-
-    def getPatternId(self):
-        return self.pattern_id
-
 
     def getOriginalSeason(self):
         return self.original_season
@@ -78,8 +61,6 @@ class ShiftedSeason(Base):
 
         shiftedSeasonObj = {}
 
-        shiftedSeasonObj['show_id'] = self.getShowId()
-        shiftedSeasonObj['pattern_id'] = self.getPatternId()
         shiftedSeasonObj['original_season'] = self.getOriginalSeason()
         shiftedSeasonObj['first_episode'] = self.getFirstEpisode()
         shiftedSeasonObj['last_episode'] = self.getLastEpisode()
@@ -87,3 +68,4 @@ class ShiftedSeason(Base):
         shiftedSeasonObj['episode_offset'] = self.getEpisodeOffset()
 
         return shiftedSeasonObj
+

src/ffx/model/show.py

@@ -1,5 +1,5 @@
 # from typing import List
-from sqlalchemy import create_engine, Column, Integer, String, Text, ForeignKey
+from sqlalchemy import create_engine, Column, Integer, String, ForeignKey
 from sqlalchemy.orm import relationship, declarative_base, sessionmaker
 
 from ffx.show_descriptor import ShowDescriptor
@@ -45,8 +45,6 @@ class Show(Base):
     index_episode_digits = Column(Integer, default=ShowDescriptor.DEFAULT_INDEX_EPISODE_DIGITS)
     indicator_season_digits = Column(Integer, default=ShowDescriptor.DEFAULT_INDICATOR_SEASON_DIGITS)
     indicator_episode_digits = Column(Integer, default=ShowDescriptor.DEFAULT_INDICATOR_EPISODE_DIGITS)
-    quality = Column(Integer, default=0)
-    notes = Column(Text, default='')
 
 
     def getDescriptor(self, context):
@@ -60,7 +58,5 @@ class Show(Base):
         kwargs[ShowDescriptor.INDEX_EPISODE_DIGITS_KEY] = int(self.index_episode_digits)
         kwargs[ShowDescriptor.INDICATOR_SEASON_DIGITS_KEY] = int(self.indicator_season_digits)
         kwargs[ShowDescriptor.INDICATOR_EPISODE_DIGITS_KEY] = int(self.indicator_episode_digits)
-        kwargs[ShowDescriptor.QUALITY_KEY] = int(self.quality or 0)
-        kwargs[ShowDescriptor.NOTES_KEY] = str(self.notes or '')
         
         return ShowDescriptor(**kwargs)

src/ffx/pattern_controller.py

@@ -1,411 +1,161 @@
-import re
+import click, re
 
-import click
-
-from ffx.model.media_tag import MediaTag
 from ffx.model.pattern import Pattern
-from ffx.model.track import Track
-from ffx.model.track_tag import TrackTag
-from ffx.track_descriptor import TrackDescriptor
-from ffx.track_disposition import TrackDisposition
 
 
-class DuplicatePatternMatchError(click.ClickException):
+class PatternController():
-    pass
-
-
-class InvalidPatternSchemaError(click.ClickException):
-    pass
-
-
-class PatternController:
-    _compiled_regex_cache: dict[str, re.Pattern] = {}
     
     def __init__(self, context):
         
         self.context = context
-        self.Session = self.context["database"]["session"]
+        self.Session = self.context['database']['session'] # convenience
 
-        self.__configurationData = self.context["config"].getData()
 
-        metadataConfiguration = (
+    def addPattern(self, patternObj):
-            self.__configurationData["metadata"]
+        """Adds pattern to database from obj
-            if "metadata" in self.__configurationData.keys()
-            else {}
-        )
         
-        self.__removeTrackKeys = (
+        Returns database id or 0 if pattern already exists"""
-            metadataConfiguration["streams"]["remove"]
-            if "streams" in metadataConfiguration.keys()
-            and "remove" in metadataConfiguration["streams"].keys()
-            else []
-        )
-        self.__ignoreTrackKeys = (
-            metadataConfiguration["streams"]["ignore"]
-            if "streams" in metadataConfiguration.keys()
-            and "ignore" in metadataConfiguration["streams"].keys()
-            else []
-        )
-
-    @classmethod
-    def _clear_regex_cache(cls):
-        cls._compiled_regex_cache.clear()
-
-    @classmethod
-    def _compile_pattern_expression(cls, pattern_id: int, expression: str) -> re.Pattern:
-        expression_text = str(expression)
-        compiled = cls._compiled_regex_cache.get(expression_text)
-        if compiled is None:
-            try:
-                compiled = re.compile(expression_text)
-            except re.error as ex:
-                raise click.ClickException(
-                    f"Pattern #{pattern_id} contains an invalid regex {expression_text!r}: {ex}"
-                )
-            cls._compiled_regex_cache[expression_text] = compiled
-        return compiled
-
-    def _coerce_pattern_fields(self, patternObj):
-        return {
-            "show_id": int(patternObj["show_id"]),
-            "pattern": str(patternObj["pattern"]),
-            "quality": int(patternObj.get("quality", 0) or 0),
-            "notes": str(patternObj.get("notes", "")),
-        }
-
-    def _coerce_media_tags(self, mediaTags):
-        return {
-            str(tagKey): str(tagValue)
-            for tagKey, tagValue in (mediaTags or {}).items()
-        }
-
-    def _normalize_track_descriptors(self, trackDescriptors):
-        if trackDescriptors is None:
-            raise InvalidPatternSchemaError(
-                "Patterns must define at least one track before they can be stored."
-            )
-
-        normalized_descriptors = []
-        for trackDescriptor in trackDescriptors:
-            if type(trackDescriptor) is not TrackDescriptor:
-                raise TypeError(
-                    "PatternController: All track descriptors are required to be of type TrackDescriptor"
-                )
-            normalized_descriptors.append(trackDescriptor)
-
-        if not normalized_descriptors:
-            raise InvalidPatternSchemaError(
-                "Patterns must define at least one track before they can be stored."
-            )
-
-        normalized_descriptors = sorted(
-            normalized_descriptors, key=lambda descriptor: descriptor.getIndex()
-        )
-
-        index_set = {descriptor.getIndex() for descriptor in normalized_descriptors}
-        expected_indexes = set(range(len(normalized_descriptors)))
-        if index_set != expected_indexes:
-            raise click.ClickException(
-                "Pattern tracks must use a contiguous zero-based index order."
-            )
-
-        return normalized_descriptors
-
-    def _ensure_unique_pattern_definition(
-        self,
-        session,
-        show_id: int,
-        pattern_expression: str,
-        exclude_pattern_id: int | None = None,
-    ):
-        query = session.query(Pattern).filter(
-            Pattern.show_id == show_id,
-            Pattern.pattern == pattern_expression,
-        )
-        if exclude_pattern_id is not None:
-            query = query.filter(Pattern.id != int(exclude_pattern_id))
-
-        existing_pattern = query.first()
-        if existing_pattern is not None:
-            raise click.ClickException(
-                f"Pattern {pattern_expression!r} already exists for show #{show_id}."
-            )
-
-    def _build_track_row(self, trackDescriptor: TrackDescriptor) -> Track:
-        track = Track(
-            track_type=int(trackDescriptor.getType().index()),
-            codec_name=str(trackDescriptor.getCodec().identifier()),
-            index=int(trackDescriptor.getIndex()),
-            source_index=int(trackDescriptor.getSourceIndex()),
-            disposition_flags=int(
-                TrackDisposition.toFlags(trackDescriptor.getDispositionSet())
-            ),
-            audio_layout=trackDescriptor.getAudioLayout().index(),
-        )
-
-        for tagKey, tagValue in trackDescriptor.getTags().items():
-            if tagKey in self.__ignoreTrackKeys or tagKey in self.__removeTrackKeys:
-                continue
-            track.track_tags.append(TrackTag(key=str(tagKey), value=str(tagValue)))
-
-        return track
-
-    def _replace_pattern_schema(
-        self,
-        session,
-        pattern: Pattern,
-        mediaTags: dict[str, str],
-        trackDescriptors: list[TrackDescriptor],
-    ):
-        for mediaTag in list(pattern.media_tags):
-            session.delete(mediaTag)
-        for track in list(pattern.tracks):
-            session.delete(track)
-        session.flush()
-
-        for tagKey, tagValue in mediaTags.items():
-            pattern.media_tags.append(MediaTag(key=str(tagKey), value=str(tagValue)))
-
-        for trackDescriptor in trackDescriptors:
-            pattern.tracks.append(self._build_track_row(trackDescriptor))
-
-    def _validate_persisted_pattern(self, pattern: Pattern):
-        if not pattern.tracks:
-            raise InvalidPatternSchemaError(
-                f"Pattern #{pattern.getId()} ({pattern.getPattern()!r}) is invalid because it has no tracks."
-            )
-
-    def savePatternSchema(
-        self,
-        patternObj,
-        trackDescriptors,
-        mediaTags=None,
-        patternId: int | None = None,
-    ) -> int:
-        fields = self._coerce_pattern_fields(patternObj)
-        normalized_tracks = self._normalize_track_descriptors(trackDescriptors)
-        normalized_tags = self._coerce_media_tags(mediaTags)
-        session = None
 
         try:
-            session = self.Session()
-            self._ensure_unique_pattern_definition(
-                session,
-                fields["show_id"],
-                fields["pattern"],
-                exclude_pattern_id=patternId,
-            )
 
-            if patternId is None:
+            s = self.Session()
-                pattern = Pattern(
+            q = s.query(Pattern).filter(Pattern.show_id == int(patternObj['show_id']),
-                    show_id=fields["show_id"],
+                                        Pattern.pattern == str(patternObj['pattern']))
-                    pattern=fields["pattern"],
-                    quality=fields["quality"],
-                    notes=fields["notes"],
-                )
-                session.add(pattern)
-                session.flush()
-            else:
-                pattern = session.query(Pattern).filter(Pattern.id == int(patternId)).first()
-                if pattern is None:
-                    raise click.ClickException(
-                        f"PatternController.savePatternSchema(): Pattern #{patternId} not found"
-                    )
-                pattern.show_id = fields["show_id"]
-                pattern.pattern = fields["pattern"]
-                pattern.quality = fields["quality"]
-                pattern.notes = fields["notes"]
 
-            self._replace_pattern_schema(
+            if not q.count():
-                session,
+                pattern = Pattern(show_id = int(patternObj['show_id']),
-                pattern,
+                                    pattern = str(patternObj['pattern']))
-                normalized_tags,
+                s.add(pattern)
-                normalized_tracks,
+                s.commit()
-            )
-
-            session.commit()
-            self._clear_regex_cache()
                 return pattern.getId()
+            else:
+                return 0
 
-        except click.ClickException:
-            raise
         except Exception as ex:
-            raise click.ClickException(
+            raise click.ClickException(f"PatternController.addPattern(): {repr(ex)}")
-                f"PatternController.savePatternSchema(): {repr(ex)}"
-            )
         finally:
-            if session is not None:
+            s.close()
-                session.close()
 
-    def addPattern(self, patternObj, trackDescriptors=None, mediaTags=None):
-        return self.savePatternSchema(
-            patternObj,
-            trackDescriptors=trackDescriptors,
-            mediaTags=mediaTags,
-        )
 
     def updatePattern(self, patternId, patternObj):
 
-        fields = self._coerce_pattern_fields(patternObj)
-        session = None
-
         try:
-            session = self.Session()
+            s = self.Session()
-            pattern = session.query(Pattern).filter(Pattern.id == int(patternId)).first()
+            q = s.query(Pattern).filter(Pattern.id == int(patternId))
 
-            if pattern is not None:
+            if q.count():
-                self._ensure_unique_pattern_definition(
-                    session,
-                    fields["show_id"],
-                    fields["pattern"],
-                    exclude_pattern_id=patternId,
-                )
-                self._validate_persisted_pattern(pattern)
 
-                pattern.show_id = fields["show_id"]
+                pattern: Pattern = q.first()
-                pattern.pattern = fields["pattern"]
-                pattern.quality = fields["quality"]
-                pattern.notes = fields["notes"]
 
-                session.commit()
+                pattern.show_id = int(patternObj['show_id'])
-                self._clear_regex_cache()
+                pattern.pattern = str(patternObj['pattern'])
+                pattern.quality = str(patternObj['quality'])
+                pattern.notes = str(patternObj['notes'])
+
+                s.commit()
                 return True
 
+            else:
                 return False
 
-        except click.ClickException:
-            raise
         except Exception as ex:
             raise click.ClickException(f"PatternController.updatePattern(): {repr(ex)}")
         finally:
-            if session is not None:
+            s.close()
-                session.close()
+
+
 
     def findPattern(self, patternObj):
-        session = None
         
         try:
-            session = self.Session()
+            s = self.Session()
-            pattern = (
+            q = s.query(Pattern).filter(Pattern.show_id == int(patternObj['show_id']), Pattern.pattern == str(patternObj['pattern']))
-                session.query(Pattern)
-                .filter(
-                    Pattern.show_id == int(patternObj["show_id"]),
-                    Pattern.pattern == str(patternObj["pattern"]),
-                )
-                .first()
-            )
 
-            if pattern is not None:
+            if q.count():
+                pattern = q.first()
                 return int(pattern.id)
+            else:
                 return None
 
         except Exception as ex:
             raise click.ClickException(f"PatternController.findPattern(): {repr(ex)}")
         finally:
-            if session is not None:
+            s.close()
-                session.close()
 
-    def getPatternsForShow(self, showId: int) -> list[Pattern]:
 
-        if type(showId) is not int:
+    def getPattern(self, patternId : int):
-            raise ValueError(
-                "PatternController.getPatternsForShow(): Argument showId is required to be of type int"
-            )
-
-        session = None
-        try:
-            session = self.Session()
-            return (
-                session.query(Pattern)
-                .filter(Pattern.show_id == int(showId))
-                .order_by(Pattern.id)
-                .all()
-            )
-
-        except Exception as ex:
-            raise click.ClickException(f"PatternController.getPatternsForShow(): {repr(ex)}")
-        finally:
-            if session is not None:
-                session.close()
-
-    def getPattern(self, patternId: int):
 
         if type(patternId) is not int:
-            raise ValueError(
+            raise ValueError(f"PatternController.getPattern(): Argument patternId is required to be of type int")
-                "PatternController.getPattern(): Argument patternId is required to be of type int"
-            )
 
-        session = None
         try:
-            session = self.Session()
+            s = self.Session()
-            return session.query(Pattern).filter(Pattern.id == int(patternId)).first()
+            q = s.query(Pattern).filter(Pattern.id == int(patternId))
+
+            return q.first() if q.count() else None
 
         except Exception as ex:
             raise click.ClickException(f"PatternController.getPattern(): {repr(ex)}")
         finally:
-            if session is not None:
+            s.close()
-                session.close()
+
 
     def deletePattern(self, patternId):
-        session = None
         try:
-            session = self.Session()
+            s = self.Session()
-            pattern = session.query(Pattern).filter(Pattern.id == int(patternId)).first()
+            q = s.query(Pattern).filter(Pattern.id == int(patternId))
 
-            if pattern is not None:
+            if q.count():
-                session.delete(pattern)
+
-                session.commit()
+                #DAFUQ: https://stackoverflow.com/a/19245058
-                self._clear_regex_cache()
+                # q.delete()
+                pattern = q.first()
+                s.delete(pattern)
+
+                s.commit()
                 return True
             return False
 
         except Exception as ex:
             raise click.ClickException(f"PatternController.deletePattern(): {repr(ex)}")
         finally:
-            if session is not None:
+            s.close()
-                session.close()
 
-    def matchFilename(self, filename: str) -> dict:
+
-        """Return {'match': regex match, 'pattern': Pattern} or {} when unmatched."""
+    def matchFilename(self, filename : str) -> dict:
-        session = None
+        """Returns dict {'match': <a regex match obj>, 'pattern': <ffx pattern obj>} or empty dict of no pattern was found"""
 
         try:
-            session = self.Session()
+            s = self.Session()
-            matches = []
+            q = s.query(Pattern)
-            query = session.query(Pattern).order_by(Pattern.show_id, Pattern.id)
 
-            for pattern in query.all():
+            matchResult = {}
-                compiled = self._compile_pattern_expression(
-                    pattern.getId(),
-                    pattern.getPattern(),
-                )
-                patternMatch = compiled.search(str(filename))
-                if patternMatch is None:
-                    continue
             
-                self._validate_persisted_pattern(pattern)
+            for pattern in q.all():
-                matches.append({"match": patternMatch, "pattern": pattern})
+                patternMatch = re.search(str(pattern.pattern), str(filename))
+                if patternMatch is not None:
+                    matchResult['match'] = patternMatch
+                    matchResult['pattern'] = pattern
 
-            if not matches:
+            return matchResult
-                return {}
             
-            if len(matches) > 1:
-                duplicateDescriptions = ", ".join(
-                    [
-                        f"show #{match['pattern'].getShowId()} pattern #{match['pattern'].getId()} {match['pattern'].getPattern()!r}"
-                        for match in matches
-                    ]
-                )
-                raise DuplicatePatternMatchError(
-                    f"Filename {filename!r} matched more than one pattern: {duplicateDescriptions}"
-                )
-
-            return matches[0]
-
-        except click.ClickException:
-            raise
         except Exception as ex:
             raise click.ClickException(f"PatternController.matchFilename(): {repr(ex)}")
         finally:
-            if session is not None:
+            s.close()
-                session.close()
+
+#    def getMediaDescriptor(self, context, patternId):
+#
+#        try:
+#            s = self.Session()
+#            q = s.query(Pattern).filter(Pattern.id == int(patternId))
+#
+#            if q.count():
+#                return q.first().getMediaDescriptor(context)
+#            else:
+#                return None
+#
+#        except Exception as ex:
+#            raise click.ClickException(f"PatternController.getMediaDescriptor(): {repr(ex)}")
+#        finally:
+#            s.close()

src/ffx/pattern_details_screen.py

@@ -6,15 +6,18 @@ from textual.widgets import Header, Footer, Static, Button, Input, DataTable, Te
 from textual.containers import Grid
 
 from ffx.model.pattern import Pattern
+from ffx.model.track import Track
+
+from .pattern_controller import PatternController
+from .show_controller import ShowController
+from .track_controller import TrackController
+from .tag_controller import TagController
 
 from .track_details_screen import TrackDetailsScreen
 from .track_delete_screen import TrackDeleteScreen
-from .shifted_season_delete_screen import ShiftedSeasonDeleteScreen
-from .shifted_season_details_screen import ShiftedSeasonDetailsScreen
 
 from .tag_details_screen import TagDetailsScreen
 from .tag_delete_screen import TagDeleteScreen
-from .screen_support import build_screen_bootstrap, build_screen_controllers
 
 from ffx.track_type import TrackType
 
@@ -26,7 +29,6 @@ from textual.widgets._data_table import CellDoesNotExist
 from ffx.file_properties import FileProperties
 from ffx.iso_language import IsoLanguage
 from ffx.audio_layout import AudioLayout
-from ffx.model.shifted_season import ShiftedSeason
 
 from ffx.helper import formatRichColor, removeRichColor
 
@@ -37,8 +39,8 @@ class PatternDetailsScreen(Screen):
     CSS = """
 
     Grid {
-        grid-size: 7 20;
+        grid-size: 7 17;
-        grid-rows: 2 2 2 2 2 2 6 2 2 8 2 2 8 2 2 8 2 2 2 2;
+        grid-rows: 2 2 2 2 2 2 6 2 2 8 2 2 8 2 2 2 2;
         grid-columns: 25 25 25 25 25 25 25;
         height: 100%;
         width: 100%;
@@ -106,42 +108,66 @@ class PatternDetailsScreen(Screen):
     def __init__(self, patternId = None, showId = None):
         super().__init__()
 
-        bootstrap = build_screen_bootstrap(self.app.getContext())
+        self.context = self.app.getContext()
-        self.context = bootstrap.context
+        self.Session = self.context['database']['session'] # convenience
 
-        self.__removeGlobalKeys = bootstrap.remove_global_keys
+        self.__configurationData = self.context['config'].getData()
-        self.__ignoreGlobalKeys = bootstrap.ignore_global_keys
 
-        controllers = build_screen_controllers(
+        metadataConfiguration = self.__configurationData['metadata'] if 'metadata' in self.__configurationData.keys() else {}
-            self.context,
+
-            pattern=True,
+        self.__signatureTags = metadataConfiguration['signature'] if 'signature' in metadataConfiguration.keys() else {}
-            show=True,
+        self.__removeGlobalKeys = metadataConfiguration['remove'] if 'remove' in metadataConfiguration.keys() else []
-            track=True,
+        self.__ignoreGlobalKeys = metadataConfiguration['ignore'] if 'ignore' in metadataConfiguration.keys() else []
-            tag=True,
+        self.__removeTrackKeys = (metadataConfiguration['streams']['remove']
-            shifted_season=True,
+                                    if 'streams' in metadataConfiguration.keys()
-        )
+                                    and 'remove' in metadataConfiguration['streams'].keys() else [])
-        self.__pc = controllers['pattern']
+        self.__ignoreTrackKeys = (metadataConfiguration['streams']['ignore']
-        self.__sc = controllers['show']
+                                    if 'streams' in metadataConfiguration.keys()
-        self.__tc = controllers['track']
+                                    and 'ignore' in metadataConfiguration['streams'].keys() else [])
-        self.__tac = controllers['tag']
+
-        self.__ssc = controllers['shifted_season']
+        self.__pc = PatternController(context = self.context)
+        self.__sc = ShowController(context = self.context)
+        self.__tc = TrackController(context = self.context)
+        self.__tac = TagController(context = self.context)
 
         self.__pattern : Pattern = self.__pc.getPattern(patternId) if patternId is not None else None
         self.__showDescriptor = self.__sc.getShowDescriptor(showId) if showId is not None else None
-        self.__draftTracks : List[TrackDescriptor] = []
+
-        self.__draftTags : dict[str, str] = {}
+
+    #TODO: per controller
+    def loadTracks(self, show_id):
+
+        try:
+
+            tracks = {}
+            tracks['audio'] = {}
+            tracks['subtitle'] = {}
+
+            s = self.Session()
+            q = s.query(Pattern).filter(Pattern.show_id == int(show_id))
+
+            return [{'id': int(p.id), 'pattern': p.pattern} for p in q.all()]
+
+        except Exception as ex:
+            raise click.ClickException(f"loadTracks(): {repr(ex)}")
+        finally:
+            s.close()
 
 
     def updateTracks(self):
 
         self.tracksTable.clear()
 
-        tracks = self.getCurrentTrackDescriptors()
+        if self.__pattern is not None:
+
+            tracks = self.__tc.findTracks(self.__pattern.getId())
 
             typeCounter = {}
 
-        td: TrackDescriptor
+            tr: Track
-        for td in tracks:
+            for tr in tracks:
+
+                td : TrackDescriptor = tr.getDescriptor(self.context)
 
                 if (trackType := td.getType()) != TrackType.ATTACHMENT:
 
@@ -170,47 +196,11 @@ class PatternDetailsScreen(Screen):
                     typeCounter[trackType] += 1
 
 
-    def getCurrentTrackDescriptors(self) -> List[TrackDescriptor]:
-        if self.__pattern is not None:
-            return self.__tc.findSiblingDescriptors(self.__pattern.getId())
-        return list(self.__draftTracks)
-
-
-    def normalizeDraftTracks(self):
-
-        typeCounter = {}
-
-        for index, trackDescriptor in enumerate(self.__draftTracks):
-            trackDescriptor.setIndex(index)
-
-            trackType = trackDescriptor.getType()
-            subIndex = typeCounter.get(trackType, 0)
-            trackDescriptor.setSubIndex(subIndex)
-            typeCounter[trackType] = subIndex + 1
-
-            if trackDescriptor.getSourceIndex() < 0:
-                trackDescriptor.setSourceIndex(index)
-
-
     def swapTracks(self, trackIndex1: int, trackIndex2: int):
 
         ti1 = int(trackIndex1)
         ti2 = int(trackIndex2)
 
-        if self.__pattern is None:
-            numSiblings = len(self.__draftTracks)
-
-            if ti1 < 0 or ti1 >= numSiblings:
-                raise ValueError(f"PatternDetailsScreen.swapTracks(): trackIndex1 ({ti1}) is out of range ({numSiblings})")
-
-            if ti2 < 0 or ti2 >= numSiblings:
-                raise ValueError(f"PatternDetailsScreen.swapTracks(): trackIndex2 ({ti2}) is out of range ({numSiblings})")
-
-            self.__draftTracks[ti1], self.__draftTracks[ti2] = self.__draftTracks[ti2], self.__draftTracks[ti1]
-            self.normalizeDraftTracks()
-            self.updateTracks()
-            return
-
         siblingDescriptors: List[TrackDescriptor] = self.__tc.findSiblingDescriptors(self.__pattern.getId())
 
         numSiblings = len(siblingDescriptors)
@@ -246,11 +236,9 @@ class PatternDetailsScreen(Screen):
 
         self.tagsTable.clear()
 
-        tags = (
+        if self.__pattern is not None:
-            self.__tac.findAllMediaTags(self.__pattern.getId())
+
-            if self.__pattern is not None
+            tags = self.__tac.findAllMediaTags(self.__pattern.getId())
-            else self.__draftTags
-        )
 
             for tagKey, tagValue in tags.items():
 
@@ -260,75 +248,10 @@ class PatternDetailsScreen(Screen):
                 if tagKey in self.__removeGlobalKeys:
                     textColor = 'red'
 
+                # if tagKey not in self.__ignoreTrackKeys:
                 row = (formatRichColor(tagKey, textColor), formatRichColor(tagValue, textColor))
                 self.tagsTable.add_row(*map(str, row))
 
-    def updateShiftedSeasons(self):
-
-        self.shiftedSeasonsTable.clear()
-
-        if self.__pattern is None:
-            return
-
-        shiftedSeason: ShiftedSeason
-        for shiftedSeason in self.__ssc.getShiftedSeasonSiblings(patternId=self.__pattern.getId()):
-            shiftedSeasonObj = shiftedSeason.getObj()
-
-            firstEpisode = shiftedSeasonObj['first_episode']
-            firstEpisodeStr = str(firstEpisode) if firstEpisode != -1 else ''
-
-            lastEpisode = shiftedSeasonObj['last_episode']
-            lastEpisodeStr = str(lastEpisode) if lastEpisode != -1 else ''
-
-            row = (
-                shiftedSeasonObj['original_season'],
-                firstEpisodeStr,
-                lastEpisodeStr,
-                shiftedSeasonObj['season_offset'],
-                shiftedSeasonObj['episode_offset'],
-            )
-
-            self.shiftedSeasonsTable.add_row(*map(str, row))
-
-    def getSelectedShiftedSeasonObjFromInput(self):
-
-        shiftedSeasonObj = {}
-
-        try:
-            row_key, col_key = self.shiftedSeasonsTable.coordinate_to_cell_key(
-                self.shiftedSeasonsTable.cursor_coordinate
-            )
-
-            if row_key is not None:
-                selected_row_data = self.shiftedSeasonsTable.get_row(row_key)
-
-                def parse_int_or_default(value: str, default: int) -> int:
-                    try:
-                        return int(value)
-                    except (TypeError, ValueError):
-                        return default
-
-                shiftedSeasonObj['original_season'] = int(selected_row_data[0])
-                shiftedSeasonObj['first_episode'] = parse_int_or_default(selected_row_data[1], -1)
-                shiftedSeasonObj['last_episode'] = parse_int_or_default(selected_row_data[2], -1)
-                shiftedSeasonObj['season_offset'] = parse_int_or_default(selected_row_data[3], 0)
-                shiftedSeasonObj['episode_offset'] = parse_int_or_default(selected_row_data[4], 0)
-
-                if self.__pattern is not None:
-                    shiftedSeasonId = self.__ssc.findShiftedSeason(
-                        patternId=self.__pattern.getId(),
-                        originalSeason=shiftedSeasonObj['original_season'],
-                        firstEpisode=shiftedSeasonObj['first_episode'],
-                        lastEpisode=shiftedSeasonObj['last_episode'],
-                    )
-                    if shiftedSeasonId is not None:
-                        shiftedSeasonObj['id'] = shiftedSeasonId
-
-        except CellDoesNotExist:
-            pass
-
-        return shiftedSeasonObj
-
 
     def on_mount(self):
 
@@ -347,7 +270,6 @@ class PatternDetailsScreen(Screen):
 
             self.updateTags()
             self.updateTracks()
-            self.updateShiftedSeasons()
 
     def compose(self):
 
@@ -376,16 +298,6 @@ class PatternDetailsScreen(Screen):
 
         self.tracksTable.cursor_type = 'row'
 
-        self.shiftedSeasonsTable = DataTable(classes="seven")
-
-        self.column_key_original_season = self.shiftedSeasonsTable.add_column("Source Season", width=18)
-        self.column_key_first_episode = self.shiftedSeasonsTable.add_column("First Episode", width=18)
-        self.column_key_last_episode = self.shiftedSeasonsTable.add_column("Last Episode", width=18)
-        self.column_key_season_offset = self.shiftedSeasonsTable.add_column("Season Offset", width=18)
-        self.column_key_episode_offset = self.shiftedSeasonsTable.add_column("Episode Offset", width=18)
-
-        self.shiftedSeasonsTable.cursor_type = 'row'
-
 
         yield Header()
 
@@ -427,11 +339,13 @@ class PatternDetailsScreen(Screen):
             yield Static(" ", classes="seven")
 
             # 9
-            yield Static("Shifted Seasons")
+            yield Static("Media Tags")
+
+
             if self.__pattern is not None:
-                yield Button("Add", id="button_add_shifted_season")
+                yield Button("Add", id="button_add_tag")
-                yield Button("Edit", id="button_edit_shifted_season")
+                yield Button("Edit", id="button_edit_tag")
-                yield Button("Delete", id="button_delete_shifted_season")
+                yield Button("Delete", id="button_delete_tag")
             else:
                 yield Static(" ")
                 yield Static(" ")
@@ -442,52 +356,43 @@ class PatternDetailsScreen(Screen):
             yield Static(" ")
 
             # 10
-            yield self.shiftedSeasonsTable
+            yield self.tagsTable
 
             # 11
             yield Static(" ", classes="seven")
 
             # 12
-            yield Static("Media Tags")
-            yield Button("Add", id="button_add_tag")
-            yield Button("Edit", id="button_edit_tag")
-            yield Button("Delete", id="button_delete_tag")
-
-            yield Static(" ")
-            yield Static(" ")
-            yield Static(" ")
-
-            # 13
-            yield self.tagsTable
-
-            # 14
-            yield Static(" ", classes="seven")
-
-            # 15
             yield Static("Streams")
+
+
+            if self.__pattern is not None:
                 yield Button("Add", id="button_add_track")
                 yield Button("Edit", id="button_edit_track")
                 yield Button("Delete", id="button_delete_track")
+            else:
+                yield Static(" ")
+                yield Static(" ")
+                yield Static(" ")
 
             yield Static(" ")
             yield Button("Up", id="button_track_up")
             yield Button("Down", id="button_track_down")
 
-            # 16
+            # 13
             yield self.tracksTable
 
-            # 17
+            # 14
             yield Static(" ", classes="seven")
 
-            # 18
+            # 15
             yield Static(" ", classes="seven")
 
-            # 19
+            # 16
             yield Button("Save", id="save_button")
             yield Button("Cancel", id="cancel_button")
             yield Static(" ", classes="five")
 
-            # 20
+            # 17
             yield Static(" ", classes="seven")
 
         yield Footer()
@@ -508,8 +413,13 @@ class PatternDetailsScreen(Screen):
 
     def getSelectedTrackDescriptor(self):
 
+        if not self.__pattern:
+            return None
+
         try:
 
+            # Fetch the currently selected row when 'Enter' is pressed
+            #selected_row_index = self.table.cursor_row
             row_key, col_key = self.tracksTable.coordinate_to_cell_key(self.tracksTable.cursor_coordinate)
 
             if row_key is not None:
@@ -518,11 +428,9 @@ class PatternDetailsScreen(Screen):
                 trackIndex = int(selected_track_data[0])
                 trackSubIndex = int(selected_track_data[2])
 
-                for trackDescriptor in self.getCurrentTrackDescriptors():
+                return self.__tc.getTrack(self.__pattern.getId(), trackIndex).getDescriptor(self.context, subIndex=trackSubIndex)
-                    if (trackDescriptor.getIndex() == trackIndex
-                            and trackDescriptor.getSubIndex() == trackSubIndex):
-                        return trackDescriptor
 
+            else:
                 return None
 
         except CellDoesNotExist:
@@ -574,11 +482,7 @@ class PatternDetailsScreen(Screen):
                     self.app.pop_screen()
 
             else:
-                patternId = self.__pc.savePatternSchema(
+                patternId = self.__pc.addPattern(patternDescriptor)
-                    patternDescriptor,
-                    trackDescriptors=self.__draftTracks,
-                    mediaTags=self.__draftTags,
-                )
                 if patternId:
                     self.dismiss(patternDescriptor)
                 else:
@@ -589,81 +493,33 @@ class PatternDetailsScreen(Screen):
         if event.button.id == "cancel_button":
             self.app.pop_screen()
 
-        if event.button.id == "button_add_shifted_season":
+
+        # Save pattern when just created before adding streams
         if self.__pattern is not None:
-                self.app.push_screen(
-                    ShiftedSeasonDetailsScreen(patternId=self.__pattern.getId()),
-                    self.handle_update_shifted_season,
-                )
 
-        if event.button.id == "button_edit_shifted_season":
+            numTracks = len(self.tracksTable.rows)
-            selectedShiftedSeasonObj = self.getSelectedShiftedSeasonObjFromInput()
-            if 'id' in selectedShiftedSeasonObj.keys():
-                self.app.push_screen(
-                    ShiftedSeasonDetailsScreen(
-                        patternId=self.__pattern.getId(),
-                        shiftedSeasonId=selectedShiftedSeasonObj['id'],
-                    ),
-                    self.handle_update_shifted_season,
-                )
-
-        if event.button.id == "button_delete_shifted_season":
-            selectedShiftedSeasonObj = self.getSelectedShiftedSeasonObjFromInput()
-            if 'id' in selectedShiftedSeasonObj.keys():
-                self.app.push_screen(
-                    ShiftedSeasonDeleteScreen(
-                        patternId=self.__pattern.getId(),
-                        shiftedSeasonId=selectedShiftedSeasonObj['id'],
-                    ),
-                    self.handle_delete_shifted_season,
-                )
-
-
-        numTracks = len(self.getCurrentTrackDescriptors())
 
             if event.button.id == "button_add_track":
-            self.app.push_screen(
+                self.app.push_screen(TrackDetailsScreen(patternId = self.__pattern.getId(), index = numTracks), self.handle_add_track)
-                TrackDetailsScreen(
-                    patternId=self.__pattern.getId() if self.__pattern is not None else None,
-                    patternLabel=self.getPatternFromInput(),
-                    siblingTrackDescriptors=self.getCurrentTrackDescriptors(),
-                    index=numTracks,
-                ),
-                self.handle_add_track,
-            )
 
             selectedTrack = self.getSelectedTrackDescriptor()
             if selectedTrack is not None:
                 if event.button.id == "button_edit_track":
-                self.app.push_screen(
+                    self.app.push_screen(TrackDetailsScreen(trackDescriptor = selectedTrack), self.handle_edit_track)
-                    TrackDetailsScreen(
-                        trackDescriptor=selectedTrack,
-                        patternId=self.__pattern.getId() if self.__pattern is not None else None,
-                        patternLabel=self.getPatternFromInput(),
-                        siblingTrackDescriptors=self.getCurrentTrackDescriptors(),
-                    ),
-                    self.handle_edit_track,
-                )
                 if event.button.id == "button_delete_track":
-                self.app.push_screen(
+                    self.app.push_screen(TrackDeleteScreen(trackDescriptor = selectedTrack), self.handle_delete_track)
-                    TrackDeleteScreen(trackDescriptor = selectedTrack),
-                    self.handle_delete_track,
-                )
 
 
         if event.button.id == "button_add_tag":
+            if self.__pattern is not None:
                 self.app.push_screen(TagDetailsScreen(), self.handle_update_tag)
 
         if event.button.id == "button_edit_tag":
-            selectedTag = self.getSelectedTag()
+            tagKey, tagValue = self.getSelectedTag()
-            if selectedTag is not None:
-                tagKey, tagValue = selectedTag
             self.app.push_screen(TagDetailsScreen(key=tagKey, value=tagValue), self.handle_update_tag)
 
         if event.button.id == "button_delete_tag":
-            selectedTag = self.getSelectedTag()
+            tagKey, tagValue = self.getSelectedTag()
-            if selectedTag is not None:
-                tagKey, tagValue = selectedTag
             self.app.push_screen(TagDeleteScreen(key=tagKey, value=tagValue), self.handle_delete_tag)
 
 
@@ -681,7 +537,6 @@ class PatternDetailsScreen(Screen):
         if event.button.id == "button_track_up":
 
             selectedTrackDescriptor = self.getSelectedTrackDescriptor()
-            if selectedTrackDescriptor is not None:
             selectedTrackIndex = selectedTrackDescriptor.getIndex()
 
             if selectedTrackIndex > 0 and selectedTrackIndex < self.tracksTable.row_count:
@@ -692,7 +547,6 @@ class PatternDetailsScreen(Screen):
         if event.button.id == "button_track_down":
 
             selectedTrackDescriptor = self.getSelectedTrackDescriptor()
-            if selectedTrackDescriptor is not None:
             selectedTrackIndex = selectedTrackDescriptor.getIndex()
 
             if selectedTrackIndex >= 0 and selectedTrackIndex < (self.tracksTable.row_count - 1):
@@ -701,94 +555,67 @@ class PatternDetailsScreen(Screen):
 
 
     def handle_add_track(self, trackDescriptor : TrackDescriptor):
-        if trackDescriptor is None:
-            return
 
-        if self.__pattern is not None:
+        dispoSet = trackDescriptor.getDispositionSet()
-            self.__tc.addTrack(trackDescriptor, patternId=self.__pattern.getId())
+        trackType = trackDescriptor.getType()
-        else:
+        index = trackDescriptor.getIndex()
-            self.__draftTracks.append(trackDescriptor)
+        subIndex = trackDescriptor.getSubIndex()
-            self.normalizeDraftTracks()
+        codec = trackDescriptor.getCodec()
+        language = trackDescriptor.getLanguage()
+        title = trackDescriptor.getTitle()
 
-        self.updateTracks()
+        row = (index,
+               trackType.label(),
+               subIndex,
+                codec.label(),
+                language.label(),
+                title,
+                'Yes' if TrackDisposition.DEFAULT in dispoSet else 'No',
+                'Yes' if TrackDisposition.FORCED in dispoSet else 'No')
+
+        self.tracksTable.add_row(*map(str, row))
 
 
     def handle_edit_track(self, trackDescriptor : TrackDescriptor):
-        if trackDescriptor is None:
-            return
 
-        if self.__pattern is not None:
+        try:
-            if not self.__tc.updateTrack(trackDescriptor.getId(), trackDescriptor):
-                raise click.ClickException("PatternDetailsScreen.handle_edit_track(): track update failed")
-        else:
-            selectedTrack = self.getSelectedTrackDescriptor()
-            for index, currentTrack in enumerate(self.__draftTracks):
-                if (selectedTrack is not None
-                        and currentTrack.getIndex() == selectedTrack.getIndex()
-                        and currentTrack.getSubIndex() == selectedTrack.getSubIndex()):
-                    self.__draftTracks[index] = trackDescriptor
-                    break
-            self.normalizeDraftTracks()
 
-        self.updateTracks()
+            row_key, col_key = self.tracksTable.coordinate_to_cell_key(self.tracksTable.cursor_coordinate)
+
+            self.tracksTable.update_cell(row_key, self.column_key_track_audio_layout,
+                                            trackDescriptor.getAudioLayout().label()
+                                            if trackDescriptor.getType() == TrackType.AUDIO else ' ')
+
+            self.tracksTable.update_cell(row_key, self.column_key_track_language, trackDescriptor.getLanguage().label())
+            self.tracksTable.update_cell(row_key, self.column_key_track_title, trackDescriptor.getTitle())
+            self.tracksTable.update_cell(row_key, self.column_key_track_default,
+                                            'Yes' if TrackDisposition.DEFAULT in trackDescriptor.getDispositionSet() else 'No')
+            self.tracksTable.update_cell(row_key, self.column_key_track_forced,
+                                            'Yes' if TrackDisposition.FORCED in trackDescriptor.getDispositionSet() else 'No')
+
+        except CellDoesNotExist:
+            pass
 
 
     def handle_delete_track(self, trackDescriptor : TrackDescriptor):
-        if trackDescriptor is None:
-            return
-
-        if self.__pattern is not None:
-            track = self.__tc.getTrack(trackDescriptor.getPatternId(), trackDescriptor.getIndex())
-
-            if track is None:
-                raise click.ClickException(
-                    f"Track is none: patternId={trackDescriptor.getPatternId()} type={trackDescriptor.getType()} subIndex={trackDescriptor.getSubIndex()}"
-                )
-
-            self.__tc.deleteTrack(track.getId())
-        else:
-            self.__draftTracks = [
-                currentTrack
-                for currentTrack in self.__draftTracks
-                if not (
-                    currentTrack.getIndex() == trackDescriptor.getIndex()
-                    and currentTrack.getSubIndex() == trackDescriptor.getSubIndex()
-                )
-            ]
-            self.normalizeDraftTracks()
-
         self.updateTracks()
 
 
 
     def handle_update_tag(self, tag):
-        if tag is None:
-            return
 
         if self.__pattern is None:
-            self.__draftTags[str(tag[0])] = str(tag[1])
+            raise click.ClickException(f"PatternDetailsScreen.handle_update_tag: pattern not set")
-        else:
-            if self.__tac.updateMediaTag(self.__pattern.getId(), tag[0], tag[1]) is None:
-                raise click.ClickException("PatternDetailsScreen.handle_update_tag(): tag update failed")
 
+        if self.__tac.updateMediaTag(self.__pattern.getId(), tag[0], tag[1]) is not None:
             self.updateTags()
 
     def handle_delete_tag(self, tag):
-        if tag is None:
-            return
 
         if self.__pattern is None:
-            self.__draftTags.pop(str(tag[0]), None)
+            raise click.ClickException(f"PatternDetailsScreen.handle_delete_tag: pattern not set")
-            self.updateTags()
-            return
 
         if self.__tac.deleteMediaTagByKey(self.__pattern.getId(), tag[0]):
             self.updateTags()
         else:
             raise click.ClickException('tag delete failed')
-
-    def handle_update_shifted_season(self, screenResult):
-        self.updateShiftedSeasons()
-
-    def handle_delete_shifted_season(self, screenResult):
-        self.updateShiftedSeasons()

src/ffx/process.py

@@ -1,169 +1,33 @@
-import os
+import subprocess, logging
-import shlex
+from typing import List
-import subprocess
-from typing import Iterable, List
 
-from .logging_utils import get_ffx_logger
+def executeProcess(commandSequence: List[str], directory: str = None, context: dict = None):
-
-COMMAND_TIMED_OUT_RETURN_CODE = 124
-COMMAND_NOT_FOUND_RETURN_CODE = 127
-MIN_NICENESS = -20
-MAX_NICENESS = 19
-DISABLED_NICENESS_SENTINEL = 99
-DISABLED_CPU_PERCENT_SENTINEL = 0
-MIN_CPU_PERCENT = 1
-MAX_CPU_PERCENT = 100
-
-
-def formatCommandSequence(commandSequence: Iterable[str]) -> str:
-    return shlex.join([str(token) for token in commandSequence])
-
-
-def normalizeNiceness(niceness) -> int | None:
-    if niceness is None:
-        return None
-
-    niceness = int(niceness)
-    if niceness == DISABLED_NICENESS_SENTINEL:
-        return None
-
-    if niceness < MIN_NICENESS or niceness > MAX_NICENESS:
-        raise ValueError(
-            f"Niceness must be between {MIN_NICENESS} and {MAX_NICENESS}, "
-            + f"or {DISABLED_NICENESS_SENTINEL} to disable."
-        )
-
-    return niceness
-
-
-def getPresentCpuCount() -> int:
-    if hasattr(os, 'sched_getaffinity'):
-        affinity = os.sched_getaffinity(0)
-        if affinity:
-            return len(affinity)
-
-    cpuCount = os.cpu_count()
-    return cpuCount if cpuCount and cpuCount > 0 else 1
-
-
-def normalizeCpuPercent(cpuPercent) -> int | None:
-    if cpuPercent is None:
-        return None
-
-    cpuPercent = str(cpuPercent).strip()
-    if cpuPercent.endswith('%'):
-        percentValue = int(cpuPercent[:-1].strip())
-        if percentValue == DISABLED_CPU_PERCENT_SENTINEL:
-            return None
-
-        if percentValue < MIN_CPU_PERCENT or percentValue > MAX_CPU_PERCENT:
-            raise ValueError(
-                f"CPU percentage must be between {MIN_CPU_PERCENT}% and {MAX_CPU_PERCENT}%, "
-                + f"or {DISABLED_CPU_PERCENT_SENTINEL} to disable."
-            )
-
-        return percentValue * getPresentCpuCount()
-
-    cpuPercent = int(cpuPercent)
-    if cpuPercent == DISABLED_CPU_PERCENT_SENTINEL:
-        return None
-
-    if cpuPercent < MIN_CPU_PERCENT:
-        raise ValueError(
-            "CPU limit must be a positive absolute value such as 200, "
-            + f"a percentage such as 25%, or {DISABLED_CPU_PERCENT_SENTINEL} to disable."
-        )
-
-    return cpuPercent
-
-
-def getWrappedCommandSequence(commandSequence: List[str], context: dict = None) -> List[str]:
     """
-    niceness: -20 to 19, disabled when unset
+    niceness -20 bis +19
-    cpu limit: positive absolute cpulimit value, or a machine-wide percentage
+    cpu_percent: 1 bis 99
-
-    When both limits are configured, cpulimit wraps a nice-adjusted command:
-    cpulimit -l <cpu> -- nice -n <niceness> <command>
     """
 
-    resourceLimits = (context or {}).get('resource_limits', {})
+    if context is None:
-    niceness = normalizeNiceness(resourceLimits.get('niceness'))
+        logger = logging.getLogger('FFX')
-    cpu_percent = normalizeCpuPercent(
+        logger.addHandler(logging.NullHandler())
-        resourceLimits.get('cpu_limit', resourceLimits.get('cpu_percent'))
+    else:
-    )
+        logger = context['logger']
-    wrappedCommandSequence = [str(token) for token in commandSequence]
 
-    if niceness is not None:
+    niceSequence = []
-        wrappedCommandSequence = ['nice', '-n', str(niceness)] + wrappedCommandSequence
-    if cpu_percent is not None:
-        wrappedCommandSequence = ['cpulimit', '-l', str(cpu_percent), '--'] + wrappedCommandSequence
 
-    return wrappedCommandSequence
+    niceness = int((context or {}).get('resource_limits', {}).get('niceness', 99))
+    cpu_percent = int((context or {}).get('resource_limits', {}).get('cpu_percent', 0))
 
+    if niceness >= -20 and niceness <= 19:
+        niceSequence += ['nice', '-n', str(niceness)]
+    if cpu_percent >= 1:
+        niceSequence += ['cpulimit', '-l', str(cpu_percent), '--']
 
-def getProcessTimeoutSeconds(context: dict = None, timeoutSeconds: float = None):
+    niceCommand = niceSequence + commandSequence
-    if timeoutSeconds is None:
-        timeoutSeconds = (context or {}).get('resource_limits', {}).get('timeout_seconds')
 
-    if timeoutSeconds is None:
+    logger.debug(f"executeProcess() command sequence: {' '.join(niceCommand)}")
-        return None
 
-    timeoutSeconds = float(timeoutSeconds)
+    process = subprocess.Popen(niceCommand, stdout=subprocess.PIPE, stderr=subprocess.PIPE, encoding='utf-8', cwd = directory)
+    output, error = process.communicate()
     
-    return timeoutSeconds if timeoutSeconds > 0 else None
+    return output, error, process.returncode
-
-
-def executeProcess(
-    commandSequence: List[str],
-    directory: str = None,
-    context: dict = None,
-    timeoutSeconds: float = None,
-):
-
-    logger = context['logger'] if context is not None and 'logger' in context else get_ffx_logger()
-    wrappedCommandSequence = getWrappedCommandSequence(commandSequence, context=context)
-    timeoutSeconds = getProcessTimeoutSeconds(context=context, timeoutSeconds=timeoutSeconds)
-
-    logger.debug(
-        "executeProcess() cwd=%s timeout=%s command=%s",
-        directory or '.',
-        timeoutSeconds if timeoutSeconds is not None else 'none',
-        formatCommandSequence(wrappedCommandSequence),
-    )
-
-    try:
-        completed = subprocess.run(
-            wrappedCommandSequence,
-            capture_output=True,
-            text=True,
-            cwd=directory,
-            timeout=timeoutSeconds,
-            check=False,
-        )
-    except FileNotFoundError as ex:
-        error = (
-            "Command not found while running "
-            + f"{formatCommandSequence(wrappedCommandSequence)}: {ex.filename or ex}"
-        )
-        logger.error(error)
-        return '', error, COMMAND_NOT_FOUND_RETURN_CODE
-    except subprocess.TimeoutExpired as ex:
-        stdout = ex.stdout or ''
-        stderr = ex.stderr or ''
-        error = (
-            f"Command timed out after {timeoutSeconds} seconds while running "
-            + formatCommandSequence(wrappedCommandSequence)
-        )
-        if stderr:
-            error = f"{error}\n{stderr}"
-        logger.error(error)
-        return stdout, error, COMMAND_TIMED_OUT_RETURN_CODE
-
-    if completed.returncode != 0:
-        logger.warning(
-            "executeProcess() rc=%s command=%s",
-            completed.returncode,
-            formatCommandSequence(wrappedCommandSequence),
-        )
-
-    return completed.stdout, completed.stderr, completed.returncode

src/ffx/screen_support.py

@@ -1,65 +0,0 @@
-from __future__ import annotations
-
-from dataclasses import dataclass
-
-from .pattern_controller import PatternController
-from .show_controller import ShowController
-from .shifted_season_controller import ShiftedSeasonController
-from .tag_controller import TagController
-from .tmdb_controller import TmdbController
-from .track_controller import TrackController
-
-
-@dataclass(frozen=True)
-class ScreenBootstrap:
-    context: dict
-    configuration_data: dict
-    signature_tags: dict
-    remove_global_keys: list
-    ignore_global_keys: list
-    remove_track_keys: list
-    ignore_track_keys: list
-
-
-def build_screen_bootstrap(context: dict) -> ScreenBootstrap:
-    configurationData = context['config'].getData()
-    metadataConfiguration = configurationData.get('metadata', {})
-    streamMetadataConfiguration = metadataConfiguration.get('streams', {})
-
-    return ScreenBootstrap(
-        context=context,
-        configuration_data=configurationData,
-        signature_tags=metadataConfiguration.get('signature', {}),
-        remove_global_keys=metadataConfiguration.get('remove', []),
-        ignore_global_keys=metadataConfiguration.get('ignore', []),
-        remove_track_keys=streamMetadataConfiguration.get('remove', []),
-        ignore_track_keys=streamMetadataConfiguration.get('ignore', []),
-    )
-
-
-def build_screen_controllers(
-    context: dict,
-    *,
-    pattern: bool = False,
-    show: bool = False,
-    track: bool = False,
-    tag: bool = False,
-    tmdb: bool = False,
-    shifted_season: bool = False,
-) -> dict[str, object]:
-    controllers = {}
-
-    if pattern:
-        controllers['pattern'] = PatternController(context=context)
-    if show:
-        controllers['show'] = ShowController(context=context)
-    if track:
-        controllers['track'] = TrackController(context=context)
-    if tag:
-        controllers['tag'] = TagController(context=context)
-    if tmdb:
-        controllers['tmdb'] = TmdbController()
-    if shifted_season:
-        controllers['shifted_season'] = ShiftedSeasonController(context=context)
-
-    return controllers

src/ffx/shifted_season_controller.py

@@ -6,433 +6,228 @@ from ffx.model.shifted_season import ShiftedSeason
 class EpisodeOrderException(Exception):
     pass
 
-
 class RangeOverlapException(Exception):
     pass
 
 
-class ShiftedSeasonOwnerException(Exception):
+class ShiftedSeasonController():
-    pass
-
-
-class ShiftedSeasonController:
     
     def __init__(self, context):
         
         self.context = context
         self.Session = self.context['database']['session'] # convenience
 
-    def _resolve_owner(self, showId=None, patternId=None):
+    def checkShiftedSeason(self, showId: int, shiftedSeasonObj: dict, shiftedSeasonId: int = 0):
-        hasShow = showId is not None
-        hasPattern = patternId is not None
-
-        if hasShow == hasPattern:
-            raise ShiftedSeasonOwnerException(
-                "ShiftedSeason rules require exactly one owner: either showId or patternId."
-            )
-
-        if hasShow:
-            if type(showId) is not int:
-                raise ValueError(
-                    "ShiftedSeasonController: Argument showId is required to be of type int"
-                )
-            return {
-                'show_id': int(showId),
-                'pattern_id': None,
-                'label': f"show #{int(showId)}",
-            }
-
-        if type(patternId) is not int:
-            raise ValueError(
-                "ShiftedSeasonController: Argument patternId is required to be of type int"
-            )
-        return {
-            'show_id': None,
-            'pattern_id': int(patternId),
-            'label': f"pattern #{int(patternId)}",
-        }
-
-    def _apply_owner_filter(self, query, owner):
-        if owner['pattern_id'] is not None:
-            return query.filter(ShiftedSeason.pattern_id == owner['pattern_id'])
-        return query.filter(ShiftedSeason.show_id == owner['show_id'])
-
-    def _normalize_shifted_season_fields(self, shiftedSeasonObj: dict):
-        if type(shiftedSeasonObj) is not dict:
-            raise ValueError(
-                "ShiftedSeasonController: Argument shiftedSeasonObj is required to be of type dict"
-            )
-
-        fields = {
-            'original_season': int(shiftedSeasonObj['original_season']),
-            'first_episode': int(shiftedSeasonObj['first_episode']),
-            'last_episode': int(shiftedSeasonObj['last_episode']),
-            'season_offset': int(shiftedSeasonObj['season_offset']),
-            'episode_offset': int(shiftedSeasonObj['episode_offset']),
-        }
-
-        firstEpisode = fields['first_episode']
-        lastEpisode = fields['last_episode']
-        if firstEpisode != -1 and lastEpisode != -1 and lastEpisode < firstEpisode:
-            raise EpisodeOrderException(
-                "ShiftedSeason last_episode must be greater than or equal to first_episode."
-            )
-
-        return fields
-
-    def _ranges_overlap(self, firstEpisodeA, lastEpisodeA, firstEpisodeB, lastEpisodeB):
-        startA = float('-inf') if int(firstEpisodeA) == -1 else int(firstEpisodeA)
-        endA = float('inf') if int(lastEpisodeA) == -1 else int(lastEpisodeA)
-        startB = float('-inf') if int(firstEpisodeB) == -1 else int(firstEpisodeB)
-        endB = float('inf') if int(lastEpisodeB) == -1 else int(lastEpisodeB)
-        return startA <= endB and startB <= endA
-
-    def _ordered_query(self, session, owner):
-        q = self._apply_owner_filter(session.query(ShiftedSeason), owner)
-        return q.order_by(
-            ShiftedSeason.original_season.asc(),
-            ShiftedSeason.first_episode.asc(),
-            ShiftedSeason.last_episode.asc(),
-            ShiftedSeason.id.asc(),
-        )
-
-    def _find_matching_rule(self, session, owner, season: int, episode: int):
-        for shiftedSeasonEntry in self._ordered_query(session, owner).all():
-            if (
-                season == shiftedSeasonEntry.getOriginalSeason()
-                and (
-                    shiftedSeasonEntry.getFirstEpisode() == -1
-                    or episode >= shiftedSeasonEntry.getFirstEpisode()
-                )
-                and (
-                    shiftedSeasonEntry.getLastEpisode() == -1
-                    or episode <= shiftedSeasonEntry.getLastEpisode()
-                )
-            ):
-                return shiftedSeasonEntry
-        return None
-
-    def checkShiftedSeason(
-        self,
-        showId: int | None = None,
-        shiftedSeasonObj: dict | None = None,
-        shiftedSeasonId: int = 0,
-        patternId: int | None = None,
-    ):
         """
-        Check whether a shifted-season rule is valid within one owner scope.
+        Check if for a particula season 
+        
+        shiftedSeasonId
         """
 
-        session = None
         try:
-            owner = self._resolve_owner(showId=showId, patternId=patternId)
+            s = self.Session()
-            fields = self._normalize_shifted_season_fields(shiftedSeasonObj)
-            session = self.Session()
 
-            q = self._ordered_query(session, owner)
+            originalSeason = shiftedSeasonObj['original_season']
+            firstEpisode = int(shiftedSeasonObj['first_episode'])
+            lastEpisode = int(shiftedSeasonObj['last_episode'])
+
+            q = s.query(ShiftedSeason).filter(ShiftedSeason.show_id == int(showId))
             if shiftedSeasonId:
                 q = q.filter(ShiftedSeason.id != int(shiftedSeasonId))
 
+            siblingShiftedSeason: ShiftedSeason
             for siblingShiftedSeason in q.all():
-                if fields['original_season'] != siblingShiftedSeason.getOriginalSeason():
-                    continue
                  
-                if self._ranges_overlap(
+                siblingOriginalSeason = siblingShiftedSeason.getOriginalSeason
-                    fields['first_episode'],
+                siblingFirstEpisode = siblingShiftedSeason.getFirstEpisode()
-                    fields['last_episode'],
+                siblingLastEpisode = siblingShiftedSeason.getLastEpisode()
-                    siblingShiftedSeason.getFirstEpisode(),
+                
-                    siblingShiftedSeason.getLastEpisode(),
+                if (originalSeason == siblingOriginalSeason
-                ):
+                        and lastEpisode >= siblingFirstEpisode
+                        and siblingLastEpisode >= firstEpisode):
+
                     return False
-
             return True
 
-        except (EpisodeOrderException, ShiftedSeasonOwnerException) as ex:
-            raise click.ClickException(str(ex))
         except Exception as ex:
-            raise click.ClickException(
+            raise click.ClickException(f"ShiftedSeasonController.addShiftedSeason(): {repr(ex)}")
-                f"ShiftedSeasonController.checkShiftedSeason(): {repr(ex)}"
-            )
         finally:
-            if session is not None:
+            s.close()
-                session.close()
 
-    def addShiftedSeason(
-        self,
-        showId: int | None = None,
-        shiftedSeasonObj: dict | None = None,
-        patternId: int | None = None,
-    ):
 
-        session = None
+    def addShiftedSeason(self, showId: int, shiftedSeasonObj: dict):
+
+        if type(showId) is not int:
+            raise ValueError(f"ShiftedSeasonController.addShiftedSeason(): Argument showId is required to be of type int")
+
+        if type(shiftedSeasonObj) is not dict:
+            raise ValueError(f"ShiftedSeasonController.addShiftedSeason(): Argument shiftedSeasonObj is required to be of type dict")
+
         try:
-            owner = self._resolve_owner(showId=showId, patternId=patternId)
+            s = self.Session()
-            fields = self._normalize_shifted_season_fields(shiftedSeasonObj)
 
-            if not self.checkShiftedSeason(
+            firstEpisode = int(shiftedSeasonObj['first_episode'])
-                showId=owner['show_id'],
+            lastEpisode = int(shiftedSeasonObj['last_episode'])
-                patternId=owner['pattern_id'],
-                shiftedSeasonObj=fields,
-            ):
-                raise RangeOverlapException(
-                    f"ShiftedSeason rule overlaps with an existing rule for {owner['label']}."
-                )
 
-            session = self.Session()
+            if lastEpisode < firstEpisode:
-            shiftedSeason = ShiftedSeason(
+                raise EpisodeOrderException()
-                show_id=owner['show_id'],
+
-                pattern_id=owner['pattern_id'],
+            q = s.query(ShiftedSeason).filter(ShiftedSeason.show_id == int(showId))
-                original_season=fields['original_season'],
+
-                first_episode=fields['first_episode'],
+            shiftedSeason = ShiftedSeason(show_id = int(showId),
-                last_episode=fields['last_episode'],
+                                            original_season = int(shiftedSeasonObj['original_season']),
-                season_offset=fields['season_offset'],
+                                            first_episode = firstEpisode,
-                episode_offset=fields['episode_offset'],
+                                            last_episode = lastEpisode,
-            )
+                                            season_offset = int(shiftedSeasonObj['season_offset']),
-            session.add(shiftedSeason)
+                                            episode_offset = int(shiftedSeasonObj['episode_offset']))
-            session.commit()
+            s.add(shiftedSeason)
+            s.commit()
             return shiftedSeason.getId()
 
-        except (EpisodeOrderException, RangeOverlapException, ShiftedSeasonOwnerException) as ex:
-            raise click.ClickException(str(ex))
         except Exception as ex:
-            raise click.ClickException(
+            raise click.ClickException(f"ShiftedSeasonController.addShiftedSeason(): {repr(ex)}")
-                f"ShiftedSeasonController.addShiftedSeason(): {repr(ex)}"
-            )
         finally:
-            if session is not None:
+            s.close()
-                session.close()
+
 
     def updateShiftedSeason(self, shiftedSeasonId: int, shiftedSeasonObj: dict):
 
         if type(shiftedSeasonId) is not int:
-            raise ValueError(
+            raise ValueError(f"ShiftedSeasonController.updateShiftedSeason(): Argument shiftedSeasonId is required to be of type int")
-                "ShiftedSeasonController.updateShiftedSeason(): Argument shiftedSeasonId is required to be of type int"
+
-            )
+        if type(shiftedSeasonObj) is not dict:
+            raise ValueError(f"ShiftedSeasonController.updateShiftedSeason(): Argument shiftedSeasonObj is required to be of type dict")
 
-        session = None
         try:
-            fields = self._normalize_shifted_season_fields(shiftedSeasonObj)
+            s = self.Session()
-            session = self.Session()
 
-            shiftedSeason = (
+            q = s.query(ShiftedSeason).filter(ShiftedSeason.id == int(shiftedSeasonId))
-                session.query(ShiftedSeason)
-                .filter(ShiftedSeason.id == int(shiftedSeasonId))
-                .first()
-            )
 
-            if shiftedSeason is None:
+            if q.count():
-                return False
 
-            owner = self._resolve_owner(
+                shiftedSeason = q.first()
-                showId=shiftedSeason.getShowId(),
-                patternId=shiftedSeason.getPatternId(),
-            )
-            if not self.checkShiftedSeason(
-                showId=owner['show_id'],
-                patternId=owner['pattern_id'],
-                shiftedSeasonObj=fields,
-                shiftedSeasonId=shiftedSeasonId,
-            ):
-                raise RangeOverlapException(
-                    f"ShiftedSeason rule overlaps with an existing rule for {owner['label']}."
-                )
 
-            shiftedSeason.original_season = fields['original_season']
+                shiftedSeason.original_season = int(shiftedSeasonObj['original_season'])
-            shiftedSeason.first_episode = fields['first_episode']
+                shiftedSeason.first_episode = int(shiftedSeasonObj['first_episode'])
-            shiftedSeason.last_episode = fields['last_episode']
+                shiftedSeason.last_episode = int(shiftedSeasonObj['last_episode'])
-            shiftedSeason.season_offset = fields['season_offset']
+                shiftedSeason.season_offset = int(shiftedSeasonObj['season_offset'])
-            shiftedSeason.episode_offset = fields['episode_offset']
+                shiftedSeason.episode_offset = int(shiftedSeasonObj['episode_offset'])
 
-            session.commit()
+                s.commit()
                 return True
 
-        except (EpisodeOrderException, RangeOverlapException, ShiftedSeasonOwnerException) as ex:
+            else:
-            raise click.ClickException(str(ex))
+                return False
-        except Exception as ex:
-            raise click.ClickException(
-                f"ShiftedSeasonController.updateShiftedSeason(): {repr(ex)}"
-            )
-        finally:
-            if session is not None:
-                session.close()
 
-    def findShiftedSeason(
+        except Exception as ex:
-        self,
+            raise click.ClickException(f"ShiftedSeasonController.updateShiftedSeason(): {repr(ex)}")
-        showId: int | None = None,
+        finally:
-        originalSeason: int | None = None,
+            s.close()
-        firstEpisode: int | None = None,
+
-        lastEpisode: int | None = None,
+
-        patternId: int | None = None,
+    def findShiftedSeason(self, showId: int, originalSeason: int, firstEpisode: int, lastEpisode: int):
-    ):
+
+        if type(showId) is not int:
+            raise ValueError(f"ShiftedSeasonController.findShiftedSeason(): Argument shiftedSeasonId is required to be of type int")
 
         if type(originalSeason) is not int:
-            raise ValueError(
+            raise ValueError(f"ShiftedSeasonController.findShiftedSeason(): Argument originalSeason is required to be of type int")
-                "ShiftedSeasonController.findShiftedSeason(): Argument originalSeason is required to be of type int"
-            )
 
         if type(firstEpisode) is not int:
-            raise ValueError(
+            raise ValueError(f"ShiftedSeasonController.findShiftedSeason(): Argument firstEpisode is required to be of type int")
-                "ShiftedSeasonController.findShiftedSeason(): Argument firstEpisode is required to be of type int"
-            )
 
         if type(lastEpisode) is not int:
-            raise ValueError(
+            raise ValueError(f"ShiftedSeasonController.findShiftedSeason(): Argument lastEpisode is required to be of type int")
-                "ShiftedSeasonController.findShiftedSeason(): Argument lastEpisode is required to be of type int"
-            )
 
-        session = None
         try:
-            owner = self._resolve_owner(showId=showId, patternId=patternId)
+            s = self.Session()
-            session = self.Session()
+            q = s.query(ShiftedSeason).filter(ShiftedSeason.show_id == int(showId),
-            shiftedSeason = (
-                self._apply_owner_filter(session.query(ShiftedSeason), owner)
-                .filter(
                                                 ShiftedSeason.original_season == int(originalSeason),
                                                 ShiftedSeason.first_episode == int(firstEpisode),
-                    ShiftedSeason.last_episode == int(lastEpisode),
+                                                ShiftedSeason.last_episode == int(lastEpisode))
-                )
-                .first()
-            )
 
-            return shiftedSeason.getId() if shiftedSeason is not None else None
+            return q.first().getId() if q.count() else None
 
-        except ShiftedSeasonOwnerException as ex:
-            raise click.ClickException(str(ex))
         except Exception as ex:
-            raise click.ClickException(
+            raise click.ClickException(f"PatternController.findShiftedSeason(): {repr(ex)}")
-                f"ShiftedSeasonController.findShiftedSeason(): {repr(ex)}"
-            )
         finally:
-            if session is not None:
+            s.close()
-                session.close()
 
-    def getShiftedSeasonSiblings(
+    def getShiftedSeasonSiblings(self, showId: int):
-        self,
+
-        showId: int | None = None,
+        if type(showId) is not int:
-        patternId: int | None = None,
+            raise ValueError(f"ShiftedSeasonController.getShiftedSeasonSiblings(): Argument shiftedSeasonId is required to be of type int")
-    ):
-        session = None
 
         try:
-            owner = self._resolve_owner(showId=showId, patternId=patternId)
+            s = self.Session()
-            session = self.Session()
+            q = s.query(ShiftedSeason).filter(ShiftedSeason.show_id == int(showId))
-            return self._ordered_query(session, owner).all()
+
+            return q.all()
 
-        except ShiftedSeasonOwnerException as ex:
-            raise click.ClickException(str(ex))
         except Exception as ex:
-            raise click.ClickException(
+            raise click.ClickException(f"PatternController.getShiftedSeasonSiblings(): {repr(ex)}")
-                f"ShiftedSeasonController.getShiftedSeasonSiblings(): {repr(ex)}"
-            )
         finally:
-            if session is not None:
+            s.close()
-                session.close()
+
 
     def getShiftedSeason(self, shiftedSeasonId: int):
 
         if type(shiftedSeasonId) is not int:
-            raise ValueError(
+            raise ValueError(f"ShiftedSeasonController.getShiftedSeason(): Argument shiftedSeasonId is required to be of type int")
-                "ShiftedSeasonController.getShiftedSeason(): Argument shiftedSeasonId is required to be of type int"
-            )
 
-        session = None
         try:
-            session = self.Session()
+            s = self.Session()
-            return (
+            q = s.query(ShiftedSeason).filter(ShiftedSeason.id == int(shiftedSeasonId))
-                session.query(ShiftedSeason)
+
-                .filter(ShiftedSeason.id == int(shiftedSeasonId))
+            return q.first() if q.count() else None
-                .first()
-            )
 
         except Exception as ex:
-            raise click.ClickException(
+            raise click.ClickException(f"ShiftedSeasonController.getShiftedSeason(): {repr(ex)}")
-                f"ShiftedSeasonController.getShiftedSeason(): {repr(ex)}"
-            )
         finally:
-            if session is not None:
+            s.close()
-                session.close()
+
 
     def deleteShiftedSeason(self, shiftedSeasonId):
 
         if type(shiftedSeasonId) is not int:
-            raise ValueError(
+            raise ValueError(f"ShiftedSeasonController.deleteShiftedSeason(): Argument shiftedSeasonId is required to be of type int")
-                "ShiftedSeasonController.deleteShiftedSeason(): Argument shiftedSeasonId is required to be of type int"
-            )
 
-        session = None
         try:
-            session = self.Session()
+            s = self.Session()
-            shiftedSeason = (
+            q = s.query(ShiftedSeason).filter(ShiftedSeason.id == int(shiftedSeasonId))
-                session.query(ShiftedSeason)
-                .filter(ShiftedSeason.id == int(shiftedSeasonId))
-                .first()
-            )
 
-            if shiftedSeason is not None:
+            if q.count():
-                session.delete(shiftedSeason)
+
-                session.commit()
+                #DAFUQ: https://stackoverflow.com/a/19245058
+                # q.delete()
+                shiftedSeason = q.first()
+                s.delete(shiftedSeason)
+
+                s.commit()
                 return True
             return False
 
         except Exception as ex:
-            raise click.ClickException(
+            raise click.ClickException(f"ShiftedSeasonController.deleteShiftedSeason(): {repr(ex)}")
-                f"ShiftedSeasonController.deleteShiftedSeason(): {repr(ex)}"
-            )
         finally:
-            if session is not None:
+            s.close()
-                session.close()
 
-    def shiftSeason(self, showId, season, episode, patternId=None):
 
-        if season == -1 or episode == -1:
+    def shiftSeason(self, showId, season, episode):
-            return season, episode
 
-        session = None
+        shiftedSeasonEntry: ShiftedSeason
-        try:
+        for shiftedSeasonEntry in self.getShiftedSeasonSiblings(showId):
-            session = self.Session()
-            activeShift = None
 
-            if patternId is not None:
+            if (season == shiftedSeasonEntry.getOriginalSeason()
-                activeShift = self._find_matching_rule(
+                and (shiftedSeasonEntry.getFirstEpisode() == -1 or episode >= shiftedSeasonEntry.getFirstEpisode())
-                    session,
+                and (shiftedSeasonEntry.getLastEpisode() == -1 or episode <= shiftedSeasonEntry.getLastEpisode())):
-                    self._resolve_owner(patternId=patternId),
-                    season=int(season),
-                    episode=int(episode),
-                )
 
-            if activeShift is None and showId is not None and showId != -1:
+                shiftedSeason = season + shiftedSeasonEntry.getSeasonOffset()
-                activeShift = self._find_matching_rule(
+                shiftedEpisode = episode + shiftedSeasonEntry.getEpisodeOffset()
-                    session,
-                    self._resolve_owner(showId=showId),
-                    season=int(season),
-                    episode=int(episode),
-                )
 
-            if activeShift is None:
+                self.context['logger'].info(f"Shifting season: {season} episode: {episode} "
-                shiftedSeason = season
+                                                +f"-> season: {shiftedSeason} episode: {shiftedEpisode}")
-                shiftedEpisode = episode
-                sourceLabel = "default"
-            else:
-                shiftedSeason = season + activeShift.getSeasonOffset()
-                shiftedEpisode = episode + activeShift.getEpisodeOffset()
-                sourceLabel = (
-                    "pattern"
-                    if activeShift.getPatternId() is not None
-                    else "show"
-                )
-
-            self.context['logger'].info(
-                f"Setting season shift {season}/{episode} -> {shiftedSeason}/{shiftedEpisode} from {sourceLabel}"
-            )
 
                 return shiftedSeason, shiftedEpisode
     
-        except ShiftedSeasonOwnerException as ex:
+        return season, episode
-            raise click.ClickException(str(ex))
-        except Exception as ex:
-            raise click.ClickException(
-                f"ShiftedSeasonController.shiftSeason(): {repr(ex)}"
-            )
-        finally:
-            if session is not None:
-                session.close()

src/ffx/shifted_season_delete_screen.py

@@ -43,7 +43,7 @@ class ShiftedSeasonDeleteScreen(Screen):
     }
     """
 
-    def __init__(self, showId = None, patternId = None, shiftedSeasonId = None):
+    def __init__(self, showId = None, shiftedSeasonId = None):
         super().__init__()
 
         self.context = self.app.getContext()
@@ -52,7 +52,6 @@ class ShiftedSeasonDeleteScreen(Screen):
         self.__ssc = ShiftedSeasonController(context = self.context)
 
         self._showId = showId
-        self._patternId = patternId
         self.__shiftedSeasonId = shiftedSeasonId
 
 
@@ -60,12 +59,7 @@ class ShiftedSeasonDeleteScreen(Screen):
 
         shiftedSeason: ShiftedSeason = self.__ssc.getShiftedSeason(self.__shiftedSeasonId)
 
-        ownerLabel = (
+        self.query_one("#static_show_id", Static).update(str(self._showId))
-            f"pattern #{self._patternId}"
-            if self._patternId is not None
-            else f"show #{self._showId}"
-        )
-        self.query_one("#static_owner", Static).update(ownerLabel)
         self.query_one("#static_original_season", Static).update(str(shiftedSeason.getOriginalSeason()))
         self.query_one("#static_first_episode", Static).update(str(shiftedSeason.getFirstEpisode()))
         self.query_one("#static_last_episode", Static).update(str(shiftedSeason.getLastEpisode()))
@@ -83,12 +77,12 @@ class ShiftedSeasonDeleteScreen(Screen):
 
             yield Static(" ", classes="two")
 
-            yield Static("from")
+            yield Static("from show")
-            yield Static(" ", id="static_owner")
+            yield Static(" ", id="static_show_id")
 
             yield Static(" ", classes="two")
 
-            yield Static("Source season")
+            yield Static("Original season")
             yield Static(" ", id="static_original_season")
 
             yield Static("First episode")
@@ -128,3 +122,4 @@ class ShiftedSeasonDeleteScreen(Screen):
 
         if event.button.id == "cancel_button":
             self.app.pop_screen()
+

src/ffx/shifted_season_details_screen.py

@@ -81,7 +81,7 @@ class ShiftedSeasonDetailsScreen(Screen):
     }
     """
 
-    def __init__(self, showId = None, patternId = None, shiftedSeasonId = None):
+    def __init__(self, showId = None, shiftedSeasonId = None):
         super().__init__()
 
         self.context = self.app.getContext()
@@ -90,14 +90,8 @@ class ShiftedSeasonDetailsScreen(Screen):
         self.__ssc = ShiftedSeasonController(context = self.context)
 
         self.__showId = showId
-        self.__patternId = patternId
         self.__shiftedSeasonId = shiftedSeasonId
 
-    def _owner_kwargs(self):
-        if self.__patternId is not None:
-            return {'patternId': self.__patternId}
-        return {'showId': self.__showId}
-
     def on_mount(self):
 
         if self.__shiftedSeasonId is not None:
@@ -132,7 +126,7 @@ class ShiftedSeasonDetailsScreen(Screen):
             yield Static(" ", classes="three")
 
             # 3
-            yield Static("Source season")
+            yield Static("Original season")
             yield Input(id="input_original_season", classes="two")
 
             # 4
@@ -209,11 +203,8 @@ class ShiftedSeasonDetailsScreen(Screen):
 
                 if self.__shiftedSeasonId is not None:
 
-                    if self.__ssc.checkShiftedSeason(
+                    if self.__ssc.checkShiftedSeason(self.__showId, shiftedSeasonObj,
-                        shiftedSeasonObj=shiftedSeasonObj,
+                                                        shiftedSeasonId = self.__shiftedSeasonId):
-                        shiftedSeasonId=self.__shiftedSeasonId,
-                        **self._owner_kwargs(),
-                    ):
                         if self.__ssc.updateShiftedSeason(self.__shiftedSeasonId, shiftedSeasonObj):
                             self.dismiss((self.__shiftedSeasonId, shiftedSeasonObj))
                         else:
@@ -221,14 +212,8 @@ class ShiftedSeasonDetailsScreen(Screen):
                             self.app.pop_screen()
 
                 else:
-                    if self.__ssc.checkShiftedSeason(
+                    if self.__ssc.checkShiftedSeason(self.__showId, shiftedSeasonObj):
-                        shiftedSeasonObj=shiftedSeasonObj,
+                        self.__shiftedSeasonId = self.__ssc.addShiftedSeason(self.__showId, shiftedSeasonObj)
-                        **self._owner_kwargs(),
-                    ):
-                        self.__shiftedSeasonId = self.__ssc.addShiftedSeason(
-                            shiftedSeasonObj=shiftedSeasonObj,
-                            **self._owner_kwargs(),
-                        )
                         self.dismiss((self.__shiftedSeasonId, shiftedSeasonObj))
 
 

src/ffx/show_controller.py

@@ -16,9 +16,10 @@ class ShowController():
 
         try:
             s = self.Session()
-            show = s.query(Show).filter(Show.id == showId).first()
+            q = s.query(Show).filter(Show.id == showId)
 
-            if show is not None:
+            if q.count():
+                show: Show = q.first() 
                 return show.getDescriptor(self.context)
 
         except Exception as ex:
@@ -30,7 +31,9 @@ class ShowController():
 
         try:
             s = self.Session()
-            return s.query(Show).filter(Show.id == showId).first()
+            q = s.query(Show).filter(Show.id == showId)
+
+            return q.first() if q.count() else None
 
         except Exception as ex:
             raise click.ClickException(f"ShowController.getShow(): {repr(ex)}")
@@ -41,7 +44,12 @@ class ShowController():
 
         try:
             s = self.Session()
-            return s.query(Show).all()
+            q = s.query(Show)
+
+            if q.count():
+                return q.all()
+            else:
+                return []
 
         except Exception as ex:
             raise click.ClickException(f"ShowController.getAllShows(): {repr(ex)}")
@@ -53,23 +61,24 @@ class ShowController():
 
         try:
             s = self.Session()
-            currentShow = s.query(Show).filter(Show.id == showDescriptor.getId()).first()
+            q = s.query(Show).filter(Show.id == showDescriptor.getId())
 
-            if currentShow is None:
+            if not q.count():
                 show = Show(id = int(showDescriptor.getId()),
                         name = str(showDescriptor.getName()),
                         year = int(showDescriptor.getYear()),
                         index_season_digits = showDescriptor.getIndexSeasonDigits(),
                         index_episode_digits = showDescriptor.getIndexEpisodeDigits(),
                         indicator_season_digits = showDescriptor.getIndicatorSeasonDigits(),
-                        indicator_episode_digits = showDescriptor.getIndicatorEpisodeDigits(),
+                        indicator_episode_digits = showDescriptor.getIndicatorEpisodeDigits())
-                        quality = showDescriptor.getQuality(),
-                        notes = showDescriptor.getNotes())
 
                 s.add(show)
                 s.commit()
                 return True
             else:
+
+                currentShow = q.first()
+
                 changed = False
                 if currentShow.name != str(showDescriptor.getName()):
                     currentShow.name = str(showDescriptor.getName())
@@ -90,12 +99,6 @@ class ShowController():
                 if currentShow.indicator_episode_digits != int(showDescriptor.getIndicatorEpisodeDigits()):
                     currentShow.indicator_episode_digits = int(showDescriptor.getIndicatorEpisodeDigits())
                     changed = True
-                if int(currentShow.quality or 0) != int(showDescriptor.getQuality()):
-                    currentShow.quality = int(showDescriptor.getQuality())
-                    changed = True
-                if str(currentShow.notes or '') != str(showDescriptor.getNotes()):
-                    currentShow.notes = str(showDescriptor.getNotes())
-                    changed = True
 
                 if changed:
                     s.commit()
@@ -110,12 +113,14 @@ class ShowController():
     def deleteShow(self, show_id):
         try:
             s = self.Session()
-            show = s.query(Show).filter(Show.id == int(show_id)).first()
+            q = s.query(Show).filter(Show.id == int(show_id))
 
-            if show is not None:
+
+            if q.count():
 
                 #DAFUQ: https://stackoverflow.com/a/19245058
                 # q.delete()
+                show = q.first()
                 s.delete(show)
 
                 s.commit()

src/ffx/show_descriptor.py

@@ -1,11 +1,4 @@
-from .configuration_controller import ConfigurationController
+import logging
-from .constants import (
-    DEFAULT_SHOW_INDEX_EPISODE_DIGITS,
-    DEFAULT_SHOW_INDEX_SEASON_DIGITS,
-    DEFAULT_SHOW_INDICATOR_EPISODE_DIGITS,
-    DEFAULT_SHOW_INDICATOR_SEASON_DIGITS,
-)
-from .logging_utils import get_ffx_logger
 
 
 class ShowDescriptor():
@@ -21,45 +14,11 @@ class ShowDescriptor():
     INDEX_EPISODE_DIGITS_KEY = 'index_episode_digits'
     INDICATOR_SEASON_DIGITS_KEY = 'indicator_season_digits'
     INDICATOR_EPISODE_DIGITS_KEY = 'indicator_episode_digits'
-    QUALITY_KEY = 'quality'
-    NOTES_KEY = 'notes'
 
-    DEFAULT_INDEX_SEASON_DIGITS = DEFAULT_SHOW_INDEX_SEASON_DIGITS
+    DEFAULT_INDEX_SEASON_DIGITS = 2
-    DEFAULT_INDEX_EPISODE_DIGITS = DEFAULT_SHOW_INDEX_EPISODE_DIGITS
+    DEFAULT_INDEX_EPISODE_DIGITS = 2
-    DEFAULT_INDICATOR_SEASON_DIGITS = DEFAULT_SHOW_INDICATOR_SEASON_DIGITS
+    DEFAULT_INDICATOR_SEASON_DIGITS = 2
-    DEFAULT_INDICATOR_EPISODE_DIGITS = DEFAULT_SHOW_INDICATOR_EPISODE_DIGITS
+    DEFAULT_INDICATOR_EPISODE_DIGITS = 2
-
-    @classmethod
-    def getDefaultDigitLengths(cls, context: dict | None = None) -> dict[str, int]:
-        configurationData = {}
-
-        if context is not None:
-            configController = context.get('config')
-            if configController is not None and hasattr(configController, 'getData'):
-                configurationData = configController.getData()
-
-        return {
-            cls.INDEX_SEASON_DIGITS_KEY: ConfigurationController.getConfiguredIntegerValue(
-                configurationData,
-                ConfigurationController.DEFAULT_INDEX_SEASON_DIGITS_CONFIG_KEY,
-                cls.DEFAULT_INDEX_SEASON_DIGITS,
-            ),
-            cls.INDEX_EPISODE_DIGITS_KEY: ConfigurationController.getConfiguredIntegerValue(
-                configurationData,
-                ConfigurationController.DEFAULT_INDEX_EPISODE_DIGITS_CONFIG_KEY,
-                cls.DEFAULT_INDEX_EPISODE_DIGITS,
-            ),
-            cls.INDICATOR_SEASON_DIGITS_KEY: ConfigurationController.getConfiguredIntegerValue(
-                configurationData,
-                ConfigurationController.DEFAULT_INDICATOR_SEASON_DIGITS_CONFIG_KEY,
-                cls.DEFAULT_INDICATOR_SEASON_DIGITS,
-            ),
-            cls.INDICATOR_EPISODE_DIGITS_KEY: ConfigurationController.getConfiguredIntegerValue(
-                configurationData,
-                ConfigurationController.DEFAULT_INDICATOR_EPISODE_DIGITS_CONFIG_KEY,
-                cls.DEFAULT_INDICATOR_EPISODE_DIGITS,
-            ),
-        }
 
 
     def __init__(self, **kwargs):
@@ -73,7 +32,8 @@ class ShowDescriptor():
             self.__logger = self.__context['logger']
         else:
             self.__context = {}
-            self.__logger = get_ffx_logger()
+            self.__logger = logging.getLogger('FFX')
+            self.__logger.addHandler(logging.NullHandler())       
 
         if ShowDescriptor.ID_KEY in kwargs.keys():
                 if type(kwargs[ShowDescriptor.ID_KEY]) is not int:
@@ -96,49 +56,34 @@ class ShowDescriptor():
         else:
                 self.__showYear = -1
 
-        defaultDigitLengths = self.getDefaultDigitLengths(self.__context)
 
         if ShowDescriptor.INDEX_SEASON_DIGITS_KEY in kwargs.keys():
                 if type(kwargs[ShowDescriptor.INDEX_SEASON_DIGITS_KEY]) is not int:
                         raise TypeError(f"ShowDescriptor.__init__(): Argument {ShowDescriptor.INDEX_SEASON_DIGITS_KEY} is required to be of type int")
                 self.__indexSeasonDigits = kwargs[ShowDescriptor.INDEX_SEASON_DIGITS_KEY]
         else:
-                self.__indexSeasonDigits = defaultDigitLengths[ShowDescriptor.INDEX_SEASON_DIGITS_KEY]
+                self.__indexSeasonDigits = ShowDescriptor.DEFAULT_INDEX_SEASON_DIGITS
 
         if ShowDescriptor.INDEX_EPISODE_DIGITS_KEY in kwargs.keys():
                 if type(kwargs[ShowDescriptor.INDEX_EPISODE_DIGITS_KEY]) is not int:
                         raise TypeError(f"ShowDescriptor.__init__(): Argument {ShowDescriptor.INDEX_EPISODE_DIGITS_KEY} is required to be of type int")
                 self.__indexEpisodeDigits = kwargs[ShowDescriptor.INDEX_EPISODE_DIGITS_KEY]
         else:
-                self.__indexEpisodeDigits = defaultDigitLengths[ShowDescriptor.INDEX_EPISODE_DIGITS_KEY]
+                self.__indexEpisodeDigits = ShowDescriptor.DEFAULT_INDEX_EPISODE_DIGITS
 
         if ShowDescriptor.INDICATOR_SEASON_DIGITS_KEY in kwargs.keys():
                 if type(kwargs[ShowDescriptor.INDICATOR_SEASON_DIGITS_KEY]) is not int:
                         raise TypeError(f"ShowDescriptor.__init__(): Argument {ShowDescriptor.INDICATOR_SEASON_DIGITS_KEY} is required to be of type int")
                 self.__indicatorSeasonDigits = kwargs[ShowDescriptor.INDICATOR_SEASON_DIGITS_KEY]
         else:
-                self.__indicatorSeasonDigits = defaultDigitLengths[ShowDescriptor.INDICATOR_SEASON_DIGITS_KEY]
+                self.__indicatorSeasonDigits = ShowDescriptor.DEFAULT_INDICATOR_SEASON_DIGITS
 
         if ShowDescriptor.INDICATOR_EPISODE_DIGITS_KEY in kwargs.keys():
                 if type(kwargs[ShowDescriptor.INDICATOR_EPISODE_DIGITS_KEY]) is not int:
                         raise TypeError(f"ShowDescriptor.__init__(): Argument {ShowDescriptor.INDICATOR_EPISODE_DIGITS_KEY} is required to be of type int")
                 self.__indicatorEpisodeDigits = kwargs[ShowDescriptor.INDICATOR_EPISODE_DIGITS_KEY]
         else:
-                self.__indicatorEpisodeDigits = defaultDigitLengths[ShowDescriptor.INDICATOR_EPISODE_DIGITS_KEY]
+                self.__indicatorEpisodeDigits = ShowDescriptor.DEFAULT_INDICATOR_EPISODE_DIGITS
-
-        if ShowDescriptor.QUALITY_KEY in kwargs.keys():
-                if type(kwargs[ShowDescriptor.QUALITY_KEY]) is not int:
-                        raise TypeError(f"ShowDescriptor.__init__(): Argument {ShowDescriptor.QUALITY_KEY} is required to be of type int")
-                self.__quality = kwargs[ShowDescriptor.QUALITY_KEY]
-        else:
-                self.__quality = 0
-
-        if ShowDescriptor.NOTES_KEY in kwargs.keys():
-                if type(kwargs[ShowDescriptor.NOTES_KEY]) is not str:
-                        raise TypeError(f"ShowDescriptor.__init__(): Argument {ShowDescriptor.NOTES_KEY} is required to be of type str")
-                self.__notes = kwargs[ShowDescriptor.NOTES_KEY]
-        else:
-                self.__notes = ''
 
 
     def getId(self):
@@ -156,10 +101,6 @@ class ShowDescriptor():
         return self.__indicatorSeasonDigits
     def getIndicatorEpisodeDigits(self):
         return self.__indicatorEpisodeDigits
-    def getQuality(self):
-        return self.__quality
-    def getNotes(self):
-        return self.__notes
 
     def getFilenamePrefix(self):
         return f"{self.__showName} ({str(self.__showYear)})"

src/ffx/show_details_screen.py

@@ -1,13 +1,20 @@
 import click
 
 from textual.screen import Screen
-from textual.widgets import Header, Footer, Static, Button, DataTable, Input, TextArea
+from textual.widgets import Header, Footer, Static, Button, DataTable, Input
 from textual.containers import Grid
 from textual.widgets._data_table import CellDoesNotExist
 
+from ffx.model.pattern import Pattern
+
 from .pattern_details_screen import PatternDetailsScreen
 from .pattern_delete_screen import PatternDeleteScreen
 
+from .show_controller import ShowController
+from .pattern_controller import PatternController
+from .tmdb_controller import TmdbController
+from .shifted_season_controller import ShiftedSeasonController
+
 from .show_descriptor import ShowDescriptor
 
 from .shifted_season_details_screen import ShiftedSeasonDetailsScreen
@@ -16,7 +23,6 @@ from .shifted_season_delete_screen import ShiftedSeasonDeleteScreen
 from ffx.model.shifted_season import ShiftedSeason
 
 from .helper import filterFilename
-from .screen_support import build_screen_bootstrap, build_screen_controllers
 
 
 # Screen[dict[int, str, int]]
@@ -25,8 +31,8 @@ class ShowDetailsScreen(Screen):
     CSS = """
 
     Grid {
-        grid-size: 5 18;
+        grid-size: 5 16;
-        grid-rows: 2 2 2 2 2 2 6 2 2 2 2 2 2 9 2 9 2 2;
+        grid-rows: 2 2 2 2 2 2 2 2 2 2 2 9 2 9 2 2;
         grid-columns: 30 30 30 30 30;
         height: 100%;
         width: 100%;
@@ -77,10 +83,6 @@ class ShowDetailsScreen(Screen):
         height: 100%;
         border: solid green;
     }
-
-    .note_box {
-        min-height: 6;
-    }
     """
 
     BINDINGS = [
@@ -92,24 +94,31 @@ class ShowDetailsScreen(Screen):
     def __init__(self, showId = None):
         super().__init__()
 
-        bootstrap = build_screen_bootstrap(self.app.getContext())
+        self.context = self.app.getContext()
-        self.context = bootstrap.context
+        self.Session = self.context['database']['session'] # convenience
         
-        controllers = build_screen_controllers(
+        self.__sc = ShowController(context = self.context)
-            self.context,
+        self.__pc = PatternController(context = self.context)
-            pattern=True,
+        self.__tc = TmdbController()
-            show=True,
+        self.__ssc = ShiftedSeasonController(context = self.context)
-            tmdb=True,
-            shifted_season=True,
-        )
-        self.__sc = controllers['show']
-        self.__pc = controllers['pattern']
-        self.__tc = controllers['tmdb']
-        self.__ssc = controllers['shifted_season']
 
         self.__showDescriptor = self.__sc.getShowDescriptor(showId) if showId is not None else None
 
 
+    def loadPatterns(self, show_id : int):
+
+        try:
+            s = self.Session()
+            q = s.query(Pattern).filter(Pattern.show_id == int(show_id))
+
+            return [{'id': int(p.id), 'pattern': str(p.pattern)} for p in q.all()]
+
+        except Exception as ex:
+            raise click.ClickException(f"ShowDetailsScreen.loadPatterns(): {repr(ex)}")
+        finally:
+            s.close()
+
+
 
     def updateShiftedSeasons(self):
 
@@ -154,34 +163,23 @@ class ShowDetailsScreen(Screen):
             self.query_one("#index_episode_digits_input", Input).value = str(self.__showDescriptor.getIndexEpisodeDigits())
             self.query_one("#indicator_season_digits_input", Input).value = str(self.__showDescriptor.getIndicatorSeasonDigits())
             self.query_one("#indicator_episode_digits_input", Input).value = str(self.__showDescriptor.getIndicatorEpisodeDigits())
-            if self.__showDescriptor.getQuality():
-                self.query_one("#quality_input", Input).value = str(self.__showDescriptor.getQuality())
-            if self.__showDescriptor.getNotes():
-                self.query_one("#notes_textarea", TextArea).text = str(self.__showDescriptor.getNotes())
 
             
             #raise click.ClickException(f"show_id {showId}")
-            for pattern in self.__pc.getPatternsForShow(showId):
+            patternList = self.loadPatterns(showId)
-                row = (pattern.getPattern(),)
+            # raise click.ClickException(f"patternList {patternList}")
+            for pattern in patternList:
+                row = (pattern['pattern'],)
                 self.patternTable.add_row(*map(str, row))
 
             self.updateShiftedSeasons()
 
         else:
-            defaultDigitLengths = ShowDescriptor.getDefaultDigitLengths(self.context)
             
-            self.query_one("#index_season_digits_input", Input).value = str(
+            self.query_one("#index_season_digits_input", Input).value = "2"
-                defaultDigitLengths[ShowDescriptor.INDEX_SEASON_DIGITS_KEY]
+            self.query_one("#index_episode_digits_input", Input).value = "2"
-            )
+            self.query_one("#indicator_season_digits_input", Input).value = "2"
-            self.query_one("#index_episode_digits_input", Input).value = str(
+            self.query_one("#indicator_episode_digits_input", Input).value = "2"
-                defaultDigitLengths[ShowDescriptor.INDEX_EPISODE_DIGITS_KEY]
-            )
-            self.query_one("#indicator_season_digits_input", Input).value = str(
-                defaultDigitLengths[ShowDescriptor.INDICATOR_SEASON_DIGITS_KEY]
-            )
-            self.query_one("#indicator_episode_digits_input", Input).value = str(
-                defaultDigitLengths[ShowDescriptor.INDICATOR_EPISODE_DIGITS_KEY]
-            )
 
 
     def getSelectedPatternDescriptor(self):
@@ -219,17 +217,11 @@ class ShowDetailsScreen(Screen):
             if row_key is not None:
                 selected_row_data = self.shiftedSeasonsTable.get_row(row_key)
 
-                def parse_int_or_default(value: str, default: int) -> int:
-                    try:
-                        return int(value)
-                    except (TypeError, ValueError):
-                        return default
-
                 shiftedSeasonObj['original_season'] = int(selected_row_data[0])
-                shiftedSeasonObj['first_episode'] = parse_int_or_default(selected_row_data[1], -1)
+                shiftedSeasonObj['first_episode'] = int(selected_row_data[1]) if selected_row_data[1].isnumeric() else -1
-                shiftedSeasonObj['last_episode'] = parse_int_or_default(selected_row_data[2], -1)
+                shiftedSeasonObj['last_episode'] = int(selected_row_data[2]) if selected_row_data[2].isnumeric() else -1
-                shiftedSeasonObj['season_offset'] = parse_int_or_default(selected_row_data[3], 0)
+                shiftedSeasonObj['season_offset'] = int(selected_row_data[3]) if selected_row_data[3].isnumeric() else 0
-                shiftedSeasonObj['episode_offset'] = parse_int_or_default(selected_row_data[4], 0)
+                shiftedSeasonObj['episode_offset'] = int(selected_row_data[4]) if selected_row_data[4].isnumeric() else 0
 
 
                 if self.__showDescriptor is not None:
@@ -322,7 +314,7 @@ class ShowDetailsScreen(Screen):
 
         self.shiftedSeasonsTable = DataTable(classes="five")
 
-        self.column_key_original_season = self.shiftedSeasonsTable.add_column("Source Season", width=30)
+        self.column_key_original_season = self.shiftedSeasonsTable.add_column("Original Season", width=30)
         self.column_key_first_episode = self.shiftedSeasonsTable.add_column("First Episode", width=30)
         self.column_key_last_episode = self.shiftedSeasonsTable.add_column("Last Episode", width=30)
         self.column_key_season_offset = self.shiftedSeasonsTable.add_column("Season Offset", width=30)
@@ -356,36 +348,28 @@ class ShowDetailsScreen(Screen):
             yield Input(type="integer", id="year_input", classes="four")
 
             #5
-            yield Static("Quality")
+            yield Static(" ", classes="five")
-            yield Input(type="integer", id="quality_input", classes="four")
 
             #6
-            yield Static("Notes")
-            yield Static(" ", classes="four")
-
-            #7
-            yield TextArea(id="notes_textarea", classes="five note_box")
-
-            #8
             yield Static("Index Season Digits")
             yield Input(type="integer", id="index_season_digits_input", classes="four")
 
-            #9
+            #7
             yield Static("Index Episode Digits")
             yield Input(type="integer", id="index_episode_digits_input", classes="four")
 
-            #10
+            #8
             yield Static("Indicator Season Digits")
             yield Input(type="integer", id="indicator_season_digits_input", classes="four")
 
-            #11
+            #9
             yield Static("Indicator Edisode Digits")
             yield Input(type="integer", id="indicator_episode_digits_input", classes="four")
 
-            # 12
+            # 10
             yield Static(" ", classes="five")
 
-            # 13
+            # 11
             yield Static("Shifted seasons", classes="two")
 
             if self.__showDescriptor is not None:
@@ -397,18 +381,18 @@ class ShowDetailsScreen(Screen):
                 yield Static(" ")
                 yield Static(" ")
 
-            # 14
+            # 12
             yield self.shiftedSeasonsTable
 
-            # 15
+            # 13
             yield Static("File patterns", classes="five")
-            # 16
+            # 14
             yield self.patternTable
 
-            # 17
+            # 15
             yield Static(" ", classes="five")
 
-            # 18
+            # 16
             yield Button("Save", id="save_button")
             yield Button("Cancel", id="cancel_button")
 
@@ -418,7 +402,7 @@ class ShowDetailsScreen(Screen):
 
     def getShowDescriptorFromInput(self) -> ShowDescriptor:
 
-        kwargs = {ShowDescriptor.CONTEXT_KEY: self.context}
+        kwargs = {}
         
         try:
             if self.__showDescriptor:
@@ -454,11 +438,6 @@ class ShowDetailsScreen(Screen):
             kwargs[ShowDescriptor.INDICATOR_EPISODE_DIGITS_KEY] = int(self.query_one("#indicator_episode_digits_input", Input).value)
         except ValueError:
             pass
-        try:
-            kwargs[ShowDescriptor.QUALITY_KEY] = int(self.query_one("#quality_input", Input).value)
-        except ValueError:
-            pass
-        kwargs[ShowDescriptor.NOTES_KEY] = str(self.query_one("#notes_textarea", TextArea).text)
 
         return ShowDescriptor(**kwargs)
 

src/ffx/tag_controller.py

@@ -67,11 +67,10 @@ class TagController():
         try:
             s = self.Session()
 
-            tag = s.query(MediaTag).filter(
+            q = s.query(MediaTag).filter(MediaTag.pattern_id == int(patternId),
-                MediaTag.pattern_id == int(patternId),
+                                            MediaTag.key == str(tagKey))
-                MediaTag.key == str(tagKey),
+            if q.count():
-            ).first()
+                tag = q.first()
-            if tag is not None:
                 s.delete(tag)
                 s.commit()
                 return True
@@ -108,8 +107,12 @@ class TagController():
         try:
             s = self.Session()
                 
-            tags = s.query(MediaTag).filter(MediaTag.pattern_id == int(patternId)).all()
+            q = s.query(MediaTag).filter(MediaTag.pattern_id == int(patternId))
-            return {t.key:t.value for t in tags}
+
+            if q.count():
+                return {t.key:t.value for t in q.all()}
+            else:
+                return {}
 
         except Exception as ex:
             raise click.ClickException(f"TagController.findAllMediaTags(): {repr(ex)}")
@@ -122,8 +125,12 @@ class TagController():
         try:
             s = self.Session()
                 
-            tags = s.query(TrackTag).filter(TrackTag.track_id == int(trackId)).all()
+            q = s.query(TrackTag).filter(TrackTag.track_id == int(trackId))
-            return {t.key:t.value for t in tags}
+
+            if q.count():
+                return {t.key:t.value for t in q.all()}
+            else:
+                return {}
 
         except Exception as ex:
             raise click.ClickException(f"TagController.findAllTracks(): {repr(ex)}")
@@ -135,7 +142,12 @@ class TagController():
         
         try:
             s = self.Session()
-            return s.query(Track).filter(MediaTag.track_id == int(trackId), MediaTag.key == str(trackKey)).first()
+            q = s.query(Track).filter(MediaTag.track_id == int(trackId), MediaTag.key == str(trackKey))
+
+            if q.count():
+                return q.first()
+            else:
+                return None
 
         except Exception as ex:
             raise click.ClickException(f"TagController.findMediaTag(): {repr(ex)}")
@@ -146,10 +158,12 @@ class TagController():
         
         try:
             s = self.Session()
-            return s.query(TrackTag).filter(
+            q = s.query(TrackTag).filter(TrackTag.track_id == int(trackId), TrackTag.key == str(tagKey))
-                TrackTag.track_id == int(trackId),
+
-                TrackTag.key == str(tagKey),
+            if q.count():
-            ).first()
+                return q.first()
+            else:
+                return None
 
         except Exception as ex:
             raise click.ClickException(f"TagController.findTrackTag(): {repr(ex)}")
@@ -161,9 +175,11 @@ class TagController():
     def deleteMediaTag(self, tagId) -> bool:
         try:
             s = self.Session()
-            tag = s.query(MediaTag).filter(MediaTag.id == int(tagId)).first()
+            q = s.query(MediaTag).filter(MediaTag.id == int(tagId))
 
-            if tag is not None:
+            if q.count():
+
+                tag = q.first()
 
                 s.delete(tag)
 
@@ -185,9 +201,11 @@ class TagController():
 
         try:
             s = self.Session()
-            tag = s.query(TrackTag).filter(TrackTag.id == int(tagId)).first()
+            q = s.query(TrackTag).filter(TrackTag.id == int(tagId))
 
-            if tag is not None:
+            if q.count():
+
+                tag = q.first()
 
                 s.delete(tag)
 

src/ffx/test/basename_combinator.py

@@ -24,9 +24,8 @@ class BasenameCombinator():
 
     @staticmethod
     def getClassReference(identifier):
-        module_name = f"tests.legacy.basename_combinator_{ identifier }"
+        importlib.import_module(f"ffx.test.basename_combinator_{ identifier }")
-        importlib.import_module(module_name)
+        for name, obj in inspect.getmembers(sys.modules[f"ffx.test.basename_combinator_{ identifier }"]):
-        for name, obj in inspect.getmembers(sys.modules[module_name]):
             #HINT: Excluding MediaCombinator as it seems to be included by import (?)
             if inspect.isclass(obj) and name != 'BasenameCombinator' and name.startswith('BasenameCombinator'):
                 return obj

src/ffx/test/disposition_combinator_2.py

@@ -24,9 +24,8 @@ class DispositionCombinator2():
 
     @staticmethod
     def getClassReference(identifier):
-        module_name = f"tests.legacy.disposition_combinator_2_{ identifier }"
+        importlib.import_module(f"ffx.test.disposition_combinator_2_{ identifier }")
-        importlib.import_module(module_name)
+        for name, obj in inspect.getmembers(sys.modules[f"ffx.test.disposition_combinator_2_{ identifier }"]):
-        for name, obj in inspect.getmembers(sys.modules[module_name]):
             #HINT: Excluding DispositionCombination as it seems to be included by import (?)
             if inspect.isclass(obj) and name != 'DispositionCombinator2' and name.startswith('DispositionCombinator2'):
                 return obj

src/ffx/test/disposition_combinator_3.py

@@ -23,9 +23,8 @@ class DispositionCombinator3():
 
     @staticmethod
     def getClassReference(identifier):
-        module_name = f"tests.legacy.disposition_combinator_3_{ identifier }"
+        importlib.import_module(f"ffx.test.disposition_combinator_3_{ identifier }")
-        importlib.import_module(module_name)
+        for name, obj in inspect.getmembers(sys.modules[f"ffx.test.disposition_combinator_3_{ identifier }"]):
-        for name, obj in inspect.getmembers(sys.modules[module_name]):
             #HINT: Excluding DispositionCombination as it seems to be included by import (?)
             if inspect.isclass(obj) and name != 'DispositionCombinator3' and name.startswith('DispositionCombinator3'):
                 return obj

src/ffx/test/helper.py

@@ -1,9 +1,11 @@
 import os, math, tempfile, click
 
+
+from ffx.ffx_controller import FfxController
+
 from ffx.process import executeProcess
 
 from ffx.media_descriptor import MediaDescriptor
-from ffx.media_descriptor_change_set import MediaDescriptorChangeSet
 from ffx.track_type import TrackType
 
 from ffx.helper import dictCache
@@ -147,6 +149,7 @@ def createMediaTestFile(mediaDescriptor: MediaDescriptor,
 
     # subtitleFilePath = createVttFile(SHORT_SUBTITLE_SEQUENCE)
 
+    # commandTokens = FfxController.COMMAND_TOKENS
     commandTokens = ['ffmpeg', '-y']
 
     generatorCache = []
@@ -229,14 +232,15 @@ def createMediaTestFile(mediaDescriptor: MediaDescriptor,
                                     f"{mediaTagKey}={mediaTagValue}"]
             subIndexCounter[trackType] += 1
 
+    #TODO: Optimize too many runs
     ffxContext = {'config': ConfigurationController(), 'logger': logger}
-    mdcs = MediaDescriptorChangeSet(ffxContext, mediaDescriptor)
+    fc = FfxController(ffxContext, mediaDescriptor)
 
     commandTokens += (generatorTokens
                         + importTokens
                         + mappingTokens
                         + metadataTokens
-                        + mdcs.generateDispositionTokens())
+                        + fc.generateDispositionTokens())
 
 
     commandTokens += ['-t', str(length)]

src/ffx/test/label_combinator.py

@@ -25,9 +25,8 @@ class LabelCombinator():
 
     @staticmethod
     def getClassReference(identifier):
-        module_name = f"tests.legacy.{LabelCombinator.PREFIX}{ identifier }"
+        importlib.import_module(f"ffx.test.{LabelCombinator.PREFIX}{ identifier }")
-        importlib.import_module(module_name)
+        for name, obj in inspect.getmembers(sys.modules[f"ffx.test.{LabelCombinator.PREFIX}{ identifier }"]):
-        for name, obj in inspect.getmembers(sys.modules[module_name]):
             #HINT: Excluding MediaCombinator as it seems to be included by import (?)
             if inspect.isclass(obj) and name != 'LabelCombinator' and name.startswith('LabelCombinator'):
                 return obj

src/ffx/test/media_combinator.py

@@ -22,9 +22,8 @@ class MediaCombinator():
 
     @staticmethod
     def getClassReference(identifier):
-        module_name = f"tests.legacy.media_combinator_{ identifier }"
+        importlib.import_module(f"ffx.test.media_combinator_{ identifier }")
-        importlib.import_module(module_name)
+        for name, obj in inspect.getmembers(sys.modules[f"ffx.test.media_combinator_{ identifier }"]):
-        for name, obj in inspect.getmembers(sys.modules[module_name]):
             #HINT: Excluding MediaCombinator as it seems to be included by import (?)
             if inspect.isclass(obj) and name != 'MediaCombinator' and name.startswith('MediaCombinator'):
                 return obj

src/ffx/test/media_tag_combinator.py

@@ -22,9 +22,8 @@ class MediaTagCombinator():
 
     @staticmethod
     def getClassReference(identifier):
-        module_name = f"tests.legacy.media_tag_combinator_{ identifier }"
+        importlib.import_module(f"ffx.test.media_tag_combinator_{ identifier }")
-        importlib.import_module(module_name)
+        for name, obj in inspect.getmembers(sys.modules[f"ffx.test.media_tag_combinator_{ identifier }"]):
-        for name, obj in inspect.getmembers(sys.modules[module_name]):
             #HINT: Excluding MediaCombinator as it seems to be included by import (?)
             if inspect.isclass(obj) and name != 'MediaTagCombinator' and name.startswith('MediaTagCombinator'):
                 return obj

src/ffx/test/scenario.py

@@ -4,7 +4,7 @@ from ffx.show_controller import ShowController
 from ffx.pattern_controller import PatternController
 from ffx.media_controller import MediaController
 
-from .helper import createEmptyDirectory
+from ffx.test.helper import createEmptyDirectory
 from ffx.database import databaseContext
 
 class Scenario():
@@ -90,7 +90,11 @@ class Scenario():
     def __init__(self, context = None):
         self._context = context
         self._testDirectory = createEmptyDirectory()
-        self._ffxModuleName = 'ffx'
+        self._ffxExecutablePath = os.path.join(
+                                    os.path.dirname(
+                                        os.path.dirname(
+                                            os.path.dirname(__file__))),
+                                            'ffx.py')
 
         self._logger = context['logger']
         self._reportLogger = context['report_logger']
@@ -142,9 +146,8 @@ class Scenario():
 
     @staticmethod
     def getClassReference(identifier):
-        module_name = f"tests.legacy.scenario_{ identifier }"
+        importlib.import_module(f"ffx.test.scenario_{ identifier }")
-        importlib.import_module(module_name)
+        for name, obj in inspect.getmembers(sys.modules[f"ffx.test.scenario_{ identifier }"]):
-        for name, obj in inspect.getmembers(sys.modules[module_name]):
             #HINT: Excluding Scenario as it seems to be included by import (?)
             if inspect.isclass(obj) and name != 'Scenario' and name.startswith('Scenario'):
                 return obj

src/ffx/test/scenario_1.py

@@ -2,7 +2,7 @@ import os, sys, click, glob
 
 from .scenario import Scenario
 
-from .helper import createMediaTestFile
+from ffx.test.helper import createMediaTestFile
 from ffx.process import executeProcess
 
 from ffx.file_properties import FileProperties
@@ -13,9 +13,9 @@ from ffx.track_descriptor import TrackDescriptor
 from ffx.track_type import TrackType
 from ffx.track_disposition import TrackDisposition
 
-from .media_combinator_0 import MediaCombinator0
+from ffx.test.media_combinator_0 import MediaCombinator0
 
-from .basename_combinator import BasenameCombinator
+from ffx.test.basename_combinator import BasenameCombinator
 
 
 class Scenario1(Scenario):
@@ -92,7 +92,8 @@ class Scenario1(Scenario):
 
         # Phase 2: Run ffx
 
-        commandSequence = [sys.executable, '-m', self._ffxModuleName]
+        commandSequence = [sys.executable,
+                            self._ffxExecutablePath]
         
         if self._context['verbosity']:
             commandSequence += ['--verbose',

src/ffx/test/scenario_2.py

@@ -2,7 +2,7 @@ import os, sys, click
 
 from .scenario import Scenario
 
-from .helper import createMediaTestFile
+from ffx.test.helper import createMediaTestFile
 from ffx.process import executeProcess
 
 from ffx.file_properties import FileProperties
@@ -13,7 +13,7 @@ from ffx.track_descriptor import TrackDescriptor
 from ffx.track_type import TrackType
 from ffx.track_disposition import TrackDisposition
 
-from .media_combinator import MediaCombinator
+from ffx.test.media_combinator import MediaCombinator
 
 
 class Scenario2(Scenario):
@@ -77,7 +77,8 @@ class Scenario2(Scenario):
 
         # Phase 2: Run ffx
 
-        commandSequence = [sys.executable, '-m', self._ffxModuleName]
+        commandSequence = [sys.executable,
+                            self._ffxExecutablePath]
         
         if self._context['verbosity']:
             commandSequence += ['--verbose',

src/ffx/test/scenario_4.py

@@ -2,11 +2,11 @@ import os, sys, click
 
 from .scenario import Scenario
 
-from .helper import createMediaTestFile
+from ffx.test.helper import createMediaTestFile
 from ffx.process import executeProcess
 from ffx.database import databaseContext
 
-from .helper import createEmptyDirectory
+from ffx.test.helper import createEmptyDirectory
 from ffx.helper import getEpisodeFileBasename
 
 from ffx.file_properties import FileProperties
@@ -17,8 +17,8 @@ from ffx.track_descriptor import TrackDescriptor
 from ffx.track_type import TrackType
 from ffx.track_disposition import TrackDisposition
 
-from .media_combinator import MediaCombinator
+from ffx.test.media_combinator import MediaCombinator
-from .indicator_combinator import IndicatorCombinator
+from ffx.test.indicator_combinator import IndicatorCombinator
 
 from ffx.show_descriptor import ShowDescriptor
 
@@ -163,7 +163,8 @@ class Scenario4(Scenario):
 
         # Phase 3: Run ffx
 
-        commandSequence = [sys.executable, '-m', self._ffxModuleName]
+        commandSequence = [sys.executable,
+                            self._ffxExecutablePath]
         
         if self._context['verbosity']:
             commandSequence += ['--verbose',

src/ffx/test/track_tag_combinator_2.py

@@ -22,9 +22,8 @@ class TrackTagCombinator2():
 
     @staticmethod
     def getClassReference(identifier):
-        module_name = f"tests.legacy.track_tag_combinator_2_{ identifier }"
+        importlib.import_module(f"ffx.test.track_tag_combinator_2_{ identifier }")
-        importlib.import_module(module_name)
+        for name, obj in inspect.getmembers(sys.modules[f"ffx.test.track_tag_combinator_2_{ identifier }"]):
-        for name, obj in inspect.getmembers(sys.modules[module_name]):
             #HINT: Excluding DispositionCombination as it seems to be included by import (?)
             if inspect.isclass(obj) and name != 'TrackTagCombinator2' and name.startswith('TrackTagCombinator2'):
                 return obj

src/ffx/test/track_tag_combinator_3.py

@@ -22,9 +22,8 @@ class TrackTagCombinator3():
 
     @staticmethod
     def getClassReference(identifier):
-        module_name = f"tests.legacy.track_tag_combinator_3_{ identifier }"
+        importlib.import_module(f"ffx.test.track_tag_combinator_3_{ identifier }")
-        importlib.import_module(module_name)
+        for name, obj in inspect.getmembers(sys.modules[f"ffx.test.track_tag_combinator_3_{ identifier }"]):
-        for name, obj in inspect.getmembers(sys.modules[module_name]):
             #HINT: Excluding DispositionCombination as it seems to be included by import (?)
             if inspect.isclass(obj) and name != 'TrackTagCombinator3' and name.startswith('TrackTagCombinator3'):
                 return obj