ff

tests/unit/test_database.py

@@ -66,7 +66,7 @@ class DatabaseContextTests(unittest.TestCase):
 
         return shifted_season_id
 
-    def rewrite_shows_table_without_quality(self, cursor):
+    def rewrite_shows_table_without_show_fields(self, cursor):
         cursor.execute("ALTER TABLE shows RENAME TO shows_current")
         cursor.execute(
             """
@@ -208,7 +208,7 @@ class DatabaseContextTests(unittest.TestCase):
             cursor = connection.cursor()
             cursor.execute("PRAGMA foreign_keys=OFF")
             self.rewrite_shifted_seasons_table_without_pattern_owner(cursor)
-            self.rewrite_shows_table_without_quality(cursor)
+            self.rewrite_shows_table_without_show_fields(cursor)
             cursor.execute(
                 "UPDATE properties SET value = '2' WHERE key = ?",
                 (DATABASE_VERSION_KEY,),
@@ -245,6 +245,7 @@ class DatabaseContextTests(unittest.TestCase):
                 migrated_show = session.query(Show).filter(Show.id == 1).first()
                 self.assertIsNotNone(migrated_show)
                 self.assertEqual(0, int(migrated_show.quality or 0))
+                self.assertEqual('', str(migrated_show.notes or ''))
             finally:
                 session.close()
         finally:
@@ -286,6 +287,40 @@ class DatabaseContextTests(unittest.TestCase):
         self.assertEqual("Database migration aborted by user.", str(raisedContext.exception))
         self.assertFalse(Path(f"{self.database_path}.v2-to-v{DATABASE_VERSION}.bak").exists())
 
+    def test_database_context_repairs_current_show_schema_without_version_bump(self):
+        self.create_demo_show_with_shift()
+
+        connection = sqlite3.connect(self.database_path)
+        try:
+            cursor = connection.cursor()
+            cursor.execute("PRAGMA foreign_keys=OFF")
+            self.rewrite_shows_table_without_show_fields(cursor)
+            connection.commit()
+        finally:
+            connection.close()
+
+        with patch("ffx.database.click.confirm") as mocked_confirm, patch(
+            "ffx.database.click.echo"
+        ) as mocked_echo:
+            reopened_context = databaseContext(str(self.database_path))
+        try:
+            self.assertEqual(DATABASE_VERSION, getDatabaseVersion(reopened_context))
+
+            Session = reopened_context["session"]
+            session = Session()
+            try:
+                repaired_show = session.query(Show).filter(Show.id == 1).first()
+                self.assertIsNotNone(repaired_show)
+                self.assertEqual(0, int(repaired_show.quality or 0))
+                self.assertEqual('', str(repaired_show.notes or ''))
+            finally:
+                session.close()
+        finally:
+            reopened_context["engine"].dispose()
+
+        mocked_confirm.assert_not_called()
+        mocked_echo.assert_not_called()
+
 
 if __name__ == "__main__":
     unittest.main()

tests/unit/test_show_descriptor_defaults.py

@@ -57,6 +57,7 @@ class ShowDescriptorDefaultTests(unittest.TestCase):
         self.assertEqual(3, descriptor.getIndicatorSeasonDigits())
         self.assertEqual(4, descriptor.getIndicatorEpisodeDigits())
         self.assertEqual(0, descriptor.getQuality())
+        self.assertEqual("", descriptor.getNotes())
 
     def test_show_descriptor_without_context_uses_shared_constants(self):
         descriptor = ShowDescriptor(id=1, name="Default Show", year=2024)
@@ -72,12 +73,18 @@ class ShowDescriptorDefaultTests(unittest.TestCase):
             descriptor.getIndicatorEpisodeDigits(),
         )
         self.assertEqual(0, descriptor.getQuality())
+        self.assertEqual("", descriptor.getNotes())
 
     def test_show_descriptor_preserves_explicit_quality(self):
         descriptor = ShowDescriptor(id=1, name="Quality Show", year=2024, quality=23)
 
         self.assertEqual(23, descriptor.getQuality())
 
+    def test_show_descriptor_preserves_explicit_notes(self):
+        descriptor = ShowDescriptor(id=1, name="Notes Show", year=2024, notes="show notes")
+
+        self.assertEqual("show notes", descriptor.getNotes())
+
     def test_episode_basename_uses_configured_digit_defaults_when_omitted(self):
         basename = getEpisodeFileBasename(
             "Configured Show",